PB-521 : add geolocation feedback on Cesium#874
Merged
Conversation
Passing run #2344 ↗︎
Details:
Review all test suite changes for PR #874 ↗︎ |
|||||||||||||||
ltkum
approved these changes
May 30, 2024
Contributor
ltkum
left a comment
There was a problem hiding this comment.
Apart from the issue already mentionned, it seems to be working fine, but I noticed that on my desktop, when I activate the geolocation, it asks twice for it before processing the query. (I'm not checking the 'remember my decision'
This is not really that big of an issue IMO.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There's still issues when keeping the geolocation active and swapping between 2D and 3D, but we might be able to "live with it" and have a ticket to fix that after go-live (ticket here)
Test link