PB-228 : add aggregate layer support to 3D#876
Merged
Conversation
Passing run #2365 ↗︎
Details:
Review all test suite changes for PR #876 ↗︎ |
|||||||||||||||
02d6092 to
d36a73d
Compare
ltkum
approved these changes
May 30, 2024
Contributor
ltkum
left a comment
There was a problem hiding this comment.
After testing for a bit, it seems it works as expected.
removing the visible flag being used, we already remove the component altogether when the visibility flag is false, and it hinders aggregate from being displayed (sub-layers have their visibility flag set to false in the config for some reasons...) Also removing the subdomain for WMS, as we are fine landing always on the main URL endpoint (and can be problematic for external layer support)
d36a73d to
9ee3c61
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
removing the visible flag being used, we already remove the component altogether when the visibility flag is false, and it hinders aggregate from being displayed (sub-layers have their visibility flag set to false in the config for some reasons...) Also removing the subdomain for WMS, as we are fine landing always on the main URL endpoint (and can be problematic for external layer support)
Note : a good aggregate layer candidate is the RBD layer loaded by default in the displayed map (will be a WMTS for a while and switch to a WMS when closer to the ground)
Test link