Merged
Conversation
Passing run #2369 ↗︎
Details:
Review all test suite changes for PR #872 ↗︎ |
|||||||||||||||
ee19c4b to
48d531f
Compare
48d531f to
589b4ae
Compare
Contributor
Author
I think we could, but that's not a big deal to keep it there too |
Cesium CSS was altering how our buttons were shown, adding some padding or margins there and there. As we were importing the Cesium CSS file just to place the canvas (and its Cesium generated parent divs) correctly, I've switched to declare this CSS ourselves and remove the import of the Cesium CSS file. Also removing a couple wrapping divs in the Cesium component that are not useful, as they clutter our "real" DOM with many empty divs
making the inject a factory method, so it won't be computed at startup (on mount) but only the first time it is being used
589b4ae to
5ae2a0b
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Cesium CSS was altering how our buttons were shown, adding some padding or margins there and there. As we were importing the Cesium CSS file just to place the canvas (and its Cesium generated parent divs) correctly, I've switched to declare this CSS ourselves and remove the import of the Cesium CSS file.
Also removing a couple wrapping divs in the Cesium component that are not useful, as they clutter our "real" DOM with many empty divs
Test link