PB-493: Fixed Time slider input cutoff on 3d Maps#830
Merged
Conversation
Passing run #2096 ↗︎
Details:
Review all test suite changes for PR #830 ↗︎ |
|||||||||||||||
cd79abf to
cbeceef
Compare
pakb
approved these changes
May 13, 2024
Contributor
pakb
left a comment
There was a problem hiding this comment.
Yep, with the comment on why we have this #cesium selector, that's quite good enough for a go-live without touching too much how we import Cesium's CSS 👍
The cesium style sheet overrides the global font. By changing the selector slightly we can give it more specifity and keep the original font
The cesium style sheet introduces a little bit of margin on the inputs which breaks the style of the time slider
cbeceef to
9a2a57a
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
RFC
This could be one possible solution. It only addresses the font and the margin of the time slider though. There could potentially be other things that break with the cesium style. (1)
Another solution could be to re-order the css. For that, we'd have to prematurely load Cesium's
widgets.cssI guess, before our other rules are applied. The drawback would be that there's always cesium style around even if the 3d map isn't used.Open for other suggestions.
(1)
Although, when scanning through the
Cesium/Widgets/widgets.css, the only other global style apart frominputisul. Everything else is a.cesium-prefixed class. So maybe it won't break too much.Test link