Skip to content

PB-538 : split profile too long for backend into chunks#875

Merged
pakb merged 3 commits intodevelopfrom
feat_PB-538_split_profile_request_too_long
May 30, 2024
Merged

PB-538 : split profile too long for backend into chunks#875
pakb merged 3 commits intodevelopfrom
feat_PB-538_split_profile_request_too_long

Conversation

@pakb
Copy link
Contributor

@pakb pakb commented May 29, 2024

in the same way we split the profile regarding LV95 bound, we now also cut it in portions/chunks of 3000 points, in order not to hit the hard limit of 5k point set in our backend

Test link

@cypress
Copy link

cypress bot commented May 29, 2024

Passing run #2354 ↗︎

0 207 20 0 Flakiness 0

Details:

PB-538 : add unit test to cover the split chunk function
Project: web-mapviewer Commit: 3c152878c1
Status: Passed Duration: 05:22 💡
Started: May 30, 2024 12:19 PM Ended: May 30, 2024 12:24 PM

Review all test suite changes for PR #875 ↗︎

@pakb pakb requested review from ltkum, ltshb and schtibe May 30, 2024 05:26
Copy link
Contributor

@ltkum ltkum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tested it with the very big kml file we used to test in PB-378, and it works fine. I would add a small unit test on splitIfTooManyPoints and then you're good to go.

pakb added 3 commits May 30, 2024 14:14
in the same way we split the profile regarding LV95 bound, we now also cut it in portions/chunks of 3000 points, in order not to hit the hard limit of 5k point set in our backend
@pakb pakb force-pushed the feat_PB-538_split_profile_request_too_long branch from 1468eba to 3c15287 Compare May 30, 2024 12:14
@pakb pakb merged commit 15965e8 into develop May 30, 2024
@pakb pakb deleted the feat_PB-538_split_profile_request_too_long branch May 30, 2024 12:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants