PB-490: move 3d zoom buttons to right toolbox#841
Merged
Conversation
Passing run #2363 ↗︎
Details:
Review all test suite changes for PR #841 ↗︎ |
|||||||||||||||
8662e62 to
0014dcd
Compare
0014dcd to
d4c43f1
Compare
pakb
reviewed
May 28, 2024
pakb
approved these changes
May 28, 2024
Comment on lines
+646
to
+655
|
|
||
| $compass-size: 95px; | ||
|
|
||
| &-compass { | ||
| position: relative; | ||
| width: $compass-size; | ||
| height: $compass-size; | ||
| --cesium-compass-stroke-color: rgba(0, 0, 0, 0.6); | ||
| --cesium-compass-fill-color: rgb(224, 225, 226); | ||
| } |
Contributor
There was a problem hiding this comment.
doesn't really matter, but as there's now only this compass in the toolbox, there's no more a container and many children. So this (S)CSS could be flatten, and the class cesium-toolbox-compass be removed or used as the primary identifier/selector for all the rules withint cesium-toolbox and cesium-toolbox-compass
df04ee7 to
1dbf13b
Compare
Issue : The zoom in and out buttons were added to the cesium viewer near the compass, when it is a bit more logical to have them stay where they are in the 2D viewer. Fix : We move the logic of those buttons to the toolbox zoom buttons, use that logic when we are in 3d, and removed the cesium buttons. temp
removing comment
…t was moved from the cesium toolbox to the zoom buttons
lintint
0bd3729 to
b2a8461
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue : The zoom in and out buttons were added to the cesium viewer near the compass, when it is a bit more logical to have them stay where they are in the 2D viewer.
Fix : We move the logic of those buttons to the toolbox zoom buttons, use that logic when we are in 3d, and removed the cesium buttons.
still todo :
tests
move compass directly to cesium map, as we no longer need a toolbox wrapper
Test link