PB-472 : profile in the context of the new floating tooltip#862
PB-472 : profile in the context of the new floating tooltip#862
Conversation
Passing run #2370 ↗︎
Details:
Review all test suite changes for PR #862 ↗︎ |
|||||||||||||||
|
Something that has nothing to do with your PR, but maybe it would be good to fix here: the icons in in the "window bar" of the tooltip don't have a hover tooltip description (only the print icon does). Also, the close icon has more visual distance from the right border than the description on the left ;) Also, the bottom feature info has icons of different size and style: |
ltkum
left a comment
There was a problem hiding this comment.
Hey, from using it a bit :
When choosing to have the feature info at the bottom with the profile, it no longer shows the feature information. I do not know if it is by design, but it did confuse me when using it.
02b4099 to
ff67282
Compare
We could have a ticket to fix those little things, but I'd really like a review of the current work in this PR if possible 😉 |
ff67282 to
804065c
Compare
804065c to
ac2f98c
Compare
Totally fine! |
| v-if="showContainer" | ||
| class="infobox card rounded-0 clear-no-ios-long-press" | ||
| data-cy="infobox" | ||
| @contextmenu.stop |
There was a problem hiding this comment.
Is this needed? It's just a div, where does the event come from?
There was a problem hiding this comment.
that was already there, my linter just made one line for each entry.
I think it's there to not have the context menu when right clicking on the whole Infobox, don't know if it is really useful 🫤
Changes how the profile handles itself when the floating tooltip is active, closing the profile now only unselect the profile feature (and do not close the selected features anymore) While the feature info is at the bottom, the profile is now shown as an "off-shoot" or second tab of the selected features, taking the whole width of the screen. Adding a "Back" button at the top of the infobox panel to go back to feature details. Rework of the profile width management so that it doesn't overflow its parent. Also adding a little spacer between each profile information (going Composition API in the process)
using flex column to display both feature detail and profile within the infobox
ac2f98c to
de9bb96
Compare
Changes how the profile handles itself when the floating tooltip is active, closing the profile now only unselect the profile feature (and do not close the selected features anymore)
While the feature info is at the bottom, the profile is now shown as an "off-shoot" or second tab of the selected features, taking the whole width of the screen. Adding a "Back" button at the top of the infobox panel to go back to feature details.
Rework of the profile width management so that it doesn't overflow its parent. Also adding a little spacer between each profile information (going Composition API in the process)
Test link