Merged
Conversation
Signed-off-by: Ian Chen <ichen@osrfoundation.org>
* Fix cmake warning about newlines * Find python3 in cmake, fix warning (gazebosim#328) Signed-off-by: Steve Peters <scpeters@openrobotics.org>
Merge 6 -> 9
Adds a sentence to the behavior of //model/static to avoid confusion on what might happen if it is used within a model that is itself included in another model. Also adds some clarification to //model/@canonical_link. Signed-off-by: FirefoxMetzger <sebastian@wallkoetter.net> Signed-off-by: Addisu Z. Taddese <addisu@openrobotics.org> Co-authored-by: Addisu Z. Taddese <addisu@openrobotics.org>
Signed-off-by: Jenn Nguyen <jenn@openrobotics.org>
Signed-off-by: Louise Poubel <louise@openrobotics.org>
This replaces most of the custom cmake code in libsdformat with the functionality provided by ignition-cmake2. The root CMakeLists.txt is much shorter now and most of the cmake folder has been deleted. This is made possible by the NO_IGNITION_PREFIX and REPLACE_IGNITION_INCLUDE_PATH parameters added to ign_configure_project in ign-cmake#190 and ign-cmake#191. Closes gazebosim#181. Other details: * Use FindIgnURDFDOM from ign-cmake#193 * Use HIDE_SYMBOLS_BY_DEFAULT from ign-cmake#196 * Set LEGACY_PROJECT_PREFIX from ign-cmake#199 Signed-off-by: Steve Peters <scpeters@openrobotics.org>
Signed-off-by: Steve Peters <scpeters@openrobotics.org>
The USE_INTERNAL_URDF logic for include and windows compiler definitions needs to be repeated for tests that add parser_urdf.cc via target_sources. An interface library is used to deduplicate the cmake logic. Signed-off-by: Steve Peters <scpeters@openrobotics.org>
Signed-off-by: Steve Peters <scpeters@openrobotics.org>
Signed-off-by: Steve Peters <scpeters@openrobotics.org>
Account for new behavior of nested models and :: syntax. Signed-off-by: Steve Peters <scpeters@openrobotics.org>
Merge part of 10 to 11
Signed-off-by: Steve Peters <scpeters@openrobotics.org>
Merge sdf10 -> sdf11
Codecov Report
@@ Coverage Diff @@
## sdf12 #810 +/- ##
==========================================
- Coverage 90.70% 90.70% -0.01%
==========================================
Files 78 78
Lines 12439 12437 -2
==========================================
- Hits 11283 11281 -2
Misses 1156 1156
Continue to review full report at Codecov.
|
Signed-off-by: Steve Peters <scpeters@openrobotics.org>
ahcorde
approved these changes
Dec 30, 2021
7 tasks
scpeters
added a commit
that referenced
this pull request
Mar 21, 2022
|
This pull request has been mentioned on Gazebo Community. There might be relevant details there: https://community.gazebosim.org/t/new-ignition-releases-2022-04-13-fortress-edifice/1367/1 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
9 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
➡️ Forward port
Port
sdf11tosdf12Branch comparison: sdf12...sdf11
Note to maintainers: Remember to Merge with commit (not squash-merge or rebase)