Skip to content

9 ➡️ 10#795

Merged
chapulina merged 6 commits intosdf10from
chapulina/9_to_10
Dec 21, 2021
Merged

9 ➡️ 10#795
chapulina merged 6 commits intosdf10from
chapulina/9_to_10

Conversation

@chapulina
Copy link
Copy Markdown
Contributor

➡️ Forward port

Port sdf9 to sdf10

Branch comparison: sdf10...sdf9

Note to maintainers: Remember to Merge with commit (not squash-merge or rebase)

🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸

iche033 and others added 6 commits November 8, 2021 12:00
Signed-off-by: Ian Chen <ichen@osrfoundation.org>
* Fix cmake warning about newlines
* Find python3 in cmake, fix warning (#328)

Signed-off-by: Steve Peters <scpeters@openrobotics.org>
Signed-off-by: Jenn Nguyen <jenn@openrobotics.org>
Signed-off-by: Louise Poubel <louise@openrobotics.org>
@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented Dec 21, 2021

Codecov Report

Merging #795 (e5c29da) into sdf10 (251c354) will increase coverage by 0.03%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##            sdf10     #795      +/-   ##
==========================================
+ Coverage   88.31%   88.35%   +0.03%     
==========================================
  Files          66       66              
  Lines       10570    10571       +1     
==========================================
+ Hits         9335     9340       +5     
+ Misses       1235     1231       -4     
Impacted Files Coverage Δ
src/parser.cc 79.78% <100.00%> (+0.46%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 251c354...e5c29da. Read the comment docs.

@scpeters scpeters requested a review from jennuine December 21, 2021 07:49
@chapulina chapulina merged commit 6b53f95 into sdf10 Dec 21, 2021
@chapulina chapulina deleted the chapulina/9_to_10 branch December 21, 2021 20:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

🔮 dome Ignition Dome

Projects

None yet

Development

Successfully merging this pull request may close these issues.

8 participants