Skip to content

Find python3 in cmake, fix warning#328

Merged
scpeters merged 2 commits intogazebosim:sdf9from
scpeters:cmake_python3_9
Aug 6, 2020
Merged

Find python3 in cmake, fix warning#328
scpeters merged 2 commits intogazebosim:sdf9from
scpeters:cmake_python3_9

Conversation

@scpeters
Copy link
Copy Markdown
Member

@scpeters scpeters commented Aug 3, 2020

There are some cmake warnings now reported by jenkins since we upgraded one of the jenkins plugins:

CMake Warning at CMakeLists.txt:226 (message):
  -- 	Python psutil package not found.  Memory leak tests will be skipped

The issue is that we are installing the python3 version of psutil, so we need to find the python3 interpreter in cmake.

@scpeters
Find python3 in cmake
dd480ad 
Signed-off-by: Steve Peters <scpeters@openrobotics.org>
@scpeters scpeters requested a review from j-rivero August 3, 2020 23:18
@mjcarroll
Copy link
Copy Markdown

mjcarroll commented Aug 4, 2020

The sdformat ci is still failing one test, which seems psutil related:

81: [ RUN      ] ElementMemoryLeak.SDFCreateDestroy
81: Traceback (most recent call last):
81:   File "/var/lib/jenkins/workspace/sdformat-ci-pr_any-ubuntu_auto-amd64/sdformat/tools/get_mem_info.py", line 4, in <module>
81:     import psutil;
81: ImportError: No module named psutil
81: unknown file: Failure
81: C++ exception with description "stoi" thrown in the test body.

@scpeters
Use python3 in test
1f84744 
Signed-off-by: Steve Peters <scpeters@openrobotics.org>
@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented Aug 4, 2020

Codecov Report

Merging #328 into sdf9 will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             sdf9     #328   +/-   ##
=======================================
  Coverage   86.40%   86.40%           
=======================================
  Files          59       59           
  Lines        9053     9053           
=======================================
  Hits         7822     7822           
  Misses       1231     1231

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 33d24e6...1f84744. Read the comment docs.

@scpeters
Copy link
Copy Markdown
Member Author

scpeters commented Aug 4, 2020

The sdformat ci is still failing one test, which seems psutil related:

should be fixed by 1f84744

@scpeters
Copy link
Copy Markdown
Member Author

scpeters commented Aug 5, 2020

CI is 🟢

azeey
azeey approved these changes Aug 5, 2020
View reviewed changes
Copy link
Copy Markdown
Collaborator

@azeey azeey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! I guess CMake warnings are ignored in windows?

@scpeters
Copy link
Copy Markdown
Member Author

scpeters commented Aug 6, 2020

LGTM! I guess CMake warnings are ignored in windows?

I guess not; it actually has quite a few cmake warnings, but we'll just leave those alone for now

@scpeters scpeters merged commit 91b454f into gazebosim:sdf9 Aug 6, 2020
@scpeters scpeters deleted the cmake_python3_9 branch August 6, 2020 18:15
scpeters added a commit that referenced this pull request Aug 6, 2020
@scpeters
Changelog for #328
99b7d9f 
Signed-off-by: Steve Peters <scpeters@openrobotics.org>
scpeters added a commit to scpeters/sdformat that referenced this pull request Aug 6, 2020
@scpeters
Find python3 in cmake, fix warning (gazebosim#328)
f5d369a 
* Also use python3 in test

Signed-off-by: Steve Peters <scpeters@openrobotics.org>
scpeters added a commit to scpeters/sdformat that referenced this pull request Aug 6, 2020
@scpeters
Changelog for gazebosim#328
7368373 
Signed-off-by: Steve Peters <scpeters@openrobotics.org>
scpeters added a commit that referenced this pull request Aug 7, 2020
@scpeters
Find python3 in cmake, fix warning (#328)
de8b1f5 
* Also use python3 in test

Signed-off-by: Steve Peters <scpeters@openrobotics.org>
scpeters added a commit that referenced this pull request Aug 7, 2020
@scpeters
Changelog for #328
39aad2b 
Signed-off-by: Steve Peters <scpeters@openrobotics.org>
scpeters added a commit to scpeters/sdformat that referenced this pull request Aug 7, 2020
@scpeters
Find python3 in cmake, fix warning (gazebosim#328)
166186c 
* Also use python3 in test

Signed-off-by: Steve Peters <scpeters@openrobotics.org>
scpeters added a commit to scpeters/sdformat that referenced this pull request Aug 7, 2020
@scpeters
Changelog for gazebosim#328
42991eb 
Signed-off-by: Steve Peters <scpeters@openrobotics.org>
scpeters added a commit that referenced this pull request Aug 7, 2020
@scpeters
Find python3 in cmake, fix warning (#328)
3f66fbc 
* Also use python3 in test

Signed-off-by: Steve Peters <scpeters@openrobotics.org>
scpeters added a commit that referenced this pull request Aug 7, 2020
@scpeters
Changelog for #328
ecd491f 
Signed-off-by: Steve Peters <scpeters@openrobotics.org>
@scpeters scpeters mentioned this pull request Sep 3, 2020
Merged
scpeters added a commit to scpeters/sdformat that referenced this pull request Sep 3, 2020
@scpeters
Find python3 in cmake, fix warning (gazebosim#328)
4b04268 
* Also use python3 in test

Signed-off-by: Steve Peters <scpeters@openrobotics.org>
@scpeters scpeters mentioned this pull request Sep 3, 2020
Merged
chapulina pushed a commit that referenced this pull request Sep 3, 2020
@scpeters @chapulina
Find python3 in cmake, fix warning (#328)
fb50d22 
* Also use python3 in test

Signed-off-by: Steve Peters <scpeters@openrobotics.org>
traversaro pushed a commit to traversaro/sdformat that referenced this pull request Sep 5, 2020
@scpeters @traversaro
Find python3 in cmake, fix warning (gazebosim#328)
83a39da 
* Also use python3 in test

Signed-off-by: Steve Peters <scpeters@openrobotics.org>
traversaro pushed a commit to traversaro/sdformat that referenced this pull request Sep 5, 2020
@scpeters @traversaro
Changelog for gazebosim#328
e7114aa 
Signed-off-by: Steve Peters <scpeters@openrobotics.org>
scpeters added a commit to scpeters/sdformat that referenced this pull request Nov 22, 2021
@scpeters
Find python3 in cmake, fix warning (gazebosim#328)
35db6e9 
* Also use python3 in test

Signed-off-by: Steve Peters <scpeters@openrobotics.org>
@scpeters scpeters mentioned this pull request Nov 25, 2021
Merged
7 tasks
scpeters added a commit that referenced this pull request Nov 29, 2021
@scpeters
Backport cmake/test fixes to sdf6 (#761)
0c6e7ad 
* Fix cmake warning about newlines
* Find python3 in cmake, fix warning (#328)

Signed-off-by: Steve Peters <scpeters@openrobotics.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@azeey azeey azeey approved these changes

@j-rivero j-rivero Awaiting requested review from j-rivero

+1 more reviewer

@chapulina chapulina chapulina approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@scpeters @mjcarroll @codecov-commenter @azeey @chapulina