Skip to content

DOC: clarify behavior of //model/model/static#713

Merged
azeey merged 4 commits intogazebosim:sdf11from
FirefoxMetzger:clarify-nested-static
Dec 10, 2021
Merged

DOC: clarify behavior of //model/model/static#713
azeey merged 4 commits intogazebosim:sdf11from
FirefoxMetzger:clarify-nested-static

Conversation

@FirefoxMetzger
Copy link
Copy Markdown
Contributor

Closes: #705

As per the title, this adds a sentence to the behavior of //model/static to avoid confusion on what might happen if it is used within a model that is itself included in another model.

It also adds some clarification to //model/@canonical_link, which was discussed in #705 .

Signed-off-by: FirefoxMetzger <sebastian@wallkoetter.net>
@github-actions github-actions bot added the 🏢 edifice Ignition Edifice label Sep 25, 2021
@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented Sep 25, 2021

Codecov Report

Merging #713 (c7c63d1) into sdf11 (a32ff42) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##            sdf11     #713   +/-   ##
=======================================
  Coverage   88.89%   88.89%           
=======================================
  Files          73       73           
  Lines       11072    11072           
=======================================
  Hits         9843     9843           
  Misses       1229     1229           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a32ff42...c7c63d1. Read the comment docs.

Signed-off-by: FirefoxMetzger <sebastian@wallkoetter.net>
@azeey azeey self-assigned this Nov 22, 2021
Addisu Z. Taddese added 2 commits December 9, 2021 15:13
@azeey azeey merged commit 24a2782 into gazebosim:sdf11 Dec 10, 2021
@osrf-triage
Copy link
Copy Markdown

This pull request has been mentioned on Gazebo Community. There might be relevant details there:

https://community.gazebosim.org/t/new-ignition-releases-2022-03-25-fortress-edifice-citadel/1343/1

scpeters added a commit that referenced this pull request Mar 29, 2022
These changes were applied to SDFormat 1.8 in #713
but were not propagated to 1.9 after being merged
forward. This completes the merge.

Signed-off-by: Steve Peters <scpeters@openrobotics.org>
scpeters added a commit that referenced this pull request Mar 31, 2022
These changes were applied to SDFormat 1.8 in #713
but were not propagated to 1.9 after being merged
forward. This completes the merge.

Signed-off-by: Steve Peters <scpeters@openrobotics.org>
@osrf-triage
Copy link
Copy Markdown

This pull request has been mentioned on Gazebo Community. There might be relevant details there:

https://community.gazebosim.org/t/new-ignition-releases-2022-04-13-fortress-edifice/1367/1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

🏢 edifice Ignition Edifice

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Clarify the behavior of //model/model/@static

6 participants