Skip to content

DOC 1.9: clarify behavior of //model/model/static#921

Merged
scpeters merged 2 commits intosdf12from
clarify-nested-static-1.9
Mar 31, 2022
Merged

DOC 1.9: clarify behavior of //model/model/static#921
scpeters merged 2 commits intosdf12from
clarify-nested-static-1.9

Conversation

@scpeters
Copy link
Copy Markdown
Member

🦟 Bug fix

Fixes an incomplete forward port of #713.

Summary

These changes were applied to SDFormat 1.8 in #713 but were not propagated to 1.9 after being merged forward. This completes the merge.

Checklist

  • Signed all commits for DCO
  • Added tests
  • Updated documentation (as needed)
  • Updated migration guide (as needed)
  • codecheck passed (See contributing)
  • All tests passed (See test coverage)
  • While waiting for a review on your PR, please help review another open pull request to support the maintainers

Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining Signed-off-by messages.

These changes were applied to SDFormat 1.8 in #713
but were not propagated to 1.9 after being merged
forward. This completes the merge.

Signed-off-by: Steve Peters <scpeters@openrobotics.org>
@scpeters scpeters requested a review from azeey as a code owner March 29, 2022 23:42
@github-actions github-actions bot added the 🏯 fortress Ignition Fortress label Mar 29, 2022
@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented Mar 30, 2022

Codecov Report

Merging #921 (881ce65) into sdf12 (4d9f8a4) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##            sdf12     #921   +/-   ##
=======================================
  Coverage   87.95%   87.95%           
=======================================
  Files         101      101           
  Lines       14756    14756           
=======================================
  Hits        12979    12979           
  Misses       1777     1777           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4d9f8a4...881ce65. Read the comment docs.

@scpeters scpeters merged commit 6ecfcc2 into sdf12 Mar 31, 2022
@scpeters scpeters deleted the clarify-nested-static-1.9 branch March 31, 2022 05:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

🏯 fortress Ignition Fortress

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants