Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.

Adds set text action for voice access#24734

Merged
fluttergithubbot merged 5 commits into
flutter-team-archive:masterfrom
chunhtai:issues/76827-type
Mar 5, 2021
Merged

Adds set text action for voice access#24734
fluttergithubbot merged 5 commits into
flutter-team-archive:masterfrom
chunhtai:issues/76827-type

Conversation

@chunhtai

@chunhtai chunhtai commented Mar 2, 2021 •
edited
Loading

Copy link
Copy Markdown
Contributor

voice access uses set text action to type user spoken sentences. This PR adds support for it.

framework pr: flutter/flutter#77024

flutter/flutter#77271

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read and followed the Flutter Style Guide and the C++, Objective-C, Java style guides.
  • I listed at least one issue that this PR fixes in the description above.
  • I added new tests to check the change I am making or feature I am adding, or Hixie said the PR is test-exempt. See testing the engine for instructions on
    writing and running engine tests.
  • I updated/added relevant documentation (doc comments with ///).
  • I signed the CLA.
  • All existing and new tests are passing.
  • The reviewer has submitted any presubmit flakes in this PR using the engine presubmit flakes form before re-triggering the failure.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

@chunhtai chunhtai requested a review from justinmc March 2, 2021 19:39
@chunhtai chunhtai mentioned this pull request Mar 3, 2021
Closed
3 tasks
justinmc
justinmc approved these changes Mar 3, 2021
View reviewed changes

@justinmc justinmc left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. It's cool that we'll be able to support this.

Comment thread shell/platform/android/io/flutter/view/AccessibilityBridge.java Outdated
Comment on lines +1061 to +1064
// Set text APIs aren't available until API 21. We can't handle the case here so
// return false
// instead. It's extremely unlikely that this case would ever be triggered in the first
// place in API < 21.

@justinmc justinmc Mar 3, 2021

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nit: Some strange line break locations here I think.

@chunhtai chunhtai mentioned this pull request Mar 4, 2021
Merged
8 tasks
@chinmaygarde

chinmaygarde commented Mar 4, 2021

Copy link
Copy Markdown
Contributor

The presubmit failure looks like a flake. I have filed a flake report and re-run the test.

@chunhtai

chunhtai commented Mar 4, 2021

Copy link
Copy Markdown
Contributor Author

@chinmaygarde the failure is expected, it needs flutter/flutter#77295

@chunhtai chunhtai mentioned this pull request Mar 5, 2021
Merged
8 tasks
@chunhtai chunhtai added the waiting for tree to go green This PR is approved and tested, but waiting for the tree to be green to land. label Mar 5, 2021
@fluttergithubbot fluttergithubbot merged commit 9a6734c into flutter-team-archive:master Mar 5, 2021
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Mar 5, 2021
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Mar 5, 2021
@engine-flutter-autoroll
9a6734c Adds set text action for voice access (flutter-team-archive/e…
01c4c80 
…ngine#24734)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Mar 5, 2021
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Mar 5, 2021
@engine-flutter-autoroll
9a6734c Adds set text action for voice access (flutter-team-archive/e…
871cc79 
…ngine#24734)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Mar 5, 2021
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Mar 5, 2021
@engine-flutter-autoroll
9a6734c Adds set text action for voice access (flutter-team-archive/e…
1a81f9c 
…ngine#24734)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Mar 5, 2021
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Mar 5, 2021
@engine-flutter-autoroll
9a6734c Adds set text action for voice access (flutter-team-archive/e…
348dbe4 
…ngine#24734)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Mar 5, 2021
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Mar 5, 2021
@engine-flutter-autoroll
9a6734c Adds set text action for voice access (flutter-team-archive/e…
a8a2cb8 
…ngine#24734)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Mar 5, 2021
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Mar 5, 2021
@engine-flutter-autoroll
9a6734c Adds set text action for voice access (flutter-team-archive/e…
f165ec3 
…ngine#24734)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Mar 5, 2021
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Mar 5, 2021
@engine-flutter-autoroll
9a6734c Adds set text action for voice access (flutter-team-archive/e…
eb921ae 
…ngine#24734)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Mar 5, 2021
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Mar 5, 2021
@engine-flutter-autoroll
9a6734c Adds set text action for voice access (flutter-team-archive/e…
7cf2e40 
…ngine#24734)
@cbracken cbracken mentioned this pull request Mar 5, 2021
Merged
cbracken added a commit to cbracken/flutter that referenced this pull request Mar 5, 2021
@cbracken
Roll Engine from 299eb3e to 67abe7f (13 revisions)
aba0c3c 
This is a manual roll since it requires adding a new SemanticsAction to
an element in the flutter_test SemanticsAction matchers test which was
added as part of flutter-team-archive/engine#24734.

flutter-team-archive/engine@299eb3e...67abe7f

2021-03-05 skia-flutter-autoroll@skia.org Roll Skia from 994a571fc79a to 532138cea7ea (4 revisions) (flutter-team-archive/engine#24812)
2021-03-05 skia-flutter-autoroll@skia.org Roll Dart SDK from b321d01eec78 to 4693d6d4f88e (1 revision) (flutter-team-archive/engine#24811)
2021-03-05 skia-flutter-autoroll@skia.org Roll Dart SDK from 835da00aa6b5 to b321d01eec78 (1 revision) (flutter-team-archive/engine#24808)
2021-03-05 skia-flutter-autoroll@skia.org Roll Skia from d42fe062d0a7 to 994a571fc79a (1 revision) (flutter-team-archive/engine#24806)
2021-03-05 skia-flutter-autoroll@skia.org Roll Skia from 3b58d38966f4 to d42fe062d0a7 (2 revisions) (flutter-team-archive/engine#24805)
2021-03-05 skia-flutter-autoroll@skia.org Roll Skia from 6ba242d2a201 to 3b58d38966f4 (1 revision) (flutter-team-archive/engine#24804)
2021-03-05 skia-flutter-autoroll@skia.org Roll Dart SDK from 1b674d73af53 to 835da00aa6b5 (1 revision) (flutter-team-archive/engine#24803)
2021-03-05 chris@bracken.jp Update cppwinrt to build 2.0.210304.5 (flutter-team-archive/engine#24801)
2021-03-05 skia-flutter-autoroll@skia.org Roll Skia from 55aaefe687c7 to 6ba242d2a201 (18 revisions) (flutter-team-archive/engine#24799)
2021-03-05 47866232+chunhtai@users.noreply.github.com Adds set text action for voice access (flutter-team-archive/engine#24734)
2021-03-04 jason-simmons@users.noreply.github.com SkParagraph: support multiple default font families (flutter-team-archive/engine#24662)
2021-03-04 skia-flutter-autoroll@skia.org Roll Clang Mac from MQQ43_LGr... to MRLGJYv8V... (flutter-team-archive/engine#24794)
2021-03-04 jason-simmons@users.noreply.github.com Allow calls to legacyMakeTypeface in the AssetFontManager (flutter-team-archive/engine#24612)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC cbracken@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md
cbracken added a commit to flutter/flutter that referenced this pull request Mar 5, 2021
@cbracken
Roll Engine from 299eb3e to 67abe7f (13 revisions) (#77386)
565e487 
This is a manual roll since it requires adding a new SemanticsAction to
an element in the flutter_test SemanticsAction matchers test which was
added as part of flutter-team-archive/engine#24734.

flutter-team-archive/engine@299eb3e...67abe7f

2021-03-05 skia-flutter-autoroll@skia.org Roll Skia from 994a571fc79a to 532138cea7ea (4 revisions) (flutter-team-archive/engine#24812)
2021-03-05 skia-flutter-autoroll@skia.org Roll Dart SDK from b321d01eec78 to 4693d6d4f88e (1 revision) (flutter-team-archive/engine#24811)
2021-03-05 skia-flutter-autoroll@skia.org Roll Dart SDK from 835da00aa6b5 to b321d01eec78 (1 revision) (flutter-team-archive/engine#24808)
2021-03-05 skia-flutter-autoroll@skia.org Roll Skia from d42fe062d0a7 to 994a571fc79a (1 revision) (flutter-team-archive/engine#24806)
2021-03-05 skia-flutter-autoroll@skia.org Roll Skia from 3b58d38966f4 to d42fe062d0a7 (2 revisions) (flutter-team-archive/engine#24805)
2021-03-05 skia-flutter-autoroll@skia.org Roll Skia from 6ba242d2a201 to 3b58d38966f4 (1 revision) (flutter-team-archive/engine#24804)
2021-03-05 skia-flutter-autoroll@skia.org Roll Dart SDK from 1b674d73af53 to 835da00aa6b5 (1 revision) (flutter-team-archive/engine#24803)
2021-03-05 chris@bracken.jp Update cppwinrt to build 2.0.210304.5 (flutter-team-archive/engine#24801)
2021-03-05 skia-flutter-autoroll@skia.org Roll Skia from 55aaefe687c7 to 6ba242d2a201 (18 revisions) (flutter-team-archive/engine#24799)
2021-03-05 47866232+chunhtai@users.noreply.github.com Adds set text action for voice access (flutter-team-archive/engine#24734)
2021-03-04 jason-simmons@users.noreply.github.com SkParagraph: support multiple default font families (flutter-team-archive/engine#24662)
2021-03-04 skia-flutter-autoroll@skia.org Roll Clang Mac from MQQ43_LGr... to MRLGJYv8V... (flutter-team-archive/engine#24794)
2021-03-04 jason-simmons@users.noreply.github.com Allow calls to legacyMakeTypeface in the AssetFontManager (flutter-team-archive/engine#24612)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC cbracken@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md
hjfreyer pushed a commit to hjfreyer/engine that referenced this pull request Mar 22, 2021
@chunhtai @hjfreyer
Adds set text action for voice access (flutter-team-archive#24734)
53e2b2e
chriscraws pushed a commit to chriscraws/engine that referenced this pull request Mar 23, 2021
@chunhtai @chriscraws
Adds set text action for voice access (flutter-team-archive#24734)
75c55db
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

1 more reviewer
@justinmc justinmc justinmc approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

cla: yes platform-android waiting for tree to go green This PR is approved and tested, but waiting for the tree to be green to land.

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@chunhtai @chinmaygarde @justinmc @googlebot @fluttergithubbot