Skip to content

disable semantics test for adding Set Text action in engine#77295

Merged
fluttergithubbot merged 1 commit into
flutter:masterfrom
chunhtai:issues/77271
Mar 4, 2021
Merged

disable semantics test for adding Set Text action in engine#77295
fluttergithubbot merged 1 commit into
flutter:masterfrom
chunhtai:issues/77271

Conversation

@chunhtai

@chunhtai chunhtai commented Mar 4, 2021

Copy link
Copy Markdown
Contributor

engine pr flutter-team-archive/engine#24734

related issue: #77271

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read and followed the Flutter Style Guide, including Features we expect every widget to implement.
  • I signed the CLA.
  • I listed at least one issue that this PR fixes in the description above.
  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making or feature I am adding, or Hixie said the PR is test-exempt.
  • All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

@flutter-dashboard flutter-dashboard Bot added a: accessibility Accessibility, e.g. VoiceOver or TalkBack. (aka a11y) framework flutter/packages/flutter repository. See also f: labels. labels Mar 4, 2021
@google-cla google-cla Bot added the cla: yes label Mar 4, 2021
@chunhtai chunhtai requested a review from justinmc March 4, 2021 21:59
@chunhtai chunhtai mentioned this pull request Mar 4, 2021
Merged
9 tasks
justinmc
justinmc approved these changes Mar 4, 2021
View reviewed changes

@justinmc justinmc left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@fluttergithubbot fluttergithubbot merged commit 9d53c11 into flutter:master Mar 4, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@justinmc justinmc justinmc approved these changes

Assignees

No one assigned

Labels

a: accessibility Accessibility, e.g. VoiceOver or TalkBack. (aka a11y) framework flutter/packages/flutter repository. See also f: labels.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@chunhtai @justinmc @fluttergithubbot