Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.

SkParagraph: support multiple default font families#24662

Merged
fluttergithubbot merged 1 commit into
flutter-team-archive:masterfrom
jason-simmons:skp_multi_default_family
Mar 4, 2021
Merged

SkParagraph: support multiple default font families#24662
fluttergithubbot merged 1 commit into
flutter-team-archive:masterfrom
jason-simmons:skp_multi_default_family

Conversation

@jason-simmons

@jason-simmons jason-simmons commented Feb 26, 2021

Copy link
Copy Markdown
Contributor

No description provided.

@flutter-dashboard

flutter-dashboard Bot commented Feb 26, 2021

Copy link
Copy Markdown

It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact Hixie on the #hackers channel in Chat.

If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix?

Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing.

@google-cla google-cla Bot added the cla: yes label Feb 26, 2021
@chinmaygarde chinmaygarde added the waiting for tree to go green This PR is approved and tested, but waiting for the tree to be green to land. label Mar 4, 2021
@chinmaygarde

chinmaygarde commented Mar 4, 2021

Copy link
Copy Markdown
Contributor

A flake report was filed and I re-ran the presubmit.

@fluttergithubbot fluttergithubbot merged commit e06dbeb into flutter-team-archive:master Mar 4, 2021
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Mar 5, 2021
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Mar 5, 2021
@engine-flutter-autoroll
e06dbeb SkParagraph: support multiple default font families (flutter-…
f8ec60a 
…team-archive/engine#24662)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Mar 5, 2021
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Mar 5, 2021
@engine-flutter-autoroll
e06dbeb SkParagraph: support multiple default font families (flutter-…
969f19a 
…team-archive/engine#24662)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Mar 5, 2021
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Mar 5, 2021
@engine-flutter-autoroll
e06dbeb SkParagraph: support multiple default font families (flutter-…
0c192f8 
…team-archive/engine#24662)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Mar 5, 2021
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Mar 5, 2021
@engine-flutter-autoroll
e06dbeb SkParagraph: support multiple default font families (flutter-…
9b7a290 
…team-archive/engine#24662)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Mar 5, 2021
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Mar 5, 2021
@engine-flutter-autoroll
e06dbeb SkParagraph: support multiple default font families (flutter-…
3eadbae 
…team-archive/engine#24662)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Mar 5, 2021
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Mar 5, 2021
@engine-flutter-autoroll
e06dbeb SkParagraph: support multiple default font families (flutter-…
efc17dd 
…team-archive/engine#24662)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Mar 5, 2021
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Mar 5, 2021
@engine-flutter-autoroll
e06dbeb SkParagraph: support multiple default font families (flutter-…
30f5155 
…team-archive/engine#24662)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Mar 5, 2021
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Mar 5, 2021
@engine-flutter-autoroll
e06dbeb SkParagraph: support multiple default font families (flutter-…
511ffb6 
…team-archive/engine#24662)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Mar 5, 2021
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Mar 5, 2021
@engine-flutter-autoroll
e06dbeb SkParagraph: support multiple default font families (flutter-…
7b7ea75 
…team-archive/engine#24662)
@cbracken cbracken mentioned this pull request Mar 5, 2021
Merged
cbracken added a commit to cbracken/flutter that referenced this pull request Mar 5, 2021
@cbracken
Roll Engine from 299eb3e to 67abe7f (13 revisions)
aba0c3c 
This is a manual roll since it requires adding a new SemanticsAction to
an element in the flutter_test SemanticsAction matchers test which was
added as part of flutter-team-archive/engine#24734.

flutter-team-archive/engine@299eb3e...67abe7f

2021-03-05 skia-flutter-autoroll@skia.org Roll Skia from 994a571fc79a to 532138cea7ea (4 revisions) (flutter-team-archive/engine#24812)
2021-03-05 skia-flutter-autoroll@skia.org Roll Dart SDK from b321d01eec78 to 4693d6d4f88e (1 revision) (flutter-team-archive/engine#24811)
2021-03-05 skia-flutter-autoroll@skia.org Roll Dart SDK from 835da00aa6b5 to b321d01eec78 (1 revision) (flutter-team-archive/engine#24808)
2021-03-05 skia-flutter-autoroll@skia.org Roll Skia from d42fe062d0a7 to 994a571fc79a (1 revision) (flutter-team-archive/engine#24806)
2021-03-05 skia-flutter-autoroll@skia.org Roll Skia from 3b58d38966f4 to d42fe062d0a7 (2 revisions) (flutter-team-archive/engine#24805)
2021-03-05 skia-flutter-autoroll@skia.org Roll Skia from 6ba242d2a201 to 3b58d38966f4 (1 revision) (flutter-team-archive/engine#24804)
2021-03-05 skia-flutter-autoroll@skia.org Roll Dart SDK from 1b674d73af53 to 835da00aa6b5 (1 revision) (flutter-team-archive/engine#24803)
2021-03-05 chris@bracken.jp Update cppwinrt to build 2.0.210304.5 (flutter-team-archive/engine#24801)
2021-03-05 skia-flutter-autoroll@skia.org Roll Skia from 55aaefe687c7 to 6ba242d2a201 (18 revisions) (flutter-team-archive/engine#24799)
2021-03-05 47866232+chunhtai@users.noreply.github.com Adds set text action for voice access (flutter-team-archive/engine#24734)
2021-03-04 jason-simmons@users.noreply.github.com SkParagraph: support multiple default font families (flutter-team-archive/engine#24662)
2021-03-04 skia-flutter-autoroll@skia.org Roll Clang Mac from MQQ43_LGr... to MRLGJYv8V... (flutter-team-archive/engine#24794)
2021-03-04 jason-simmons@users.noreply.github.com Allow calls to legacyMakeTypeface in the AssetFontManager (flutter-team-archive/engine#24612)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC cbracken@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md
cbracken added a commit to flutter/flutter that referenced this pull request Mar 5, 2021
@cbracken
Roll Engine from 299eb3e to 67abe7f (13 revisions) (#77386)
565e487 
This is a manual roll since it requires adding a new SemanticsAction to
an element in the flutter_test SemanticsAction matchers test which was
added as part of flutter-team-archive/engine#24734.

flutter-team-archive/engine@299eb3e...67abe7f

2021-03-05 skia-flutter-autoroll@skia.org Roll Skia from 994a571fc79a to 532138cea7ea (4 revisions) (flutter-team-archive/engine#24812)
2021-03-05 skia-flutter-autoroll@skia.org Roll Dart SDK from b321d01eec78 to 4693d6d4f88e (1 revision) (flutter-team-archive/engine#24811)
2021-03-05 skia-flutter-autoroll@skia.org Roll Dart SDK from 835da00aa6b5 to b321d01eec78 (1 revision) (flutter-team-archive/engine#24808)
2021-03-05 skia-flutter-autoroll@skia.org Roll Skia from d42fe062d0a7 to 994a571fc79a (1 revision) (flutter-team-archive/engine#24806)
2021-03-05 skia-flutter-autoroll@skia.org Roll Skia from 3b58d38966f4 to d42fe062d0a7 (2 revisions) (flutter-team-archive/engine#24805)
2021-03-05 skia-flutter-autoroll@skia.org Roll Skia from 6ba242d2a201 to 3b58d38966f4 (1 revision) (flutter-team-archive/engine#24804)
2021-03-05 skia-flutter-autoroll@skia.org Roll Dart SDK from 1b674d73af53 to 835da00aa6b5 (1 revision) (flutter-team-archive/engine#24803)
2021-03-05 chris@bracken.jp Update cppwinrt to build 2.0.210304.5 (flutter-team-archive/engine#24801)
2021-03-05 skia-flutter-autoroll@skia.org Roll Skia from 55aaefe687c7 to 6ba242d2a201 (18 revisions) (flutter-team-archive/engine#24799)
2021-03-05 47866232+chunhtai@users.noreply.github.com Adds set text action for voice access (flutter-team-archive/engine#24734)
2021-03-04 jason-simmons@users.noreply.github.com SkParagraph: support multiple default font families (flutter-team-archive/engine#24662)
2021-03-04 skia-flutter-autoroll@skia.org Roll Clang Mac from MQQ43_LGr... to MRLGJYv8V... (flutter-team-archive/engine#24794)
2021-03-04 jason-simmons@users.noreply.github.com Allow calls to legacyMakeTypeface in the AssetFontManager (flutter-team-archive/engine#24612)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC cbracken@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md
hjfreyer pushed a commit to hjfreyer/engine that referenced this pull request Mar 22, 2021
@jason-simmons @hjfreyer
SkParagraph: support multiple default font families (flutter-team-arc…
11596ba 
…hive#24662)
chriscraws pushed a commit to chriscraws/engine that referenced this pull request Mar 23, 2021
@jason-simmons @chriscraws
SkParagraph: support multiple default font families (flutter-team-arc…
fb41505 
…hive#24662)
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@GaryQian GaryQian Awaiting requested review from GaryQian
1 more reviewer
@chinmaygarde chinmaygarde chinmaygarde approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

cla: yes waiting for tree to go green This PR is approved and tested, but waiting for the tree to be green to land.

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@jason-simmons @chinmaygarde @fluttergithubbot