Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.

Update cppwinrt to build 2.0.210304.5#24801

Merged
cbracken merged 1 commit into
flutter-team-archive:masterfrom
cbracken:update-cppwinrt
Mar 5, 2021
Merged

Update cppwinrt to build 2.0.210304.5#24801
cbracken merged 1 commit into
flutter-team-archive:masterfrom
cbracken:update-cppwinrt

Conversation

@cbracken

@cbracken cbracken commented Mar 5, 2021

Copy link
Copy Markdown
Contributor

This fixes an issue in CppWinRT related to std::terminate(); the tool
now uses abort() instead.

CppWinRT patch: microsoft/cppwinrt#868

This also fixes a couple bugs in the README.md:

  • Uses tmp as the temp dir into which we unpack the nupkg archive rather
    than cppwinrt to avoid confusion with the containing directory, which is
    named cppwinrt.
  • Fixes a typo around the directory from which the cipd command should
    be executed.

No new tests added since this just updates a dependency.

Bug: flutter/flutter#70205

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read and followed the Flutter Style Guide and the C++, Objective-C, Java style guides.
  • I listed at least one issue that this PR fixes in the description above.
  • I added new tests to check the change I am making or feature I am adding, or Hixie said the PR is test-exempt. See testing the engine for instructions on
    writing and running engine tests.
  • I updated/added relevant documentation (doc comments with ///).
  • I signed the CLA.
  • All existing and new tests are passing.
  • The reviewer has submitted any presubmit flakes in this PR using the engine presubmit flakes form before re-triggering the failure.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

@cbracken
Update cppwinrt to build 2.0.210304.5
fac8b2f 
This fixes an issue in CppWinRT related to std::terminate(); the tool
now uses abort() instead.

CppWinRT patch: microsoft/cppwinrt#868

This also fixes a couple bugs in the README.md:
* Uses tmp as the temp dir into which we unpack the nupkg archive rather
  than cppwinrt to avoid confusion with the containing directory, which is
  named cppwinrt.
* Fixes a typo around the directory from which the cipd command should
  be executed.
@cbracken cbracken merged commit 2b3a194 into flutter-team-archive:master Mar 5, 2021
@cbracken cbracken deleted the update-cppwinrt branch March 5, 2021 02:21
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Mar 5, 2021
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Mar 5, 2021
@engine-flutter-autoroll
2b3a194 Update cppwinrt to build 2.0.210304.5 (flutter-team-archive/e…
d720dc5 
…ngine#24801)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Mar 5, 2021
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Mar 5, 2021
@engine-flutter-autoroll
2b3a194 Update cppwinrt to build 2.0.210304.5 (flutter-team-archive/e…
26631d2 
…ngine#24801)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Mar 5, 2021
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Mar 5, 2021
@engine-flutter-autoroll
2b3a194 Update cppwinrt to build 2.0.210304.5 (flutter-team-archive/e…
b5bd81f 
…ngine#24801)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Mar 5, 2021
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Mar 5, 2021
@engine-flutter-autoroll
2b3a194 Update cppwinrt to build 2.0.210304.5 (flutter-team-archive/e…
56c9ed2 
…ngine#24801)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Mar 5, 2021
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Mar 5, 2021
@engine-flutter-autoroll
2b3a194 Update cppwinrt to build 2.0.210304.5 (flutter-team-archive/e…
87a36dc 
…ngine#24801)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Mar 5, 2021
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Mar 5, 2021
@engine-flutter-autoroll
2b3a194 Update cppwinrt to build 2.0.210304.5 (flutter-team-archive/e…
a4e8cea 
…ngine#24801)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Mar 5, 2021
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Mar 5, 2021
@engine-flutter-autoroll
2b3a194 Update cppwinrt to build 2.0.210304.5 (flutter-team-archive/e…
799f993 
…ngine#24801)
@cbracken cbracken mentioned this pull request Mar 5, 2021
Merged
cbracken added a commit to cbracken/flutter that referenced this pull request Mar 5, 2021
@cbracken
Roll Engine from 299eb3e to 67abe7f (13 revisions)
aba0c3c 
This is a manual roll since it requires adding a new SemanticsAction to
an element in the flutter_test SemanticsAction matchers test which was
added as part of flutter-team-archive/engine#24734.

flutter-team-archive/engine@299eb3e...67abe7f

2021-03-05 skia-flutter-autoroll@skia.org Roll Skia from 994a571fc79a to 532138cea7ea (4 revisions) (flutter-team-archive/engine#24812)
2021-03-05 skia-flutter-autoroll@skia.org Roll Dart SDK from b321d01eec78 to 4693d6d4f88e (1 revision) (flutter-team-archive/engine#24811)
2021-03-05 skia-flutter-autoroll@skia.org Roll Dart SDK from 835da00aa6b5 to b321d01eec78 (1 revision) (flutter-team-archive/engine#24808)
2021-03-05 skia-flutter-autoroll@skia.org Roll Skia from d42fe062d0a7 to 994a571fc79a (1 revision) (flutter-team-archive/engine#24806)
2021-03-05 skia-flutter-autoroll@skia.org Roll Skia from 3b58d38966f4 to d42fe062d0a7 (2 revisions) (flutter-team-archive/engine#24805)
2021-03-05 skia-flutter-autoroll@skia.org Roll Skia from 6ba242d2a201 to 3b58d38966f4 (1 revision) (flutter-team-archive/engine#24804)
2021-03-05 skia-flutter-autoroll@skia.org Roll Dart SDK from 1b674d73af53 to 835da00aa6b5 (1 revision) (flutter-team-archive/engine#24803)
2021-03-05 chris@bracken.jp Update cppwinrt to build 2.0.210304.5 (flutter-team-archive/engine#24801)
2021-03-05 skia-flutter-autoroll@skia.org Roll Skia from 55aaefe687c7 to 6ba242d2a201 (18 revisions) (flutter-team-archive/engine#24799)
2021-03-05 47866232+chunhtai@users.noreply.github.com Adds set text action for voice access (flutter-team-archive/engine#24734)
2021-03-04 jason-simmons@users.noreply.github.com SkParagraph: support multiple default font families (flutter-team-archive/engine#24662)
2021-03-04 skia-flutter-autoroll@skia.org Roll Clang Mac from MQQ43_LGr... to MRLGJYv8V... (flutter-team-archive/engine#24794)
2021-03-04 jason-simmons@users.noreply.github.com Allow calls to legacyMakeTypeface in the AssetFontManager (flutter-team-archive/engine#24612)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC cbracken@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md
cbracken added a commit to flutter/flutter that referenced this pull request Mar 5, 2021
@cbracken
Roll Engine from 299eb3e to 67abe7f (13 revisions) (#77386)
565e487 
This is a manual roll since it requires adding a new SemanticsAction to
an element in the flutter_test SemanticsAction matchers test which was
added as part of flutter-team-archive/engine#24734.

flutter-team-archive/engine@299eb3e...67abe7f

2021-03-05 skia-flutter-autoroll@skia.org Roll Skia from 994a571fc79a to 532138cea7ea (4 revisions) (flutter-team-archive/engine#24812)
2021-03-05 skia-flutter-autoroll@skia.org Roll Dart SDK from b321d01eec78 to 4693d6d4f88e (1 revision) (flutter-team-archive/engine#24811)
2021-03-05 skia-flutter-autoroll@skia.org Roll Dart SDK from 835da00aa6b5 to b321d01eec78 (1 revision) (flutter-team-archive/engine#24808)
2021-03-05 skia-flutter-autoroll@skia.org Roll Skia from d42fe062d0a7 to 994a571fc79a (1 revision) (flutter-team-archive/engine#24806)
2021-03-05 skia-flutter-autoroll@skia.org Roll Skia from 3b58d38966f4 to d42fe062d0a7 (2 revisions) (flutter-team-archive/engine#24805)
2021-03-05 skia-flutter-autoroll@skia.org Roll Skia from 6ba242d2a201 to 3b58d38966f4 (1 revision) (flutter-team-archive/engine#24804)
2021-03-05 skia-flutter-autoroll@skia.org Roll Dart SDK from 1b674d73af53 to 835da00aa6b5 (1 revision) (flutter-team-archive/engine#24803)
2021-03-05 chris@bracken.jp Update cppwinrt to build 2.0.210304.5 (flutter-team-archive/engine#24801)
2021-03-05 skia-flutter-autoroll@skia.org Roll Skia from 55aaefe687c7 to 6ba242d2a201 (18 revisions) (flutter-team-archive/engine#24799)
2021-03-05 47866232+chunhtai@users.noreply.github.com Adds set text action for voice access (flutter-team-archive/engine#24734)
2021-03-04 jason-simmons@users.noreply.github.com SkParagraph: support multiple default font families (flutter-team-archive/engine#24662)
2021-03-04 skia-flutter-autoroll@skia.org Roll Clang Mac from MQQ43_LGr... to MRLGJYv8V... (flutter-team-archive/engine#24794)
2021-03-04 jason-simmons@users.noreply.github.com Allow calls to legacyMakeTypeface in the AssetFontManager (flutter-team-archive/engine#24612)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC cbracken@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md
hjfreyer pushed a commit to hjfreyer/engine that referenced this pull request Mar 22, 2021
@cbracken @hjfreyer
Update cppwinrt to build 2.0.210304.5 (flutter-team-archive#24801)
ecb93f0 
This fixes an issue in CppWinRT related to std::terminate(); the tool
now uses abort() instead.

CppWinRT patch: microsoft/cppwinrt#868

This also fixes a couple bugs in the README.md:
* Uses tmp as the temp dir into which we unpack the nupkg archive rather
  than cppwinrt to avoid confusion with the containing directory, which is
  named cppwinrt.
* Fixes a typo around the directory from which the cipd command should
  be executed.
chriscraws pushed a commit to chriscraws/engine that referenced this pull request Mar 23, 2021
@cbracken @chriscraws
Update cppwinrt to build 2.0.210304.5 (flutter-team-archive#24801)
ead6716 
This fixes an issue in CppWinRT related to std::terminate(); the tool
now uses abort() instead.

CppWinRT patch: microsoft/cppwinrt#868

This also fixes a couple bugs in the README.md:
* Uses tmp as the temp dir into which we unpack the nupkg archive rather
  than cppwinrt to avoid confusion with the containing directory, which is
  named cppwinrt.
* Fixes a typo around the directory from which the cipd command should
  be executed.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@clarkezone clarkezone Awaiting requested review from clarkezone
1 more reviewer
@jason-simmons jason-simmons jason-simmons approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

affects: desktop cla: yes platform-windows

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@cbracken @jason-simmons @googlebot