Skip to content

Roll Engine from 299eb3e710c1 to 67abe7f9a9e4 (13 revisions)#77386

Merged
cbracken merged 1 commit into
flutter:masterfrom
cbracken:manual-roll
Mar 5, 2021
Merged

Roll Engine from 299eb3e710c1 to 67abe7f9a9e4 (13 revisions)#77386
cbracken merged 1 commit into
flutter:masterfrom
cbracken:manual-roll

Conversation

@cbracken

@cbracken cbracken commented Mar 5, 2021 •
edited
Loading

Copy link
Copy Markdown
Member

This is a manual roll since it requires adding a new SemanticsAction to
matcher in flutter_test for SemanticsAction.setText which was
added as part of flutter-team-archive/engine#24734.

flutter-team-archive/engine@299eb3e...67abe7f

2021-03-05 skia-flutter-autoroll@skia.org Roll Skia from 994a571fc79a to 532138cea7ea (4 revisions) (flutter-team-archive/engine#24812)
2021-03-05 skia-flutter-autoroll@skia.org Roll Dart SDK from b321d01eec78 to 4693d6d4f88e (1 revision) (flutter-team-archive/engine#24811)
2021-03-05 skia-flutter-autoroll@skia.org Roll Dart SDK from 835da00aa6b5 to b321d01eec78 (1 revision) (flutter-team-archive/engine#24808)
2021-03-05 skia-flutter-autoroll@skia.org Roll Skia from d42fe062d0a7 to 994a571fc79a (1 revision) (flutter-team-archive/engine#24806)
2021-03-05 skia-flutter-autoroll@skia.org Roll Skia from 3b58d38966f4 to d42fe062d0a7 (2 revisions) (flutter-team-archive/engine#24805)
2021-03-05 skia-flutter-autoroll@skia.org Roll Skia from 6ba242d2a201 to 3b58d38966f4 (1 revision) (flutter-team-archive/engine#24804)
2021-03-05 skia-flutter-autoroll@skia.org Roll Dart SDK from 1b674d73af53 to 835da00aa6b5 (1 revision) (flutter-team-archive/engine#24803)
2021-03-05 chris@bracken.jp Update cppwinrt to build 2.0.210304.5 (flutter-team-archive/engine#24801)
2021-03-05 skia-flutter-autoroll@skia.org Roll Skia from 55aaefe687c7 to 6ba242d2a201 (18 revisions) (flutter-team-archive/engine#24799)
2021-03-05 47866232+chunhtai@users.noreply.github.com Adds set text action for voice access (flutter-team-archive/engine#24734)
2021-03-04 jason-simmons@users.noreply.github.com SkParagraph: support multiple default font families (flutter-team-archive/engine#24662)
2021-03-04 skia-flutter-autoroll@skia.org Roll Clang Mac from MQQ43_LGr... to MRLGJYv8V... (flutter-team-archive/engine#24794)
2021-03-04 jason-simmons@users.noreply.github.com Allow calls to legacyMakeTypeface in the AssetFontManager (flutter-team-archive/engine#24612)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC cbracken@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

@cbracken
Roll Engine from 299eb3e to 67abe7f (13 revisions)
aba0c3c 
This is a manual roll since it requires adding a new SemanticsAction to
an element in the flutter_test SemanticsAction matchers test which was
added as part of flutter-team-archive/engine#24734.

flutter-team-archive/engine@299eb3e...67abe7f

2021-03-05 skia-flutter-autoroll@skia.org Roll Skia from 994a571fc79a to 532138cea7ea (4 revisions) (flutter-team-archive/engine#24812)
2021-03-05 skia-flutter-autoroll@skia.org Roll Dart SDK from b321d01eec78 to 4693d6d4f88e (1 revision) (flutter-team-archive/engine#24811)
2021-03-05 skia-flutter-autoroll@skia.org Roll Dart SDK from 835da00aa6b5 to b321d01eec78 (1 revision) (flutter-team-archive/engine#24808)
2021-03-05 skia-flutter-autoroll@skia.org Roll Skia from d42fe062d0a7 to 994a571fc79a (1 revision) (flutter-team-archive/engine#24806)
2021-03-05 skia-flutter-autoroll@skia.org Roll Skia from 3b58d38966f4 to d42fe062d0a7 (2 revisions) (flutter-team-archive/engine#24805)
2021-03-05 skia-flutter-autoroll@skia.org Roll Skia from 6ba242d2a201 to 3b58d38966f4 (1 revision) (flutter-team-archive/engine#24804)
2021-03-05 skia-flutter-autoroll@skia.org Roll Dart SDK from 1b674d73af53 to 835da00aa6b5 (1 revision) (flutter-team-archive/engine#24803)
2021-03-05 chris@bracken.jp Update cppwinrt to build 2.0.210304.5 (flutter-team-archive/engine#24801)
2021-03-05 skia-flutter-autoroll@skia.org Roll Skia from 55aaefe687c7 to 6ba242d2a201 (18 revisions) (flutter-team-archive/engine#24799)
2021-03-05 47866232+chunhtai@users.noreply.github.com Adds set text action for voice access (flutter-team-archive/engine#24734)
2021-03-04 jason-simmons@users.noreply.github.com SkParagraph: support multiple default font families (flutter-team-archive/engine#24662)
2021-03-04 skia-flutter-autoroll@skia.org Roll Clang Mac from MQQ43_LGr... to MRLGJYv8V... (flutter-team-archive/engine#24794)
2021-03-04 jason-simmons@users.noreply.github.com Allow calls to legacyMakeTypeface in the AssetFontManager (flutter-team-archive/engine#24612)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC cbracken@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md
@flutter-dashboard flutter-dashboard Bot added a: tests "flutter test", flutter_test, or one of our tests engine flutter/engine related. See also e: labels. framework flutter/packages/flutter repository. See also f: labels. labels Mar 5, 2021
@google-cla google-cla Bot added the cla: yes label Mar 5, 2021
@cbracken cbracken mentioned this pull request Mar 5, 2021
Closed
9 tasks
chunhtai
chunhtai approved these changes Mar 5, 2021
View reviewed changes

@chunhtai chunhtai left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, it is possible to add this to the engine presubmit? That way people can disable the test before adding new semantics action

@cbracken

cbracken commented Mar 5, 2021

Copy link
Copy Markdown
Member Author

The Google testing error is expected and will be resolved by this roll:

ERROR: third_party/dart/flutter_test/lib/src/matchers.dart

550: if (hasSetTextAction) SemanticsAction.setText, The getter 'setText' isn't defined for the type 'SemanticsAction'. #undefined_getter

(09:49:03) ERROR: third_party/dart/flutter_test/BUILD:20:13: Dart, ddc, compiling //third_party/dart/flutter_test:flutter_test failed: (Exit 1) ddk_flutter failed: error executing command blaze-out/host/bin/dart/build_defs/action/ddc/ddk_flutter @blaze-out/k8-fastbuild/bin/third_party/dart/flutter_test/lib/flutter_test.normal.js-0.params.  [forge_remote_host=ixql4]
google3:///third_party/dart/flutter_test/lib/src/matchers.dart:550:43: Error: Getter not found: 'setText'.
    if (hasSetTextAction) SemanticsAction.setText,
                                          ^^^^^^^

@cbracken cbracken merged commit 565e487 into flutter:master Mar 5, 2021
@cbracken cbracken deleted the manual-roll branch March 5, 2021 18:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jason-simmons jason-simmons jason-simmons approved these changes
@chunhtai chunhtai chunhtai approved these changes

Assignees

No one assigned

Labels

a: tests "flutter test", flutter_test, or one of our tests engine flutter/engine related. See also e: labels. framework flutter/packages/flutter repository. See also f: labels.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@cbracken @jason-simmons @chunhtai