Adds set text semantics action to render editable#77024
Conversation
There was a problem hiding this comment.
Nit: Could you remove this assert and make the value parameter's type non-nullable?
There was a problem hiding this comment.
The setter and getter need to match, dart won't let you make a non-nullable with nullable getter.
There was a problem hiding this comment.
This line is indented too far.
There was a problem hiding this comment.
Weird indentation here, and commas are missing.
There was a problem hiding this comment.
What does selection refer to here?
There was a problem hiding this comment.
if value is null, do we still need to addAction?
There was a problem hiding this comment.
(This looks also buggy in the setter above)
There was a problem hiding this comment.
Think a little bit more, I think not allowing null value makes more sense, it does not make sense for developer to assign action to semantics configuration in describeSemanticsConfigruation and later on remove it in the same method.
3b4ba51 to
428417d
Compare
There was a problem hiding this comment.
Can you use Object? instead of dynamic as type here?
8fadc3e to
1557a0e
Compare
|
google test fail because it is running against old version of engine. |
Adds set text semantics action, this is required to support typing in voice access
This requires engine pr: flutter-team-archive/engine#24734
fixes #77271
Pre-launch Checklist
///).If you need help, consider asking for advice on the #hackers-new channel on Discord.