Add oval drawing support to the SDF uber shader by walley892 · Pull Request #184903 · flutter/flutter

walley892 · 2026-04-10T23:27:16Z

Adds Oval rendering to the UberSDF shader, uses UberSDF oval rendering in the canvas behind the feature flag.

The SDF doesn't actually find the minimum distance to the oval, it find the distance from the test point to the center of the oval along a straight line - visually looks good though.

Fixes #183037.

Before this change:

After this change:

Diffs highlighted:

Pre-launch Checklist

walley892 · 2026-04-10T23:27:32Z

/gemini review

gemini-code-assist

Code Review

This pull request adds support for rendering ovals using Signed Distance Fields (SDFs) in Impeller, with changes spanning the canvas, parameter structures, and fragment shaders. Review feedback identifies a potential division by zero in the distanceFromOval shader function, recommends using a final else block in strokedSDF to prevent uninitialized variables, and notes a style guide violation where documentation for the public size member should use triple-slash comments.

gemini-code-assist

Code Review

This pull request introduces support for rendering ovals via the Uber SDF path in Impeller. The changes include adding oval-specific parameters, implementing a new distance function in the uber_sdf.frag shader, and updating the canvas logic to utilize these features when the SDF flag is enabled. Review feedback identified a critical numerical instability and potential division-by-zero in the shader's oval distance calculation, recommending a more robust vector-based approach. Additionally, it was noted that the canvas logic should explicitly check for the absence of a color source, as the current SDF implementation only supports solid colors.

b-luk

The SDF doesn't actually find the minimum distance to the oval, it find the distance from the test point to the center of the oval along a straight line - visually looks good though.

There's an ellipse SDF function at https://iquilezles.org/articles/distfunctions2d/. It's much more complicated than I initially would have thought. But apparently it's very complicated to get a true SDF for an ellipse. iquilezles has an entire article just about this: https://iquilezles.org/articles/ellipsedist/.

I made a shadertoy demo that compares your function to the one from iquilezles: https://www.shadertoy.com/view/7ffXDl. It switches between the two every second.

Comparing your function to the true SDF, the contours in the interior of your SDF bulge inwards towards the center at angles close to the minor axis. And on the exterior of the SDF, the contours are more diamond-shaped: at angles near the axes the contours are more sharply rounded, and at angles near the diagonals the contours are flatter. I think these distortions would show up if you draw an oval with a wide stroke width.

Interestingly, the true SDF has contours with sharp angles in the interior, along the long axis. That's not what I'd initially think the SDF would look like, but it makes sense after thinking about it for a while. This means that the interior edge of a stroked oval would have sharp corners rather than being a smooth curve, especially as the stroke width gets larger. Testing this out with a flutter app verifies that this matches what is rendered: https://dartpad.dev/?id=36e089005ba8bc1e2cefd4fc4ad7ca93

b-luk · 2026-04-13T16:25:12Z

+  float m2 = m * m;
+
+  // q is the point along that line that intersects the oval.
+  vec2 q = vec2(a * b / sqrt((a2 * m2) + b2), a * b * m / sqrt((a2 * m2) + b2));


This math is hard for me to follow. Maybe break it down a bit more?

I added some more comments

b-luk · 2026-04-13T17:22:46Z

Actually, looking at how this change draws stroked ovals, it draws the interior between two ovals with different sizes:

    outer = distanceFromOval(p, frag_info.size + vec2(half_stroke));
    inner = distanceFromOval(p, frag_info.size - vec2(half_stroke));

So it doesn't actually use the SDF contours for drawing the stroke. So I don't think you'd see the distortions I mentioned in my previous comment. But I do think using this SDF for ovals with wide stroke widths will look significantly different from the current implementation. The SDF draws a stroked shape in which the inner and outer edges are ellipses. But with a real stroked ellipse, its inner and outer edges are not ellipses.

b-luk · 2026-04-13T21:48:27Z

Here's a comparison app showing the current drawOval vs a simulated version of your SDF by drawing ovals with size +/- half_width: https://dartpad.dev/?id=57c1b2dc7af38a63f899fb2d258703e5. I put the canvas in an InteractiveViewer widget, so you can zoom and scroll in it. Try playing around with it.

walley892 · 2026-04-14T18:34:16Z

The SDF draws a stroked shape in which the inner and outer edges are ellipses. But with a real stroked ellipse, its inner and outer edges are not ellipses

This is a great point that I didn't consider. I've backed this out to only operate on filled ovals, I think the stroked case will need more consideration

b-luk · 2026-04-14T19:37:16Z

This is a great point that I didn't consider. I've backed this out to only operate on filled ovals, I think the stroked case will need more consideration

Any reason we wouldn't want to just use the ellipse SDF from iquilezles? With a true SDF, the inner and outer edges of the stroked shape would just be SDF -/+ half_stroke_width.

walley892 · 2026-04-14T19:59:51Z

Any reason we wouldn't want to just use the ellipse SDF from iquilezles? With a true SDF, the inner and outer edges of the stroked shape would just be SDF -/+ half_stroke_width.

Both SDFs from iquilezles are approximations with different shortcomings. I don't really want to ctrl-c + ctrl-v without understanding those limitations first.

With a true SDF, the inner and outer edges of the stroked shape would just be SDF -/+ half_stroke_width.

I'm not sure what you mean - you're saying to just add the stroke width to the result of the SDF? I don't think that works - we'd have to do an offset by the normal of the oval, no?

b-luk · 2026-04-14T20:13:50Z

I'm not sure what you mean - you're saying to just add the stroke width to the result of the SDF? I don't think that works - we'd have to do an offset by the normal of the oval, no?

The normal of the oval doesn't need to be considered for making it stroked.

The SDF gives us the distance to the edge of the shape. So looking at the set of all points where SDF = 1, for example, would give us a shape that is exactly distance 1 outside of the base oval at every point. And at SDF = -1, we get a shape of distance 1 inside the base oval. These are exactly the outer and inner edges of stroking the base oval with stroke width 2.

We get an SDF for the outer edge shape with outer = base_sdf - 1 (so it's 0 where the base_sdf is 1, positive outside of this, and negative inside of it). And similarly for the inner shape is inner = base_sdf + 1.

flar · 2026-04-14T20:52:12Z

Computing an ellipse with bounds that are +/- the stroke width doesn't work as mentioned before, but I think what @b-luk is referring to is doing a +/- on the actual distance function. I've suggested elsewhere that most stroke SDFs could be done by taking the filled value and performing abs(filled_sdf) - half_stroke_width to get a value that is <0 inside the stroke and >0 outside the stroke. I think the nature of the SDF will keep this value "normal to the nearest point on the outline", but I'd like to see how it behaves on ovals that get so narrow that they pinch off the inner part of the oval on the narrow ends. That might introduce singularities in the function, but we can try it and see.

walley892 · 2026-04-14T22:41:00Z

Per discussion with @gaaclarke and @b-luk , I've lifted the SDF code directly from https://iquilezles.org/articles/ellipsedist and threw back in stroked rendering following Flar's comment

flar

Looks fine, but some suggestions to take or leave...

flar · 2026-04-15T07:47:36Z

+      !paint.mask_blur_descriptor.has_value()) {
+    UberSDFParameters params;
+
+    if (paint.style == Paint::Style::kStroke) {


For simplicity we could add a std::opt<StrokeParams> getter to Paint.

Good suggestion. Will do this in a follow up PR

flar · 2026-04-15T07:52:00Z

+// TORT OR OTHERWISE, ARISING FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR
+// THE USE OR OTHER DEALINGS IN THE SOFTWARE.
+// https://www.youtube.com/c/InigoQuilez
+// https://iquilezles.org


I think Aaron said it was acceptable to have these copyright claims in the middle of a source file, but I also like the idea of moving some of these functions to an included source file like we do with the gaussian functions. If we make one for all of these Inigo functions, we'd just need the copyright header in that included file for all of the functions attributed to them.

Agree. Will also do this in a follow up PR

flar · 2026-04-15T07:58:00Z

    inner = distanceFromRect(p, frag_info.size - half_stroke);
+  } else {
+    outer = distanceFromOval(p, frag_info.size) - half_stroke;
+    inner = distanceFromOval(p, frag_info.size) + half_stroke;


For this and circle and rect we could do return abs(distanceFromShape(...) - half_stroke

Will update in a follow up PR (I think the record is scratched)

walley892 · 2026-04-15T08:16:49Z

Took some time to understand and annotate the Inigo function. Kept the code as-is because it's really optimized.

flar

LGTM

flutter-dashboard · 2026-04-16T02:55:44Z

Golden file changes have been found for this pull request. Click here to view and triage (e.g. because this is an intentional change).

If you are still iterating on this change and are not ready to resolve the images on the Flutter Gold dashboard, consider marking this PR as a draft pull request above. You will still be able to view image results on the dashboard, commenting will be silenced, and the check will not try to resolve itself until marked ready for review.

For more guidance, visit Writing a golden file test for package:flutter.

Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing.

Changes reported for pull request #184903 at sha 113fbc3

…utter#184903)

Roll Flutter from c1b14e92dcfb to 31f1802cb859 (46 revisions) flutter/flutter@c1b14e9...31f1802 2026-04-16 98614782+auto-submit[bot]@users.noreply.github.com Reverts "Run all flutter/flutter macOS tests using Xcode 26 and iOS 26 simulator (#185083)" (flutter/flutter#185145) 2026-04-16 evanwall@buffalo.edu Add oval drawing support to the SDF uber shader (flutter/flutter#184903) 2026-04-16 okorohelijah@google.com Run all flutter/flutter macOS tests using Xcode 26 and iOS 26 simulator (flutter/flutter#185083) 2026-04-16 engine-flutter-autoroll@skia.org Roll Skia from 2c49b3f9c3c2 to 391cdbe3ffe9 (2 revisions) (flutter/flutter#185138) 2026-04-16 engine-flutter-autoroll@skia.org Roll Dart SDK from 4ee990654146 to fbddcbe0cd96 (1 revision) (flutter/flutter#185137) 2026-04-16 engine-flutter-autoroll@skia.org Roll Skia from f4e3cd2c2159 to 2c49b3f9c3c2 (14 revisions) (flutter/flutter#185131) 2026-04-16 engine-flutter-autoroll@skia.org Roll Dart SDK from 87b7c87e7207 to 4ee990654146 (5 revisions) (flutter/flutter#185108) 2026-04-15 jacksongardner@google.com Use the `flutteractionsbot` token to push the release branch. (flutter/flutter#184833) 2026-04-15 63195100+tjoengCRC@users.noreply.github.com Allow period characters in iOS and macOS framework names (flutter/flutter#184335) 2026-04-15 zemanux@users.noreply.github.com Fix SliverResizingHeader semantic focus (flutter/flutter#179690) 2026-04-15 srawlins@google.com ignore avoid_type_to_string lint rule in flutter_tools (flutter/flutter#184766) 2026-04-15 engine-flutter-autoroll@skia.org Roll Skia from bda7232e6772 to f4e3cd2c2159 (4 revisions) (flutter/flutter#185063) 2026-04-15 stuartmorgan@google.com Add initial AI guidance for issues (flutter/flutter#184885) 2026-04-15 engine-flutter-autoroll@skia.org Roll Fuchsia Linux SDK from rB8LAuZL_DwHMssTU... to IdBT8fSMYrYSip65j... (flutter/flutter#185064) 2026-04-15 jason-simmons@users.noreply.github.com Fix an ordering dependency in the services/system_chrome_test.dart test suite (flutter/flutter#185086) 2026-04-15 98614782+auto-submit[bot]@users.noreply.github.com Reverts "[ios][platform_view]Reland hitTest approach (with a few 2026 update) (#183484)" (flutter/flutter#185082) 2026-04-15 98614782+auto-submit[bot]@users.noreply.github.com Reverts "Run all flutter/flutter macOS tests using Xcode 26 and iOS 26 simulator (#179810)" (flutter/flutter#185067) 2026-04-15 dacoharkes@google.com Agent rule: Dart editing (flutter/flutter#185045) 2026-04-15 41930132+hellohuanlin@users.noreply.github.com [ios][platform_view]Reland hitTest approach (with a few 2026 update) (flutter/flutter#183484) 2026-04-15 okorohelijah@google.com Run all flutter/flutter macOS tests using Xcode 26 and iOS 26 simulator (flutter/flutter#179810) 2026-04-15 engine-flutter-autoroll@skia.org Roll Dart SDK from ee5afcef0596 to 87b7c87e7207 (4 revisions) (flutter/flutter#185060) 2026-04-15 engine-flutter-autoroll@skia.org Roll Skia from 4c382df6a25a to bda7232e6772 (7 revisions) (flutter/flutter#185057) 2026-04-15 brackenavaron@gmail.com Remove material import from toggleable_test.dart + draggable_test.dart + obscured_animated_image_test.dart + sliver_constraints_test.dart (flutter/flutter#181774) 2026-04-15 120367427+master-wayne7@users.noreply.github.com refactor: Remove material imports from Widget tests (flutter/flutter#184877) 2026-04-14 52160996+FMorschel@users.noreply.github.com Adds missing `await`s on forgotten cases (flutter/flutter#183466) 2026-04-14 srawlins@google.com Use an if-element in a collection literal instead of a conditional expression (flutter/flutter#184830) 2026-04-14 50643541+Mairramer@users.noreply.github.com update popular issues documentation (flutter/flutter#183196) 2026-04-14 43054281+camsim99@users.noreply.github.com [Android] Add integration test for setting engine flags via the manifest (flutter/flutter#182241) 2026-04-14 rmacnak@google.com [fuchsia] Ask for both ambient-replace and VMEX to allow for a softer transition. (flutter/flutter#185042) 2026-04-14 goderbauer@google.com Make `multiple_windows` follow repo analyzer rules (flutter/flutter#184753) 2026-04-14 58529443+srujzs@users.noreply.github.com Ignore incoming deprecated_web_configuration lint (flutter/flutter#184130) 2026-04-14 jesswon@google.com [AGP 9] Update AGP Error (flutter/flutter#185043) 2026-04-14 magder@google.com Move widget_preview_scaffold into pub workspace (flutter/flutter#182627) 2026-04-14 planetmarshall@users.noreply.github.com Fix gles interactive tests (flutter/flutter#181389) 2026-04-14 katelovett@google.com Update customer tests.version (flutter/flutter#185044) 2026-04-14 mdebbar@google.com [SKILL] upgrade-browser (flutter/flutter#184894) 2026-04-14 dacoharkes@google.com [ci] Split up integration.shard dart_data_asset_test.dart (flutter/flutter#185021) 2026-04-14 mr-peipei@web.de Hold startup lock until after `pub get` to prevent races (flutter/flutter#184294) 2026-04-14 6226493+andeart@users.noreply.github.com Add `--include-example` flag to `flutter clean` for package example projects (flutter/flutter#183455) 2026-04-14 15619084+vashworth@users.noreply.github.com Disable multi-pack-index when calling flutter from Xcode (flutter/flutter#184998) 2026-04-14 42123156+nvi9@users.noreply.github.com Fix icon tree shaking when building for desktop (flutter/flutter#184249) 2026-04-14 15619084+vashworth@users.noreply.github.com Fix killing wrong xcrun command (flutter/flutter#184831) 2026-04-14 alex.medinsh@gmail.com Allow Xcode build configuration to not contain flavor name (flutter/flutter#183398) 2026-04-14 mdebbar@google.com [web] Async rendering for benchmarks (flutter/flutter#184677) 2026-04-14 dacoharkes@google.com [ci] Split up integration.shard native_assets_test.dart (flutter/flutter#185020) 2026-04-14 737941+loic-sharma@users.noreply.github.com Skip flutter widget-preview test that times out frequently (flutter/flutter#184988) ...

…r#11518) Roll Flutter from c1b14e92dcfb to 31f1802cb859 (46 revisions) flutter/flutter@c1b14e9...31f1802 2026-04-16 98614782+auto-submit[bot]@users.noreply.github.com Reverts "Run all flutter/flutter macOS tests using Xcode 26 and iOS 26 simulator (#185083)" (flutter/flutter#185145) 2026-04-16 evanwall@buffalo.edu Add oval drawing support to the SDF uber shader (flutter/flutter#184903) 2026-04-16 okorohelijah@google.com Run all flutter/flutter macOS tests using Xcode 26 and iOS 26 simulator (flutter/flutter#185083) 2026-04-16 engine-flutter-autoroll@skia.org Roll Skia from 2c49b3f9c3c2 to 391cdbe3ffe9 (2 revisions) (flutter/flutter#185138) 2026-04-16 engine-flutter-autoroll@skia.org Roll Dart SDK from 4ee990654146 to fbddcbe0cd96 (1 revision) (flutter/flutter#185137) 2026-04-16 engine-flutter-autoroll@skia.org Roll Skia from f4e3cd2c2159 to 2c49b3f9c3c2 (14 revisions) (flutter/flutter#185131) 2026-04-16 engine-flutter-autoroll@skia.org Roll Dart SDK from 87b7c87e7207 to 4ee990654146 (5 revisions) (flutter/flutter#185108) 2026-04-15 jacksongardner@google.com Use the `flutteractionsbot` token to push the release branch. (flutter/flutter#184833) 2026-04-15 63195100+tjoengCRC@users.noreply.github.com Allow period characters in iOS and macOS framework names (flutter/flutter#184335) 2026-04-15 zemanux@users.noreply.github.com Fix SliverResizingHeader semantic focus (flutter/flutter#179690) 2026-04-15 srawlins@google.com ignore avoid_type_to_string lint rule in flutter_tools (flutter/flutter#184766) 2026-04-15 engine-flutter-autoroll@skia.org Roll Skia from bda7232e6772 to f4e3cd2c2159 (4 revisions) (flutter/flutter#185063) 2026-04-15 stuartmorgan@google.com Add initial AI guidance for issues (flutter/flutter#184885) 2026-04-15 engine-flutter-autoroll@skia.org Roll Fuchsia Linux SDK from rB8LAuZL_DwHMssTU... to IdBT8fSMYrYSip65j... (flutter/flutter#185064) 2026-04-15 jason-simmons@users.noreply.github.com Fix an ordering dependency in the services/system_chrome_test.dart test suite (flutter/flutter#185086) 2026-04-15 98614782+auto-submit[bot]@users.noreply.github.com Reverts "[ios][platform_view]Reland hitTest approach (with a few 2026 update) (#183484)" (flutter/flutter#185082) 2026-04-15 98614782+auto-submit[bot]@users.noreply.github.com Reverts "Run all flutter/flutter macOS tests using Xcode 26 and iOS 26 simulator (#179810)" (flutter/flutter#185067) 2026-04-15 dacoharkes@google.com Agent rule: Dart editing (flutter/flutter#185045) 2026-04-15 41930132+hellohuanlin@users.noreply.github.com [ios][platform_view]Reland hitTest approach (with a few 2026 update) (flutter/flutter#183484) 2026-04-15 okorohelijah@google.com Run all flutter/flutter macOS tests using Xcode 26 and iOS 26 simulator (flutter/flutter#179810) 2026-04-15 engine-flutter-autoroll@skia.org Roll Dart SDK from ee5afcef0596 to 87b7c87e7207 (4 revisions) (flutter/flutter#185060) 2026-04-15 engine-flutter-autoroll@skia.org Roll Skia from 4c382df6a25a to bda7232e6772 (7 revisions) (flutter/flutter#185057) 2026-04-15 brackenavaron@gmail.com Remove material import from toggleable_test.dart + draggable_test.dart + obscured_animated_image_test.dart + sliver_constraints_test.dart (flutter/flutter#181774) 2026-04-15 120367427+master-wayne7@users.noreply.github.com refactor: Remove material imports from Widget tests (flutter/flutter#184877) 2026-04-14 52160996+FMorschel@users.noreply.github.com Adds missing `await`s on forgotten cases (flutter/flutter#183466) 2026-04-14 srawlins@google.com Use an if-element in a collection literal instead of a conditional expression (flutter/flutter#184830) 2026-04-14 50643541+Mairramer@users.noreply.github.com update popular issues documentation (flutter/flutter#183196) 2026-04-14 43054281+camsim99@users.noreply.github.com [Android] Add integration test for setting engine flags via the manifest (flutter/flutter#182241) 2026-04-14 rmacnak@google.com [fuchsia] Ask for both ambient-replace and VMEX to allow for a softer transition. (flutter/flutter#185042) 2026-04-14 goderbauer@google.com Make `multiple_windows` follow repo analyzer rules (flutter/flutter#184753) 2026-04-14 58529443+srujzs@users.noreply.github.com Ignore incoming deprecated_web_configuration lint (flutter/flutter#184130) 2026-04-14 jesswon@google.com [AGP 9] Update AGP Error (flutter/flutter#185043) 2026-04-14 magder@google.com Move widget_preview_scaffold into pub workspace (flutter/flutter#182627) 2026-04-14 planetmarshall@users.noreply.github.com Fix gles interactive tests (flutter/flutter#181389) 2026-04-14 katelovett@google.com Update customer tests.version (flutter/flutter#185044) 2026-04-14 mdebbar@google.com [SKILL] upgrade-browser (flutter/flutter#184894) 2026-04-14 dacoharkes@google.com [ci] Split up integration.shard dart_data_asset_test.dart (flutter/flutter#185021) 2026-04-14 mr-peipei@web.de Hold startup lock until after `pub get` to prevent races (flutter/flutter#184294) 2026-04-14 6226493+andeart@users.noreply.github.com Add `--include-example` flag to `flutter clean` for package example projects (flutter/flutter#183455) 2026-04-14 15619084+vashworth@users.noreply.github.com Disable multi-pack-index when calling flutter from Xcode (flutter/flutter#184998) 2026-04-14 42123156+nvi9@users.noreply.github.com Fix icon tree shaking when building for desktop (flutter/flutter#184249) 2026-04-14 15619084+vashworth@users.noreply.github.com Fix killing wrong xcrun command (flutter/flutter#184831) 2026-04-14 alex.medinsh@gmail.com Allow Xcode build configuration to not contain flavor name (flutter/flutter#183398) 2026-04-14 mdebbar@google.com [web] Async rendering for benchmarks (flutter/flutter#184677) 2026-04-14 dacoharkes@google.com [ci] Split up integration.shard native_assets_test.dart (flutter/flutter#185020) 2026-04-14 737941+loic-sharma@users.noreply.github.com Skip flutter widget-preview test that times out frequently (flutter/flutter#184988) ...

Add oval drawing support to the SDF uber shader

640e03b

github-actions Bot added engine flutter/engine related. See also e: labels. e: impeller Impeller rendering backend issues and features requests labels Apr 10, 2026

gemini-code-assist Bot reviewed Apr 10, 2026

View reviewed changes

Comment thread engine/src/flutter/impeller/entity/shaders/uber_sdf.frag Outdated

Comment thread engine/src/flutter/impeller/entity/shaders/uber_sdf.frag Outdated

Comment thread engine/src/flutter/impeller/entity/contents/uber_sdf_parameters.h Outdated

gemini comments

bb0bf25

walley892 marked this pull request as ready for review April 10, 2026 23:53

walley892 requested review from b-luk and flar April 10, 2026 23:53

walley892 added the CICD Run CI/CD label Apr 10, 2026

gemini-code-assist Bot reviewed Apr 10, 2026

View reviewed changes

Comment thread engine/src/flutter/impeller/entity/shaders/uber_sdf.frag Outdated

Comment thread engine/src/flutter/impeller/display_list/canvas.cc

b-luk reviewed Apr 13, 2026

View reviewed changes

Comment, fix tests

6a32b36

github-actions Bot removed the CICD Run CI/CD label Apr 13, 2026

walley892 added the CICD Run CI/CD label Apr 13, 2026

Only use SDF for filled ovals

e58732c

github-actions Bot removed the CICD Run CI/CD label Apr 14, 2026

walley892 mentioned this pull request Apr 14, 2026

Add Oval SDF renderer to uber shader #183037

Closed

update to lift directly from shadertoy

55959f7

walley892 added the CICD Run CI/CD label Apr 14, 2026

flar previously approved these changes Apr 15, 2026

View reviewed changes

Add comments. Flar comments

e1bc55c

walley892 dismissed flar’s stale review via e1bc55c April 15, 2026 08:11

github-actions Bot removed the CICD Run CI/CD label Apr 15, 2026

walley892 added the CICD Run CI/CD label Apr 15, 2026

b-luk previously approved these changes Apr 15, 2026

View reviewed changes

b-luk mentioned this pull request Apr 15, 2026

add playground to test SDF primitive rendering under transforms #185010

Merged

10 tasks

walley892 added 2 commits April 15, 2026 12:05

malioc

71d025f

license

6710a4c

walley892 dismissed b-luk’s stale review via 6710a4c April 15, 2026 19:08

github-actions Bot removed the CICD Run CI/CD label Apr 15, 2026

walley892 added the CICD Run CI/CD label Apr 15, 2026

flar approved these changes Apr 15, 2026

View reviewed changes

b-luk approved these changes Apr 15, 2026

View reviewed changes

Merge remote-tracking branch 'upstream/master' into sdf-ovals

113fbc3

github-actions Bot removed the CICD Run CI/CD label Apr 15, 2026

walley892 added the CICD Run CI/CD label Apr 15, 2026

flutter-dashboard Bot added the will affect goldens Changes to golden files label Apr 16, 2026

walley892 added the autosubmit Merge PR when tree becomes green via auto submit App label Apr 16, 2026

auto-submit Bot added this pull request to the merge queue Apr 16, 2026

Merged via the queue into flutter:master with commit e206d86 Apr 16, 2026
203 of 204 checks passed

flutter-dashboard Bot removed the autosubmit Merge PR when tree becomes green via auto submit App label Apr 16, 2026

engine-flutter-autoroll mentioned this pull request Apr 16, 2026

Roll Flutter from c1b14e92dcfb to 31f1802cb859 (46 revisions) flutter/packages#11518

Merged

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 16, 2026

e206d86db Add oval drawing support to the SDF uber shader (flutter/fl…

92d694b

…utter#184903)

walley892 mentioned this pull request Apr 17, 2026

Adds sdf rrects (and fixes opacity + color source) #184999

Merged

10 tasks

Piinks mentioned this pull request Apr 17, 2026

Flutter Notable Commits - 2026 #181433

Open

Uh oh!

Conversation

walley892 commented Apr 10, 2026

Pre-launch Checklist

Uh oh!

walley892 commented Apr 10, 2026

Uh oh!

gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

Code Review

Uh oh!

Uh oh!

Uh oh!

Uh oh!

gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

Code Review

Uh oh!

Uh oh!

Uh oh!

b-luk left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

b-luk commented Apr 13, 2026

Uh oh!

b-luk commented Apr 13, 2026

Uh oh!

walley892 commented Apr 14, 2026

Uh oh!

b-luk commented Apr 14, 2026

Uh oh!

walley892 commented Apr 14, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

b-luk commented Apr 14, 2026

Uh oh!

flar commented Apr 14, 2026

Uh oh!

walley892 commented Apr 14, 2026

Uh oh!

flar left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

walley892 commented Apr 15, 2026

Uh oh!

flar left a comment

Choose a reason for hiding this comment

Uh oh!

flutter-dashboard Bot commented Apr 16, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

walley892 commented Apr 14, 2026 •

edited

Loading