Fix gles interactive tests by planetmarshall · Pull Request #181389 · flutter/flutter

planetmarshall · 2026-01-23T15:07:40Z

Most changes either reverted or now superfluous. Retained the change that uses a unique_ptr in AllocatorGLES.

~~Fixes OpenGLES playground tests that crashed due to BufferView outliving its DeviceBuffer.~~

Replaced raw pointer in BufferView with a weak_ptr that can be tested for validity. This does come at a performance cost but local testing found it to be negligible. You may want to run your own benchmarks.
Changed the GLES DeviceBuffer's backing store to use unique_ptr rather than shared_ptr as it's the only thing to hold a reference to it.
~~Ensured that the BufferViews in the playground tests do not outlive their device buffers.~~

Fixes #181287
Related to flutter-team-archive/engine#56224

Pre-launch Checklist

I read the [Contributor Guide] and followed the process outlined there for submitting PRs.
I read the [Tree Hygiene] wiki page, which explains my responsibilities.
I read and followed the [Flutter Style Guide], including [Features we expect every widget to implement].
I signed the [CLA].
I listed at least one issue that this PR fixes in the description above.
I updated/added relevant documentation (doc comments with ///).
I added new tests to check the change I am making, or this PR is [test-exempt].
I followed the [breaking change policy] and added [Data Driven Fixes] where supported.
All existing and new tests are passing.

gaaclarke

I'm not keen on this approach. The reason why is that this is how to code used to work and we had performance problems from it. This is performance critical code. std::shared_ptr hurts locality and inserts thread synchronization we don't need in this case. These seem to be problems with how the tests are running, not production code so there isn't pressure to accept something that slows things down to make it safer soon.

Some alternatives approaches:

Make my strongly worded comment about lifetimes even stronger (joking)
Turn on ASAN in our tests and address the violations (jason told me there is a CI snafu that stopped us from using ASAN today unfortunately)
Use std::weak_ptr in debug builds only and assert they are valid
Use MiraclePtr, I'm not sure how easy this is to adopt
Use fml::RefPtr with non-synchronized ref counts. Today we only have synchronized ref count pointers but this would address locality and synchronization overhead.

planetmarshall · 2026-01-29T13:49:22Z

I'm not keen on this approach. The reason why is that this is how to code used to work and we had performance problems from it. This is performance critical code. std::shared_ptr hurts locality and inserts thread synchronization we don't need in this case.

Thanks for those insights. I've reverted the pointer changes (except the change for DeviceBufferGLES to use a unique_ptr).

gaaclarke

This is looking good at first glance, jason updated some of this to fix the render tests, can you please rebase now that his pr (#181635) has landed?

flutter-dashboard · 2026-02-26T22:02:15Z

This pull request executed golden file tests, but it has not been updated in a while (20+ days). Test results from Gold expire after as many days, so this pull request will need to be updated with a fresh commit in order to get results from Gold.

For more guidance, visit Writing a golden file test for package:flutter.

Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing.

gaaclarke

@planetmarshall did you want me to look at this again? friendly reminder to hit the "rerequest review". This looks good to me now.

flutter-dashboard · 2026-02-26T23:50:01Z

CI had a failure that stopped further tests from running. We need to investigate to determine the root cause.

SHA at time of execution: 308d5f3.

Possible causes:

Configuration Changes: The .ci.yaml file might have been modified between the creation of this pull request and the start of this test run. This can lead to ci yaml validation errors.
Infrastructure Issues: Problems with the CI environment itself (e.g., quota) could have caused the failure.

A blank commit, or merging to head, will be required to resume running CI for this PR.

Error Details:

TimeoutException after 0:00:05.000000: Future not completed

Stack trace:

#0      Future.timeout.<anonymous closure> (dart:async/future_impl.dart:1042:24)
<asynchronous suspension>
#1      _getUrl (package:cocoon_service/src/foundation/utils.dart:126:22)
<asynchronous suspension>
#2      githubFileContent.<anonymous closure> (package:cocoon_service/src/foundation/utils.dart:83:29)
<asynchronous suspension>
#3      RetryOptions.retry (package:retry/retry.dart:131:16)
<asynchronous suspension>
#4      githubFileContent (package:cocoon_service/src/foundation/utils.dart:82:5)
<asynchronous suspension>
#5      CiYamlFetcher._downloadCiYaml (package:cocoon_service/src/service/scheduler/ci_yaml_fetcher.dart:163:21)
<asynchronous suspension>
#6      CiYamlFetcher._getOrFetchCiYaml.<anonymous closure> (package:cocoon_service/src/service/scheduler/ci_yaml_fetcher.dart:144:17)
<asynchronous suspension>
#7      CacheService.getOrCreate (package:cocoon_service/src/service/cache_service.dart:66:15)
<asynchronous suspension>
#8      CiYamlFetcher._getOrFetchCiYaml (package:cocoon_service/src/service/scheduler/ci_yaml_fetcher.dart:140:25)
<asynchronous suspension>
#9      CiYamlFetcher._getCiYaml (package:cocoon_service/src/service/scheduler/ci_yaml_fetcher.dart:104:24)
<asynchronous suspension>
#10     Scheduler.getPresubmitTargets (package:cocoon_service/src/service/scheduler.dart:960:20)
<asynchronous suspension>
#11     Scheduler._getTestsForStage (package:cocoon_service/src/service/scheduler.dart:1230:14)
<asynchronous suspension>
#12     Scheduler._runCiTestingStage (package:cocoon_service/src/service/scheduler.dart:1279:32)
<asynchronous suspension>
#13     Scheduler.proceedToCiTestingStage (package:cocoon_service/src/service/scheduler.dart:1388:7)
<asynchronous suspension>
#14     Scheduler._closeSuccessfulEngineBuildStage (package:cocoon_service/src/service/scheduler.dart:1203:5)
<asynchronous suspension>
#15     Scheduler.processCheckRunCompleted (package:cocoon_service/src/service/scheduler.dart:1149:11)
<asynchronous suspension>
#16     PresubmitLuciSubscription.post (package:cocoon_service/src/request_handlers/presubmit_luci_subscription.dart:148:9)
<asynchronous suspension>
#17     RequestHandler.service (package:cocoon_service/src/request_handling/request_handler.dart:45:20)
<asynchronous suspension>
#18     SubscriptionHandler.service (package:cocoon_service/src/request_handling/subscription_handler.dart:140:5)
<asynchronous suspension>
#19     createServer.<anonymous closure> (package:cocoon_service/server.dart:413:7)
<asynchronous suspension>

This reverts commit a016644

This reverts commit eeafff9.

gaaclarke · 2026-04-13T18:25:15Z

@jason-simmons can I get an approval? Autosubmit failed to land this PR and then I had to rebase it.

auto-submit · 2026-04-13T20:40:12Z

autosubmit label was removed for flutter/flutter/181389, because - The status or check suite Linux mac_clang_tidy has failed. Please fix the issues identified (or deflake) before re-applying this label.

jason-simmons · 2026-04-13T21:14:33Z

Need a second approval because I pushed a commit to this branch.

auto-submit · 2026-04-14T18:49:11Z

autosubmit label was removed for flutter/flutter/181389, because This PR has not met approval requirements for merging. The PR author is not a member of flutter-hackers and needs 1 more review(s) in order to merge this PR.

Merge guidelines: A PR needs at least one approved review if the author is already part of flutter-hackers or two member reviews if the author is not a member of flutter-hackers before re-applying the autosubmit label. Reviewers: If you left a comment approving, please use the "approve" review action instead.

Most changes either reverted or now superfluous. Retained the change that uses a `unique_ptr` in `AllocatorGLES`. ~Fixes OpenGLES playground tests that crashed due to `BufferView` outliving its `DeviceBuffer`.~ * ~Replaced raw pointer in `BufferView` with a `weak_ptr` that can be tested for validity. This does come at a performance cost but local testing found it to be negligible. You may want to run your own benchmarks.~ * Changed the GLES DeviceBuffer's backing store to use `unique_ptr` rather than `shared_ptr` as it's the only thing to hold a reference to it. * ~Ensured that the BufferViews in the playground tests do not outlive their device buffers.~ Fixes flutter#181287 Related to flutter-team-archive/engine#56224 ## Pre-launch Checklist - [x] I read the [Contributor Guide] and followed the process outlined there for submitting PRs. - [x] I read the [Tree Hygiene] wiki page, which explains my responsibilities. - [x] I read and followed the [Flutter Style Guide], including [Features we expect every widget to implement]. - [x] I signed the [CLA]. - [x] I listed at least one issue that this PR fixes in the description above. - [x] I updated/added relevant documentation (doc comments with `///`). - [x] I added new tests to check the change I am making, or this PR is [test-exempt]. - [x] I followed the [breaking change policy] and added [Data Driven Fixes] where supported. - [x] All existing and new tests are passing. --------- Co-authored-by: Jason Simmons <jsimmons@google.com>

Roll Flutter from c1b14e92dcfb to 31f1802cb859 (46 revisions) flutter/flutter@c1b14e9...31f1802 2026-04-16 98614782+auto-submit[bot]@users.noreply.github.com Reverts "Run all flutter/flutter macOS tests using Xcode 26 and iOS 26 simulator (#185083)" (flutter/flutter#185145) 2026-04-16 evanwall@buffalo.edu Add oval drawing support to the SDF uber shader (flutter/flutter#184903) 2026-04-16 okorohelijah@google.com Run all flutter/flutter macOS tests using Xcode 26 and iOS 26 simulator (flutter/flutter#185083) 2026-04-16 engine-flutter-autoroll@skia.org Roll Skia from 2c49b3f9c3c2 to 391cdbe3ffe9 (2 revisions) (flutter/flutter#185138) 2026-04-16 engine-flutter-autoroll@skia.org Roll Dart SDK from 4ee990654146 to fbddcbe0cd96 (1 revision) (flutter/flutter#185137) 2026-04-16 engine-flutter-autoroll@skia.org Roll Skia from f4e3cd2c2159 to 2c49b3f9c3c2 (14 revisions) (flutter/flutter#185131) 2026-04-16 engine-flutter-autoroll@skia.org Roll Dart SDK from 87b7c87e7207 to 4ee990654146 (5 revisions) (flutter/flutter#185108) 2026-04-15 jacksongardner@google.com Use the `flutteractionsbot` token to push the release branch. (flutter/flutter#184833) 2026-04-15 63195100+tjoengCRC@users.noreply.github.com Allow period characters in iOS and macOS framework names (flutter/flutter#184335) 2026-04-15 zemanux@users.noreply.github.com Fix SliverResizingHeader semantic focus (flutter/flutter#179690) 2026-04-15 srawlins@google.com ignore avoid_type_to_string lint rule in flutter_tools (flutter/flutter#184766) 2026-04-15 engine-flutter-autoroll@skia.org Roll Skia from bda7232e6772 to f4e3cd2c2159 (4 revisions) (flutter/flutter#185063) 2026-04-15 stuartmorgan@google.com Add initial AI guidance for issues (flutter/flutter#184885) 2026-04-15 engine-flutter-autoroll@skia.org Roll Fuchsia Linux SDK from rB8LAuZL_DwHMssTU... to IdBT8fSMYrYSip65j... (flutter/flutter#185064) 2026-04-15 jason-simmons@users.noreply.github.com Fix an ordering dependency in the services/system_chrome_test.dart test suite (flutter/flutter#185086) 2026-04-15 98614782+auto-submit[bot]@users.noreply.github.com Reverts "[ios][platform_view]Reland hitTest approach (with a few 2026 update) (#183484)" (flutter/flutter#185082) 2026-04-15 98614782+auto-submit[bot]@users.noreply.github.com Reverts "Run all flutter/flutter macOS tests using Xcode 26 and iOS 26 simulator (#179810)" (flutter/flutter#185067) 2026-04-15 dacoharkes@google.com Agent rule: Dart editing (flutter/flutter#185045) 2026-04-15 41930132+hellohuanlin@users.noreply.github.com [ios][platform_view]Reland hitTest approach (with a few 2026 update) (flutter/flutter#183484) 2026-04-15 okorohelijah@google.com Run all flutter/flutter macOS tests using Xcode 26 and iOS 26 simulator (flutter/flutter#179810) 2026-04-15 engine-flutter-autoroll@skia.org Roll Dart SDK from ee5afcef0596 to 87b7c87e7207 (4 revisions) (flutter/flutter#185060) 2026-04-15 engine-flutter-autoroll@skia.org Roll Skia from 4c382df6a25a to bda7232e6772 (7 revisions) (flutter/flutter#185057) 2026-04-15 brackenavaron@gmail.com Remove material import from toggleable_test.dart + draggable_test.dart + obscured_animated_image_test.dart + sliver_constraints_test.dart (flutter/flutter#181774) 2026-04-15 120367427+master-wayne7@users.noreply.github.com refactor: Remove material imports from Widget tests (flutter/flutter#184877) 2026-04-14 52160996+FMorschel@users.noreply.github.com Adds missing `await`s on forgotten cases (flutter/flutter#183466) 2026-04-14 srawlins@google.com Use an if-element in a collection literal instead of a conditional expression (flutter/flutter#184830) 2026-04-14 50643541+Mairramer@users.noreply.github.com update popular issues documentation (flutter/flutter#183196) 2026-04-14 43054281+camsim99@users.noreply.github.com [Android] Add integration test for setting engine flags via the manifest (flutter/flutter#182241) 2026-04-14 rmacnak@google.com [fuchsia] Ask for both ambient-replace and VMEX to allow for a softer transition. (flutter/flutter#185042) 2026-04-14 goderbauer@google.com Make `multiple_windows` follow repo analyzer rules (flutter/flutter#184753) 2026-04-14 58529443+srujzs@users.noreply.github.com Ignore incoming deprecated_web_configuration lint (flutter/flutter#184130) 2026-04-14 jesswon@google.com [AGP 9] Update AGP Error (flutter/flutter#185043) 2026-04-14 magder@google.com Move widget_preview_scaffold into pub workspace (flutter/flutter#182627) 2026-04-14 planetmarshall@users.noreply.github.com Fix gles interactive tests (flutter/flutter#181389) 2026-04-14 katelovett@google.com Update customer tests.version (flutter/flutter#185044) 2026-04-14 mdebbar@google.com [SKILL] upgrade-browser (flutter/flutter#184894) 2026-04-14 dacoharkes@google.com [ci] Split up integration.shard dart_data_asset_test.dart (flutter/flutter#185021) 2026-04-14 mr-peipei@web.de Hold startup lock until after `pub get` to prevent races (flutter/flutter#184294) 2026-04-14 6226493+andeart@users.noreply.github.com Add `--include-example` flag to `flutter clean` for package example projects (flutter/flutter#183455) 2026-04-14 15619084+vashworth@users.noreply.github.com Disable multi-pack-index when calling flutter from Xcode (flutter/flutter#184998) 2026-04-14 42123156+nvi9@users.noreply.github.com Fix icon tree shaking when building for desktop (flutter/flutter#184249) 2026-04-14 15619084+vashworth@users.noreply.github.com Fix killing wrong xcrun command (flutter/flutter#184831) 2026-04-14 alex.medinsh@gmail.com Allow Xcode build configuration to not contain flavor name (flutter/flutter#183398) 2026-04-14 mdebbar@google.com [web] Async rendering for benchmarks (flutter/flutter#184677) 2026-04-14 dacoharkes@google.com [ci] Split up integration.shard native_assets_test.dart (flutter/flutter#185020) 2026-04-14 737941+loic-sharma@users.noreply.github.com Skip flutter widget-preview test that times out frequently (flutter/flutter#184988) ...

…r#11518) Roll Flutter from c1b14e92dcfb to 31f1802cb859 (46 revisions) flutter/flutter@c1b14e9...31f1802 2026-04-16 98614782+auto-submit[bot]@users.noreply.github.com Reverts "Run all flutter/flutter macOS tests using Xcode 26 and iOS 26 simulator (#185083)" (flutter/flutter#185145) 2026-04-16 evanwall@buffalo.edu Add oval drawing support to the SDF uber shader (flutter/flutter#184903) 2026-04-16 okorohelijah@google.com Run all flutter/flutter macOS tests using Xcode 26 and iOS 26 simulator (flutter/flutter#185083) 2026-04-16 engine-flutter-autoroll@skia.org Roll Skia from 2c49b3f9c3c2 to 391cdbe3ffe9 (2 revisions) (flutter/flutter#185138) 2026-04-16 engine-flutter-autoroll@skia.org Roll Dart SDK from 4ee990654146 to fbddcbe0cd96 (1 revision) (flutter/flutter#185137) 2026-04-16 engine-flutter-autoroll@skia.org Roll Skia from f4e3cd2c2159 to 2c49b3f9c3c2 (14 revisions) (flutter/flutter#185131) 2026-04-16 engine-flutter-autoroll@skia.org Roll Dart SDK from 87b7c87e7207 to 4ee990654146 (5 revisions) (flutter/flutter#185108) 2026-04-15 jacksongardner@google.com Use the `flutteractionsbot` token to push the release branch. (flutter/flutter#184833) 2026-04-15 63195100+tjoengCRC@users.noreply.github.com Allow period characters in iOS and macOS framework names (flutter/flutter#184335) 2026-04-15 zemanux@users.noreply.github.com Fix SliverResizingHeader semantic focus (flutter/flutter#179690) 2026-04-15 srawlins@google.com ignore avoid_type_to_string lint rule in flutter_tools (flutter/flutter#184766) 2026-04-15 engine-flutter-autoroll@skia.org Roll Skia from bda7232e6772 to f4e3cd2c2159 (4 revisions) (flutter/flutter#185063) 2026-04-15 stuartmorgan@google.com Add initial AI guidance for issues (flutter/flutter#184885) 2026-04-15 engine-flutter-autoroll@skia.org Roll Fuchsia Linux SDK from rB8LAuZL_DwHMssTU... to IdBT8fSMYrYSip65j... (flutter/flutter#185064) 2026-04-15 jason-simmons@users.noreply.github.com Fix an ordering dependency in the services/system_chrome_test.dart test suite (flutter/flutter#185086) 2026-04-15 98614782+auto-submit[bot]@users.noreply.github.com Reverts "[ios][platform_view]Reland hitTest approach (with a few 2026 update) (#183484)" (flutter/flutter#185082) 2026-04-15 98614782+auto-submit[bot]@users.noreply.github.com Reverts "Run all flutter/flutter macOS tests using Xcode 26 and iOS 26 simulator (#179810)" (flutter/flutter#185067) 2026-04-15 dacoharkes@google.com Agent rule: Dart editing (flutter/flutter#185045) 2026-04-15 41930132+hellohuanlin@users.noreply.github.com [ios][platform_view]Reland hitTest approach (with a few 2026 update) (flutter/flutter#183484) 2026-04-15 okorohelijah@google.com Run all flutter/flutter macOS tests using Xcode 26 and iOS 26 simulator (flutter/flutter#179810) 2026-04-15 engine-flutter-autoroll@skia.org Roll Dart SDK from ee5afcef0596 to 87b7c87e7207 (4 revisions) (flutter/flutter#185060) 2026-04-15 engine-flutter-autoroll@skia.org Roll Skia from 4c382df6a25a to bda7232e6772 (7 revisions) (flutter/flutter#185057) 2026-04-15 brackenavaron@gmail.com Remove material import from toggleable_test.dart + draggable_test.dart + obscured_animated_image_test.dart + sliver_constraints_test.dart (flutter/flutter#181774) 2026-04-15 120367427+master-wayne7@users.noreply.github.com refactor: Remove material imports from Widget tests (flutter/flutter#184877) 2026-04-14 52160996+FMorschel@users.noreply.github.com Adds missing `await`s on forgotten cases (flutter/flutter#183466) 2026-04-14 srawlins@google.com Use an if-element in a collection literal instead of a conditional expression (flutter/flutter#184830) 2026-04-14 50643541+Mairramer@users.noreply.github.com update popular issues documentation (flutter/flutter#183196) 2026-04-14 43054281+camsim99@users.noreply.github.com [Android] Add integration test for setting engine flags via the manifest (flutter/flutter#182241) 2026-04-14 rmacnak@google.com [fuchsia] Ask for both ambient-replace and VMEX to allow for a softer transition. (flutter/flutter#185042) 2026-04-14 goderbauer@google.com Make `multiple_windows` follow repo analyzer rules (flutter/flutter#184753) 2026-04-14 58529443+srujzs@users.noreply.github.com Ignore incoming deprecated_web_configuration lint (flutter/flutter#184130) 2026-04-14 jesswon@google.com [AGP 9] Update AGP Error (flutter/flutter#185043) 2026-04-14 magder@google.com Move widget_preview_scaffold into pub workspace (flutter/flutter#182627) 2026-04-14 planetmarshall@users.noreply.github.com Fix gles interactive tests (flutter/flutter#181389) 2026-04-14 katelovett@google.com Update customer tests.version (flutter/flutter#185044) 2026-04-14 mdebbar@google.com [SKILL] upgrade-browser (flutter/flutter#184894) 2026-04-14 dacoharkes@google.com [ci] Split up integration.shard dart_data_asset_test.dart (flutter/flutter#185021) 2026-04-14 mr-peipei@web.de Hold startup lock until after `pub get` to prevent races (flutter/flutter#184294) 2026-04-14 6226493+andeart@users.noreply.github.com Add `--include-example` flag to `flutter clean` for package example projects (flutter/flutter#183455) 2026-04-14 15619084+vashworth@users.noreply.github.com Disable multi-pack-index when calling flutter from Xcode (flutter/flutter#184998) 2026-04-14 42123156+nvi9@users.noreply.github.com Fix icon tree shaking when building for desktop (flutter/flutter#184249) 2026-04-14 15619084+vashworth@users.noreply.github.com Fix killing wrong xcrun command (flutter/flutter#184831) 2026-04-14 alex.medinsh@gmail.com Allow Xcode build configuration to not contain flavor name (flutter/flutter#183398) 2026-04-14 mdebbar@google.com [web] Async rendering for benchmarks (flutter/flutter#184677) 2026-04-14 dacoharkes@google.com [ci] Split up integration.shard native_assets_test.dart (flutter/flutter#185020) 2026-04-14 737941+loic-sharma@users.noreply.github.com Skip flutter widget-preview test that times out frequently (flutter/flutter#184988) ...

github-actions Bot added engine flutter/engine related. See also e: labels. e: impeller Impeller rendering backend issues and features requests labels Jan 23, 2026

jason-simmons mentioned this pull request Jan 26, 2026

[impeller] ASAN failures in interactive tests on OpenGLES #181287

Closed

gaaclarke self-requested a review January 27, 2026 00:44

gaaclarke requested changes Jan 28, 2026

View reviewed changes

gaaclarke reviewed Feb 2, 2026

View reviewed changes

planetmarshall force-pushed the fix-gles-interactive-tests branch from 57972e1 to a48b86a Compare February 6, 2026 21:53

gaaclarke previously approved these changes Feb 26, 2026

View reviewed changes

gaaclarke requested a review from jason-simmons February 26, 2026 22:16

jason-simmons previously approved these changes Feb 26, 2026

View reviewed changes

gaaclarke added the autosubmit Merge PR when tree becomes green via auto submit App label Feb 26, 2026

planetmarshall added 8 commits April 13, 2026 11:18

device buffer can have unique ownership of its backing store

ed1e1f9

Use weak instead of raw pointer in buffer view

1614699

ensure host buffers in playground tests do not go out of scope

2a3389e

skip death test on non-posix or release

a8e9694

skip the no-crash test in debug mode to avoid the assert

c073e9b

Revert "Use weak instead of raw pointer in buffer view"

be4eab1

This reverts commit a016644

Revert "skip the no-crash test in debug mode to avoid the assert"

d3a5bf9

This reverts commit eeafff9.

fix rebase

61c5ea6

gaaclarke dismissed stale reviews from jason-simmons and themself via 61c5ea6 April 13, 2026 18:24

gaaclarke force-pushed the fix-gles-interactive-tests branch from 308d5f3 to 61c5ea6 Compare April 13, 2026 18:24

gaaclarke previously approved these changes Apr 13, 2026

View reviewed changes

gaaclarke added CICD Run CI/CD and removed autosubmit Merge PR when tree becomes green via auto submit App labels Apr 13, 2026

gaaclarke requested a review from jason-simmons April 13, 2026 18:24

fix BufferBindingsGLESTest.BindUniformDataVerticesAndMatrices

81b375b

jason-simmons dismissed stale reviews from gaaclarke and themself via 81b375b April 13, 2026 21:08

github-actions Bot removed the CICD Run CI/CD label Apr 13, 2026

jason-simmons added the CICD Run CI/CD label Apr 13, 2026

gaaclarke approved these changes Apr 13, 2026

View reviewed changes

jason-simmons requested a review from jtmcdole April 13, 2026 21:13

jason-simmons added the autosubmit Merge PR when tree becomes green via auto submit App label Apr 14, 2026

auto-submit Bot removed the autosubmit Merge PR when tree becomes green via auto submit App label Apr 14, 2026

jtmcdole approved these changes Apr 14, 2026

View reviewed changes

jason-simmons added the autosubmit Merge PR when tree becomes green via auto submit App label Apr 14, 2026

auto-submit Bot added this pull request to the merge queue Apr 14, 2026

Merged via the queue into flutter:master with commit c02b17a Apr 14, 2026
204 of 205 checks passed

flutter-dashboard Bot removed the autosubmit Merge PR when tree becomes green via auto submit App label Apr 14, 2026

engine-flutter-autoroll mentioned this pull request Apr 15, 2026

Roll Flutter from c1b14e92dcfb to 4634b93d8c03 (30 revisions) flutter/packages#11513

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 15, 2026

c02b17a7b Fix gles interactive tests (flutter/flutter#181389)

fb8e725

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 15, 2026

c02b17a7b Fix gles interactive tests (flutter/flutter#181389)

2f89d0b

engine-flutter-autoroll mentioned this pull request Apr 15, 2026

Roll Flutter from c1b14e92dcfb to ab21ec800abf (31 revisions) flutter/packages#11514

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 15, 2026

c02b17a7b Fix gles interactive tests (flutter/flutter#181389)

4cc5d36

engine-flutter-autoroll mentioned this pull request Apr 15, 2026

Roll Flutter from c1b14e92dcfb to 6154f7548c56 (32 revisions) flutter/packages#11515

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 16, 2026

c02b17a7b Fix gles interactive tests (flutter/flutter#181389)

39cf42d

engine-flutter-autoroll mentioned this pull request Apr 16, 2026

Roll Flutter from c1b14e92dcfb to 31f1802cb859 (46 revisions) flutter/packages#11518

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Fix gles interactive tests#181389

Fix gles interactive tests#181389
auto-submit[bot] merged 9 commits into
flutter:masterfrom
planetmarshall:fix-gles-interactive-tests

planetmarshall commented Jan 23, 2026 •

edited

Loading

Uh oh!

gaaclarke left a comment

Uh oh!

planetmarshall commented Jan 29, 2026

Uh oh!

gaaclarke left a comment

Uh oh!

flutter-dashboard Bot commented Feb 26, 2026

Uh oh!

gaaclarke left a comment

Uh oh!

flutter-dashboard Bot commented Feb 26, 2026

Uh oh!

gaaclarke commented Apr 13, 2026

Uh oh!

auto-submit Bot commented Apr 13, 2026

Uh oh!

jason-simmons commented Apr 13, 2026

Uh oh!

auto-submit Bot commented Apr 14, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Uh oh!

Conversation

planetmarshall commented Jan 23, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Pre-launch Checklist

Uh oh!

gaaclarke left a comment

Choose a reason for hiding this comment

Uh oh!

planetmarshall commented Jan 29, 2026

Uh oh!

gaaclarke left a comment

Choose a reason for hiding this comment

Uh oh!

flutter-dashboard Bot commented Feb 26, 2026

Uh oh!

gaaclarke left a comment

Choose a reason for hiding this comment

Uh oh!

flutter-dashboard Bot commented Feb 26, 2026

Uh oh!

gaaclarke commented Apr 13, 2026

Uh oh!

auto-submit Bot commented Apr 13, 2026

Uh oh!

jason-simmons commented Apr 13, 2026

Uh oh!

auto-submit Bot commented Apr 14, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

planetmarshall commented Jan 23, 2026 •

edited

Loading