Adds missing `await`s on forgotten cases by FMorschel · Pull Request #183466 · flutter/flutter

FMorschel · 2026-03-10T20:18:40Z

This is similar to #182301.

This is merely an analyzer change to avoid the bug explained at:

Linter rule to prevent returning futures from the try block dart-lang/sdk#62555.

This will allow the development of a warning about these situations so we can avoid this bug in the future.

Pre-launch Checklist

I read the Contributor Guide and followed the process outlined there for submitting PRs.
I read the Tree Hygiene wiki page, which explains my responsibilities.
I read and followed the Flutter Style Guide, including Features we expect every widget to implement.
I signed the CLA.
I listed at least one issue that this PR fixes in the description above.
I updated/added relevant documentation (doc comments with ///).
I added new tests to check the change I am making, or this PR is test-exempt.
I followed the breaking change policy and added Data Driven Fixes where supported.
All existing and new tests are passing.

flutter-dashboard · 2026-03-10T20:18:43Z

It looks like this pull request may not have tests. Please make sure to add tests or get an explicit test exemption before merging.

If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix?

Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing. If you believe this PR qualifies for a test exemption, contact "@test-exemption-reviewer" in the #hackers channel in Discord (don't just cc them here, they won't see it!). The test exemption team is a small volunteer group, so all reviewers should feel empowered to ask for tests, without delegating that responsibility entirely to the test exemption group.

stuartmorgan-g · 2026-03-10T20:21:53Z

test-exempt: unblocks future analyzer update

gemini-code-assist

Code Review

This pull request adds missing await keywords in several files. In packages/flutter/lib/src/painting/_network_image_io.dart, this fixes a bug where an exception during image decoding would not be caught by the surrounding try-catch block. The other changes are for consistency in returning awaited futures from async functions.

FMorschel · 2026-03-13T15:41:44Z

@LouiseHsu, could you please take a look at the changes to the tests to make sure they are fine (or ask someone who would know to take a look)? I'm not really familiar with this code. I'm not entirely sure that message was explicitly intended to show up, and if so, if I should do something similar around where I added the new await (in the catches for it).

LouiseHsu · 2026-03-19T22:45:43Z

              expect(firstExitCode, isNotNull);
              expect(firstExitCode, isNot(0));
-              expect(error.toString(), 'Exception: test exit');
+              expect(error.toString(), 'ProcessExit: 1');


@bkonyi sorry to randomly tag you, but do you think this out put looks okay? not sure why adding awaits would trigger a different error output.

This is because the actual throw is now caught at that await. Please look at that linked issue with the explanation @LouiseHsu.

@LouiseHsu, don't be sorry (easier said than done, I know! 🇨🇦) Seems reasonable to me!

auto-submit · 2026-04-07T22:32:35Z

autosubmit label was removed for flutter/flutter/183466, because The base commit of the PR is older than 7 days and can not be merged. Please merge the latest changes from the main into this branch and resubmit the PR.

Piinks · 2026-04-14T22:26:42Z

Is this ready to land? Should we apply autosubmit?

FMorschel · 2026-04-14T22:28:12Z

If nobody has any takes against it (which seems like it), yes please. Hopefully there won't be any more cases like this before the analyzer changes land.

This is similar to flutter#182301. This is merely an `analyzer` change to avoid the bug explained at: - dart-lang/sdk#62555. This will allow the development of a warning about these situations so we can avoid this bug in the future. ## Pre-launch Checklist - [x] I read the [Contributor Guide] and followed the process outlined there for submitting PRs. - [x] I read the [Tree Hygiene] wiki page, which explains my responsibilities. - [x] I read and followed the [Flutter Style Guide], including [Features we expect every widget to implement]. - [x] I signed the [CLA]. - [x] I listed at least one issue that this PR fixes in the description above. - [ ] I updated/added relevant documentation (doc comments with `///`). - [x] I added new tests to check the change I am making, or this PR is [test-exempt]. - [ ] I followed the [breaking change policy] and added [Data Driven Fixes] where supported. - [x] All existing and new tests are passing.  [Contributor Guide]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#overview [Tree Hygiene]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md [test-exempt]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#tests [Flutter Style Guide]: https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md [Features we expect every widget to implement]: https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md#features-we-expect-every-widget-to-implement [CLA]: https://cla.developers.google.com/ [flutter/tests]: https://github.com/flutter/tests [breaking change policy]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#handling-breaking-changes [Discord]: https://github.com/flutter/flutter/blob/main/docs/contributing/Chat.md [Data Driven Fixes]: https://github.com/flutter/flutter/blob/main/docs/contributing/Data-driven-Fixes.md

…83466)

Roll Flutter from c1b14e92dcfb to 31f1802cb859 (46 revisions) flutter/flutter@c1b14e9...31f1802 2026-04-16 98614782+auto-submit[bot]@users.noreply.github.com Reverts "Run all flutter/flutter macOS tests using Xcode 26 and iOS 26 simulator (#185083)" (flutter/flutter#185145) 2026-04-16 evanwall@buffalo.edu Add oval drawing support to the SDF uber shader (flutter/flutter#184903) 2026-04-16 okorohelijah@google.com Run all flutter/flutter macOS tests using Xcode 26 and iOS 26 simulator (flutter/flutter#185083) 2026-04-16 engine-flutter-autoroll@skia.org Roll Skia from 2c49b3f9c3c2 to 391cdbe3ffe9 (2 revisions) (flutter/flutter#185138) 2026-04-16 engine-flutter-autoroll@skia.org Roll Dart SDK from 4ee990654146 to fbddcbe0cd96 (1 revision) (flutter/flutter#185137) 2026-04-16 engine-flutter-autoroll@skia.org Roll Skia from f4e3cd2c2159 to 2c49b3f9c3c2 (14 revisions) (flutter/flutter#185131) 2026-04-16 engine-flutter-autoroll@skia.org Roll Dart SDK from 87b7c87e7207 to 4ee990654146 (5 revisions) (flutter/flutter#185108) 2026-04-15 jacksongardner@google.com Use the `flutteractionsbot` token to push the release branch. (flutter/flutter#184833) 2026-04-15 63195100+tjoengCRC@users.noreply.github.com Allow period characters in iOS and macOS framework names (flutter/flutter#184335) 2026-04-15 zemanux@users.noreply.github.com Fix SliverResizingHeader semantic focus (flutter/flutter#179690) 2026-04-15 srawlins@google.com ignore avoid_type_to_string lint rule in flutter_tools (flutter/flutter#184766) 2026-04-15 engine-flutter-autoroll@skia.org Roll Skia from bda7232e6772 to f4e3cd2c2159 (4 revisions) (flutter/flutter#185063) 2026-04-15 stuartmorgan@google.com Add initial AI guidance for issues (flutter/flutter#184885) 2026-04-15 engine-flutter-autoroll@skia.org Roll Fuchsia Linux SDK from rB8LAuZL_DwHMssTU... to IdBT8fSMYrYSip65j... (flutter/flutter#185064) 2026-04-15 jason-simmons@users.noreply.github.com Fix an ordering dependency in the services/system_chrome_test.dart test suite (flutter/flutter#185086) 2026-04-15 98614782+auto-submit[bot]@users.noreply.github.com Reverts "[ios][platform_view]Reland hitTest approach (with a few 2026 update) (#183484)" (flutter/flutter#185082) 2026-04-15 98614782+auto-submit[bot]@users.noreply.github.com Reverts "Run all flutter/flutter macOS tests using Xcode 26 and iOS 26 simulator (#179810)" (flutter/flutter#185067) 2026-04-15 dacoharkes@google.com Agent rule: Dart editing (flutter/flutter#185045) 2026-04-15 41930132+hellohuanlin@users.noreply.github.com [ios][platform_view]Reland hitTest approach (with a few 2026 update) (flutter/flutter#183484) 2026-04-15 okorohelijah@google.com Run all flutter/flutter macOS tests using Xcode 26 and iOS 26 simulator (flutter/flutter#179810) 2026-04-15 engine-flutter-autoroll@skia.org Roll Dart SDK from ee5afcef0596 to 87b7c87e7207 (4 revisions) (flutter/flutter#185060) 2026-04-15 engine-flutter-autoroll@skia.org Roll Skia from 4c382df6a25a to bda7232e6772 (7 revisions) (flutter/flutter#185057) 2026-04-15 brackenavaron@gmail.com Remove material import from toggleable_test.dart + draggable_test.dart + obscured_animated_image_test.dart + sliver_constraints_test.dart (flutter/flutter#181774) 2026-04-15 120367427+master-wayne7@users.noreply.github.com refactor: Remove material imports from Widget tests (flutter/flutter#184877) 2026-04-14 52160996+FMorschel@users.noreply.github.com Adds missing `await`s on forgotten cases (flutter/flutter#183466) 2026-04-14 srawlins@google.com Use an if-element in a collection literal instead of a conditional expression (flutter/flutter#184830) 2026-04-14 50643541+Mairramer@users.noreply.github.com update popular issues documentation (flutter/flutter#183196) 2026-04-14 43054281+camsim99@users.noreply.github.com [Android] Add integration test for setting engine flags via the manifest (flutter/flutter#182241) 2026-04-14 rmacnak@google.com [fuchsia] Ask for both ambient-replace and VMEX to allow for a softer transition. (flutter/flutter#185042) 2026-04-14 goderbauer@google.com Make `multiple_windows` follow repo analyzer rules (flutter/flutter#184753) 2026-04-14 58529443+srujzs@users.noreply.github.com Ignore incoming deprecated_web_configuration lint (flutter/flutter#184130) 2026-04-14 jesswon@google.com [AGP 9] Update AGP Error (flutter/flutter#185043) 2026-04-14 magder@google.com Move widget_preview_scaffold into pub workspace (flutter/flutter#182627) 2026-04-14 planetmarshall@users.noreply.github.com Fix gles interactive tests (flutter/flutter#181389) 2026-04-14 katelovett@google.com Update customer tests.version (flutter/flutter#185044) 2026-04-14 mdebbar@google.com [SKILL] upgrade-browser (flutter/flutter#184894) 2026-04-14 dacoharkes@google.com [ci] Split up integration.shard dart_data_asset_test.dart (flutter/flutter#185021) 2026-04-14 mr-peipei@web.de Hold startup lock until after `pub get` to prevent races (flutter/flutter#184294) 2026-04-14 6226493+andeart@users.noreply.github.com Add `--include-example` flag to `flutter clean` for package example projects (flutter/flutter#183455) 2026-04-14 15619084+vashworth@users.noreply.github.com Disable multi-pack-index when calling flutter from Xcode (flutter/flutter#184998) 2026-04-14 42123156+nvi9@users.noreply.github.com Fix icon tree shaking when building for desktop (flutter/flutter#184249) 2026-04-14 15619084+vashworth@users.noreply.github.com Fix killing wrong xcrun command (flutter/flutter#184831) 2026-04-14 alex.medinsh@gmail.com Allow Xcode build configuration to not contain flavor name (flutter/flutter#183398) 2026-04-14 mdebbar@google.com [web] Async rendering for benchmarks (flutter/flutter#184677) 2026-04-14 dacoharkes@google.com [ci] Split up integration.shard native_assets_test.dart (flutter/flutter#185020) 2026-04-14 737941+loic-sharma@users.noreply.github.com Skip flutter widget-preview test that times out frequently (flutter/flutter#184988) ...

…r#11518) Roll Flutter from c1b14e92dcfb to 31f1802cb859 (46 revisions) flutter/flutter@c1b14e9...31f1802 2026-04-16 98614782+auto-submit[bot]@users.noreply.github.com Reverts "Run all flutter/flutter macOS tests using Xcode 26 and iOS 26 simulator (#185083)" (flutter/flutter#185145) 2026-04-16 evanwall@buffalo.edu Add oval drawing support to the SDF uber shader (flutter/flutter#184903) 2026-04-16 okorohelijah@google.com Run all flutter/flutter macOS tests using Xcode 26 and iOS 26 simulator (flutter/flutter#185083) 2026-04-16 engine-flutter-autoroll@skia.org Roll Skia from 2c49b3f9c3c2 to 391cdbe3ffe9 (2 revisions) (flutter/flutter#185138) 2026-04-16 engine-flutter-autoroll@skia.org Roll Dart SDK from 4ee990654146 to fbddcbe0cd96 (1 revision) (flutter/flutter#185137) 2026-04-16 engine-flutter-autoroll@skia.org Roll Skia from f4e3cd2c2159 to 2c49b3f9c3c2 (14 revisions) (flutter/flutter#185131) 2026-04-16 engine-flutter-autoroll@skia.org Roll Dart SDK from 87b7c87e7207 to 4ee990654146 (5 revisions) (flutter/flutter#185108) 2026-04-15 jacksongardner@google.com Use the `flutteractionsbot` token to push the release branch. (flutter/flutter#184833) 2026-04-15 63195100+tjoengCRC@users.noreply.github.com Allow period characters in iOS and macOS framework names (flutter/flutter#184335) 2026-04-15 zemanux@users.noreply.github.com Fix SliverResizingHeader semantic focus (flutter/flutter#179690) 2026-04-15 srawlins@google.com ignore avoid_type_to_string lint rule in flutter_tools (flutter/flutter#184766) 2026-04-15 engine-flutter-autoroll@skia.org Roll Skia from bda7232e6772 to f4e3cd2c2159 (4 revisions) (flutter/flutter#185063) 2026-04-15 stuartmorgan@google.com Add initial AI guidance for issues (flutter/flutter#184885) 2026-04-15 engine-flutter-autoroll@skia.org Roll Fuchsia Linux SDK from rB8LAuZL_DwHMssTU... to IdBT8fSMYrYSip65j... (flutter/flutter#185064) 2026-04-15 jason-simmons@users.noreply.github.com Fix an ordering dependency in the services/system_chrome_test.dart test suite (flutter/flutter#185086) 2026-04-15 98614782+auto-submit[bot]@users.noreply.github.com Reverts "[ios][platform_view]Reland hitTest approach (with a few 2026 update) (#183484)" (flutter/flutter#185082) 2026-04-15 98614782+auto-submit[bot]@users.noreply.github.com Reverts "Run all flutter/flutter macOS tests using Xcode 26 and iOS 26 simulator (#179810)" (flutter/flutter#185067) 2026-04-15 dacoharkes@google.com Agent rule: Dart editing (flutter/flutter#185045) 2026-04-15 41930132+hellohuanlin@users.noreply.github.com [ios][platform_view]Reland hitTest approach (with a few 2026 update) (flutter/flutter#183484) 2026-04-15 okorohelijah@google.com Run all flutter/flutter macOS tests using Xcode 26 and iOS 26 simulator (flutter/flutter#179810) 2026-04-15 engine-flutter-autoroll@skia.org Roll Dart SDK from ee5afcef0596 to 87b7c87e7207 (4 revisions) (flutter/flutter#185060) 2026-04-15 engine-flutter-autoroll@skia.org Roll Skia from 4c382df6a25a to bda7232e6772 (7 revisions) (flutter/flutter#185057) 2026-04-15 brackenavaron@gmail.com Remove material import from toggleable_test.dart + draggable_test.dart + obscured_animated_image_test.dart + sliver_constraints_test.dart (flutter/flutter#181774) 2026-04-15 120367427+master-wayne7@users.noreply.github.com refactor: Remove material imports from Widget tests (flutter/flutter#184877) 2026-04-14 52160996+FMorschel@users.noreply.github.com Adds missing `await`s on forgotten cases (flutter/flutter#183466) 2026-04-14 srawlins@google.com Use an if-element in a collection literal instead of a conditional expression (flutter/flutter#184830) 2026-04-14 50643541+Mairramer@users.noreply.github.com update popular issues documentation (flutter/flutter#183196) 2026-04-14 43054281+camsim99@users.noreply.github.com [Android] Add integration test for setting engine flags via the manifest (flutter/flutter#182241) 2026-04-14 rmacnak@google.com [fuchsia] Ask for both ambient-replace and VMEX to allow for a softer transition. (flutter/flutter#185042) 2026-04-14 goderbauer@google.com Make `multiple_windows` follow repo analyzer rules (flutter/flutter#184753) 2026-04-14 58529443+srujzs@users.noreply.github.com Ignore incoming deprecated_web_configuration lint (flutter/flutter#184130) 2026-04-14 jesswon@google.com [AGP 9] Update AGP Error (flutter/flutter#185043) 2026-04-14 magder@google.com Move widget_preview_scaffold into pub workspace (flutter/flutter#182627) 2026-04-14 planetmarshall@users.noreply.github.com Fix gles interactive tests (flutter/flutter#181389) 2026-04-14 katelovett@google.com Update customer tests.version (flutter/flutter#185044) 2026-04-14 mdebbar@google.com [SKILL] upgrade-browser (flutter/flutter#184894) 2026-04-14 dacoharkes@google.com [ci] Split up integration.shard dart_data_asset_test.dart (flutter/flutter#185021) 2026-04-14 mr-peipei@web.de Hold startup lock until after `pub get` to prevent races (flutter/flutter#184294) 2026-04-14 6226493+andeart@users.noreply.github.com Add `--include-example` flag to `flutter clean` for package example projects (flutter/flutter#183455) 2026-04-14 15619084+vashworth@users.noreply.github.com Disable multi-pack-index when calling flutter from Xcode (flutter/flutter#184998) 2026-04-14 42123156+nvi9@users.noreply.github.com Fix icon tree shaking when building for desktop (flutter/flutter#184249) 2026-04-14 15619084+vashworth@users.noreply.github.com Fix killing wrong xcrun command (flutter/flutter#184831) 2026-04-14 alex.medinsh@gmail.com Allow Xcode build configuration to not contain flavor name (flutter/flutter#183398) 2026-04-14 mdebbar@google.com [web] Async rendering for benchmarks (flutter/flutter#184677) 2026-04-14 dacoharkes@google.com [ci] Split up integration.shard native_assets_test.dart (flutter/flutter#185020) 2026-04-14 737941+loic-sharma@users.noreply.github.com Skip flutter widget-preview test that times out frequently (flutter/flutter#184988) ...

adds missing awaits on forgotten cases

4a57004

FMorschel requested a review from a team as a code owner March 10, 2026 20:18

github-actions Bot added platform-ios iOS applications specifically tool Affects the "flutter" command-line tool. See also t: labels. framework flutter/packages/flutter repository. See also f: labels. team-ios Owned by iOS platform team labels Mar 10, 2026

gemini-code-assist Bot reviewed Mar 10, 2026

View reviewed changes

removes unnecessary await (diagnostic was incorrect)

c1ba2b7

LouiseHsu previously approved these changes Mar 11, 2026

View reviewed changes

fixed tests expectations

37afd4b

AbdeMohlbi added the CICD Run CI/CD label Mar 12, 2026

FMorschel dismissed LouiseHsu’s stale review via 37afd4b March 12, 2026 22:21

vashworth requested a review from LouiseHsu March 19, 2026 21:48

LouiseHsu reviewed Mar 19, 2026

View reviewed changes

justinmc requested a review from victorsanni March 31, 2026 22:03

victorsanni approved these changes Apr 1, 2026

View reviewed changes

hellohuanlin approved these changes Apr 3, 2026

View reviewed changes

justinmc added the autosubmit Merge PR when tree becomes green via auto submit App label Apr 7, 2026

auto-submit Bot removed the autosubmit Merge PR when tree becomes green via auto submit App label Apr 7, 2026

Merge branch 'master' into await-on-try

d36b096

github-actions Bot removed the CICD Run CI/CD label Apr 9, 2026

victorsanni added the CICD Run CI/CD label Apr 9, 2026

vashworth mentioned this pull request Apr 9, 2026

Google Testing stuck - waiting for PR approval #184846

Closed

4 tasks

Piinks added the autosubmit Merge PR when tree becomes green via auto submit App label Apr 14, 2026

auto-submit Bot added this pull request to the merge queue Apr 14, 2026

Merged via the queue into flutter:master with commit 1ca490e Apr 15, 2026
160 checks passed

flutter-dashboard Bot removed the autosubmit Merge PR when tree becomes green via auto submit App label Apr 15, 2026

engine-flutter-autoroll mentioned this pull request Apr 15, 2026

Roll Flutter from c1b14e92dcfb to 4634b93d8c03 (30 revisions) flutter/packages#11513

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 15, 2026

1ca490e5e Adds missing awaits on forgotten cases (flutter/flutter#1…

6d90ca1

…83466)

engine-flutter-autoroll mentioned this pull request Apr 15, 2026

Roll Flutter from c1b14e92dcfb to ab21ec800abf (31 revisions) flutter/packages#11514

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 15, 2026

1ca490e5e Adds missing awaits on forgotten cases (flutter/flutter#1…

b952c68

…83466)

engine-flutter-autoroll mentioned this pull request Apr 15, 2026

Roll Flutter from c1b14e92dcfb to 6154f7548c56 (32 revisions) flutter/packages#11515

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 15, 2026

1ca490e5e Adds missing awaits on forgotten cases (flutter/flutter#1…

a14d6f6

…83466)

engine-flutter-autoroll mentioned this pull request Apr 16, 2026

Roll Flutter from c1b14e92dcfb to 31f1802cb859 (46 revisions) flutter/packages#11518

Merged

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 16, 2026

1ca490e5e Adds missing awaits on forgotten cases (flutter/flutter#1…

c569747

…83466)

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Adds missing `await`s on forgotten cases#183466

Adds missing `await`s on forgotten cases#183466
auto-submit[bot] merged 4 commits into
flutter:masterfrom
FMorschel:await-on-try

FMorschel commented Mar 10, 2026 •

edited

Loading

Uh oh!

flutter-dashboard Bot commented Mar 10, 2026

Uh oh!

stuartmorgan-g commented Mar 10, 2026

Uh oh!

gemini-code-assist Bot left a comment

Uh oh!

FMorschel commented Mar 13, 2026

Uh oh!

LouiseHsu Mar 19, 2026

Uh oh!

FMorschel Mar 19, 2026

Uh oh!

bkonyi Apr 1, 2026 •

edited

Loading

Uh oh!

auto-submit Bot commented Apr 7, 2026

Uh oh!

Piinks commented Apr 14, 2026

Uh oh!

FMorschel commented Apr 14, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

9 participants

Uh oh!

Conversation

FMorschel commented Mar 10, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Pre-launch Checklist

Uh oh!

flutter-dashboard Bot commented Mar 10, 2026

Uh oh!

stuartmorgan-g commented Mar 10, 2026

Uh oh!

gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

Code Review

Uh oh!

FMorschel commented Mar 13, 2026

Uh oh!

LouiseHsu Mar 19, 2026

Choose a reason for hiding this comment

Uh oh!

FMorschel Mar 19, 2026

Choose a reason for hiding this comment

Uh oh!

bkonyi Apr 1, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

auto-submit Bot commented Apr 7, 2026

Uh oh!

Piinks commented Apr 14, 2026

Uh oh!

FMorschel commented Apr 14, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

9 participants

FMorschel commented Mar 10, 2026 •

edited

Loading

bkonyi Apr 1, 2026 •

edited

Loading