fix(dashboard): mirror code fence lang detection fix from #1661#1677
Merged
Conversation
#1661 fixed the lang-detection bug for desktop only. Dashboard's pre handler has the same `c.type === "code"` check that fails when react-markdown's component override replaces `code` — the element's type is the override function, not the string "code". For dashboard this didn't just mislabel the language; the fallback returned a vanilla `<pre>` and skipped CodeBlock entirely, so syntax highlighting and the copy button were missing for every fenced code block. Extracted the lang lookup into `extractFencedLang` in both files so it can be unit-tested without rendering CodeView (prism-react-renderer pulls in each package's own React copy under vitest, which breaks full-render tests across desktop/dashboard).
esengine
pushed a commit
that referenced
this pull request
May 24, 2026
…moved, persisted usage stats, plan dispatch gate Headline themes: - Desktop: bundle the CLI-hosted React dashboard, retire Tauri+Preact duplicate (#1418) - Config: drop preset abstraction; flash/pro are direct model selections (#1657, #1630) - Stats: persist cumulative usage to session meta + auto-restore on startup (#1667, #1680, #1643, #1628) - Plans: editMode="plan" enforced at the ToolRegistry dispatch gate (#1681); step advance fix (#1629) - Context: fold once at turn start, drop pre-flight + byte-ceiling (#1642, #1646); collapsible compacted card (#1649) - Subagents: per-skill flash/pro override + Settings UI (#1632) - Desktop polish: sidebar drag-resize (#1688), responsive collapse (#1585), copy/edit overlay + msg-history nav (#1645), Esc closes modal not turn (#1685), QQ tab isolation (#1672), DiffCard for edits (#1662), theme-aware highlighting (#1655), system events toggle (#1654/#1650), macOS TCC inheritance (#1614), dashboard.enabled (#1612) - Dashboard polish: persistent session URL (#1586, #1589, #1599), theme-aware highlighting (#1664), IME confirm-enter guard (#1689), code-fence lang fix (#1677), vendor chunk split (#1587), markdown table h-scroll (#1562) - TUI: Alt+S input stash/recall; static history isolated from input rerenders (#1635); legacy mouse drop (#1637, #1648); multi-edit gated in review (#1647) - Diff: SplitDiff column border holds under CJK (#1686) - MCP: workspace roots passed to servers (#1625); codeCommand honors mcpServers (#1603) - Config plumbing: (baseUrl, apiKey) resolved as a tuple (#1658); stale model id self-heal (#1663) See CHANGELOG for the full list.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
#1661 fixed the code-fence lang-detection bug for desktop only. Dashboard's
prehandler had the samec.type === "code"check, which fails when react-markdown's component override replacescode— the element'stypeis the override function, not the string"code".For dashboard this didn't just mislabel the language: the old fallback returned a vanilla
<pre>and skippedCodeBlockentirely, so every fenced code block in the dashboard was rendered without syntax highlighting and without the copy button.Changes
dashboard/src/Markdown.tsx— mirror the desktop fix: readclassNamefrom the first child element instead of relying ontype === "code". Also portflattenChildTextso text extraction matches desktop.desktop/src/Markdown.tsx— extract the lang lookup intoextractFencedLangso it can be unit-tested.tests/markdown-codeblock-lang.test.tsx— new regression test covering both surfaces via the extracted helper.Why a helper instead of rendering through
<Markdown>?CodeViewpulls inprism-react-renderer, which resolves React from each package's ownnode_modules. Under vitest that produces two React copies and breaks hooks (useCallbackis null) for any full-render test of a code block. The pure helper sidesteps that and still proves both surfaces parse the same fenced lang the same way.Verification
npm run verify✅ (3603 passed / 12 skipped, +6 from this PR)