fix(ui): add horizontal scroll for markdown tables#1562
Merged
esengine merged 1 commit intoMay 23, 2026
Conversation
3 tasks
esengine
added a commit
that referenced
this pull request
May 23, 2026
CI's `npm ci` at the root only triggers `npm --prefix dashboard ci`, leaving `desktop/node_modules` empty. Vitest scans `desktop/src/**` for tests, so the first desktop test that imports a transitive dep (e.g. `react-markdown` via `Markdown.tsx`) fails to resolve in CI even though it passes locally for anyone who's ever run `npm install` inside `desktop/`. Unblocks #1562. Co-authored-by: reasonix <reasonix@deepseek.com>
Owner
|
Reopening to re-trigger CI against new main (postinstall fix #1584 just landed). |
Owner
esengine
pushed a commit
that referenced
this pull request
May 24, 2026
…moved, persisted usage stats, plan dispatch gate Headline themes: - Desktop: bundle the CLI-hosted React dashboard, retire Tauri+Preact duplicate (#1418) - Config: drop preset abstraction; flash/pro are direct model selections (#1657, #1630) - Stats: persist cumulative usage to session meta + auto-restore on startup (#1667, #1680, #1643, #1628) - Plans: editMode="plan" enforced at the ToolRegistry dispatch gate (#1681); step advance fix (#1629) - Context: fold once at turn start, drop pre-flight + byte-ceiling (#1642, #1646); collapsible compacted card (#1649) - Subagents: per-skill flash/pro override + Settings UI (#1632) - Desktop polish: sidebar drag-resize (#1688), responsive collapse (#1585), copy/edit overlay + msg-history nav (#1645), Esc closes modal not turn (#1685), QQ tab isolation (#1672), DiffCard for edits (#1662), theme-aware highlighting (#1655), system events toggle (#1654/#1650), macOS TCC inheritance (#1614), dashboard.enabled (#1612) - Dashboard polish: persistent session URL (#1586, #1589, #1599), theme-aware highlighting (#1664), IME confirm-enter guard (#1689), code-fence lang fix (#1677), vendor chunk split (#1587), markdown table h-scroll (#1562) - TUI: Alt+S input stash/recall; static history isolated from input rerenders (#1635); legacy mouse drop (#1637, #1648); multi-edit gated in review (#1647) - Diff: SplitDiff column border holds under CJK (#1686) - MCP: workspace roots passed to servers (#1625); codeCommand honors mcpServers (#1603) - Config plumbing: (baseUrl, apiKey) resolved as a tuple (#1658); stale model id self-heal (#1663) See CHANGELOG for the full list.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Add horizontal scrolling for wide Markdown tables in the desktop chat UI, and slightly widen the table viewport so wide tables are easier to read without affecting normal message layout.
Problem
When Reasonix renders Markdown tables with many columns or long cell content, the table can exceed the visible chat width. The chat container hides horizontal overflow, and the table had no dedicated scroll wrapper, so the right side of the table was clipped and could not be viewed.
The issue is in the desktop Markdown rendering path:
desktop/src/ui/cards.tsxrenders assistant text throughMarkdowndesktop/src/Markdown.tsxrenders GFM tables directlydesktop/src/styles.cssonly had general table styling, with no horizontal scroll containerFix
desktop/src/Markdown.tsx— Added a customtablerenderer that wraps Markdown tables in a.markdown-table-wrapcontainer.desktop/src/styles.css— Added horizontal scrolling to.markdown-table-wrap, and widened the wrapper slightly with negative side margins so wide tables have a bit more usable horizontal space.desktop/src/Markdown.test.tsx— Added a regression test that verifies Markdown tables are rendered inside the scroll container.Verification
npx vitest run desktop/src/Markdown.test.tsxnpx vitest run desktop/src/Markdown.test.tsx desktop/src/ui/thread.test.tsxnpx tsc --noEmit -p desktopgit diff --checknpm run verifyClosed #1463