Skip to content

test(tui): cover legacy mouse-report flood#1648

Merged
esengine merged 1 commit into
esengine:mainfrom
GTC2080:GTC/fix-1598-windows-tui-memory
May 24, 2026
Merged

test(tui): cover legacy mouse-report flood#1648
esengine merged 1 commit into
esengine:mainfrom
GTC2080:GTC/fix-1598-windows-tui-memory

Conversation

@GTC2080

@GTC2080 GTC2080 commented May 24, 2026

Copy link
Copy Markdown
Contributor

Summary

  • Adds direct regression coverage for the Windows/PowerShell memory-growth failure mode reported in 内存泄漏 #1598.
  • Exercises a flood of legacy X10 mouse reports and asserts the stdin reader drops them instead of surfacing coordinate bytes as prompt input.

Relationship to the production fix

The production fix is already merged in #1637, which resets legacy mouse modes and consumes complete ESC [ M ... mouse-report packets. This PR intentionally does not add another production change; it only keeps the #1598 failure mode covered by a focused regression test.

Refs #1598

Validation

  • npm test -- --run tests/stdin-reader.test.ts tests/mouse-mode.test.ts
  • npx biome check tests/stdin-reader.test.ts tests/mouse-mode.test.ts
  • npm run verify via pre-push hook: 261 test files passed; 3593 tests passed; 12 skipped. Biome reported two existing unused-suppression warnings outside this change.

@GTC2080 GTC2080 mentioned this pull request May 24, 2026
@GTC2080 GTC2080 marked this pull request as ready for review May 24, 2026 04:04
@esengine esengine merged commit 5116d11 into esengine:main May 24, 2026
4 checks passed
esengine pushed a commit that referenced this pull request May 24, 2026
…moved, persisted usage stats, plan dispatch gate

Headline themes:
- Desktop: bundle the CLI-hosted React dashboard, retire Tauri+Preact duplicate (#1418)
- Config: drop preset abstraction; flash/pro are direct model selections (#1657, #1630)
- Stats: persist cumulative usage to session meta + auto-restore on startup (#1667, #1680, #1643, #1628)
- Plans: editMode="plan" enforced at the ToolRegistry dispatch gate (#1681); step advance fix (#1629)
- Context: fold once at turn start, drop pre-flight + byte-ceiling (#1642, #1646); collapsible compacted card (#1649)
- Subagents: per-skill flash/pro override + Settings UI (#1632)
- Desktop polish: sidebar drag-resize (#1688), responsive collapse (#1585), copy/edit overlay + msg-history nav (#1645), Esc closes modal not turn (#1685), QQ tab isolation (#1672), DiffCard for edits (#1662), theme-aware highlighting (#1655), system events toggle (#1654/#1650), macOS TCC inheritance (#1614), dashboard.enabled (#1612)
- Dashboard polish: persistent session URL (#1586, #1589, #1599), theme-aware highlighting (#1664), IME confirm-enter guard (#1689), code-fence lang fix (#1677), vendor chunk split (#1587), markdown table h-scroll (#1562)
- TUI: Alt+S input stash/recall; static history isolated from input rerenders (#1635); legacy mouse drop (#1637, #1648); multi-edit gated in review (#1647)
- Diff: SplitDiff column border holds under CJK (#1686)
- MCP: workspace roots passed to servers (#1625); codeCommand honors mcpServers (#1603)
- Config plumbing: (baseUrl, apiKey) resolved as a tuple (#1658); stale model id self-heal (#1663)

See CHANGELOG for the full list.
@GTC2080 GTC2080 deleted the GTC/fix-1598-windows-tui-memory branch May 31, 2026 10:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants