feat(desktop): copy/edit overlay, msg history nav, IME guard, card collapse#1645
Merged
esengine merged 2 commits intoMay 24, 2026
Merged
Conversation
esengine
requested changes
May 24, 2026
esengine
left a comment
Owner
There was a problem hiding this comment.
Thanks for the comprehensive pass — the Markdown v9 fix, the IME composition guard, and the Node threshold are all solid catches.
One blocker before this can land:
Arrow-key history nav clobbers cursor movement in multi-line drafts. In composer.tsx the handler intercepts every ArrowUp/ArrowDown whenever no popup is open, so a user writing a long message who hits ↑ to move the cursor up a line will instead see their entire draft replaced by a prior message. That's a real regression on the most common editing path.
The typical fix is to only navigate history when the action is unambiguous:
- textarea is empty, OR
- cursor is on the first line (for ↑) / last line (for ↓), OR
- modifier-gated (
Cmd+↑/Ctrl+↑)
A few other things to address before merge:
- CI hasn't run yet — the
action_requiredstatus is GitHub's first-contributor gate. Once the cursor regression is fixed I'll approve the workflow run. - Tests are missing for every new behavior (history nav, IME guard,
flattenChildText, edit-button wiring). 147 lines of behavior change with zero coverage is a real gap — small vitest cases on the pure helpers would have caught the cursor regression above. ReasoningCard defaultOpen={false}changes streaming visibility (was open while streaming, now collapsed). Confirm this is intentional — some users rely on seeing the reasoning land live.
The bundling (7 unrelated fixes in one PR) is fine for this round, but please split future ones — Rust threshold, Markdown fix, and the UX changes each belong in their own PR.
Once the cursor issue is fixed, push and I'll approve CI.
…g open while streaming
Owner
|
Nice first PR — solid bundle of real fixes (the arm64 Homebrew Node detection and the IME guard in particular). Merging. |
4 tasks
esengine
added a commit
that referenced
this pull request
May 24, 2026
#1651) * chore(desktop): tidy follow-ups from #1645 Three small cleanups landed alongside the desktop UX bundle: - composer: extract `recordSendAndReset` so the history-push + browse- index reset logic is one helper, not duplicated between the Enter key path and the send-button onClick. - composer: drop the duplicate IME-quirk comment at the use site; the ref declaration block at the top of the component already documents the macOS Chinese IME ordering quirk. - App: hoist the inline `onEdit` arrow into a useCallback so UserMsg's memo isn't busted by a fresh function identity on every render of the message list. * test(server-dashboard): isolate from real \$HOME/.reasonix The v0.13 panels suite uses mkdtempSync for cfgPath and usagePath but the handlers it exercises (/api/health, listSessions) still call homedir() under the hood. On a dev machine with thousands of session jsonl files in ~/.reasonix/sessions the readdir + per-file statSync walk blows past the 5 s default test timeout, even though the same test runs in ms on a clean CI box. Redirect HOME and USERPROFILE inside the suite's beforeEach so the walks land in the suite's already-empty temp dir, and restore the originals in afterEach. No production-code change — the handlers' homedir() coupling is a separate cleanup. Whole file now runs in 1.7 s. --------- Co-authored-by: reasonix <reasonix@deepseek.com>
esengine
pushed a commit
that referenced
this pull request
May 24, 2026
…moved, persisted usage stats, plan dispatch gate Headline themes: - Desktop: bundle the CLI-hosted React dashboard, retire Tauri+Preact duplicate (#1418) - Config: drop preset abstraction; flash/pro are direct model selections (#1657, #1630) - Stats: persist cumulative usage to session meta + auto-restore on startup (#1667, #1680, #1643, #1628) - Plans: editMode="plan" enforced at the ToolRegistry dispatch gate (#1681); step advance fix (#1629) - Context: fold once at turn start, drop pre-flight + byte-ceiling (#1642, #1646); collapsible compacted card (#1649) - Subagents: per-skill flash/pro override + Settings UI (#1632) - Desktop polish: sidebar drag-resize (#1688), responsive collapse (#1585), copy/edit overlay + msg-history nav (#1645), Esc closes modal not turn (#1685), QQ tab isolation (#1672), DiffCard for edits (#1662), theme-aware highlighting (#1655), system events toggle (#1654/#1650), macOS TCC inheritance (#1614), dashboard.enabled (#1612) - Dashboard polish: persistent session URL (#1586, #1589, #1599), theme-aware highlighting (#1664), IME confirm-enter guard (#1689), code-fence lang fix (#1677), vendor chunk split (#1587), markdown table h-scroll (#1562) - TUI: Alt+S input stash/recall; static history isolated from input rerenders (#1635); legacy mouse drop (#1637, #1648); multi-edit gated in review (#1647) - Diff: SplitDiff column border holds under CJK (#1686) - MCP: workspace roots passed to servers (#1625); codeCommand honors mcpServers (#1603) - Config plumbing: (baseUrl, apiKey) resolved as a tuple (#1658); stale model id self-heal (#1663) See CHANGELOG for the full list.
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Desktop UX improvements addressing daily pain points.
Motivation
Several issues noticed during daily desktop usage:
Changes
Verification