Skip to content

fix(ui): advance active plan steps#1629

Merged
esengine merged 1 commit into
esengine:mainfrom
GTC2080:GTC/fix-1441-plan-step-refresh
May 23, 2026
Merged

fix(ui): advance active plan steps#1629
esengine merged 1 commit into
esengine:mainfrom
GTC2080:GTC/fix-1441-plan-step-refresh

Conversation

@GTC2080

@GTC2080 GTC2080 commented May 23, 2026

Copy link
Copy Markdown
Contributor

What

Keep the active plan card current-step state in sync by setting the first unfinished active step to running when the plan is shown and after each plan.step.complete update.

Why

Fixes #1441. Active plan cards store explicit step statuses, but new plans were initialized with every step queued and completion updates only marked the target step done, leaving later steps displayed as queued instead of advancing the live progress indicator.

How to verify

  • npm test -- tests/ui-reducer.test.ts
  • npm test -- tests/ui-reducer.test.ts tests/handle-tool-event.test.ts tests/turn-translator.test.ts
  • npm run typecheck
  • npm run verify

Checklist

  • npm run verify passes locally (lint + typecheck + tests + comment-policy gate)
  • No Co-Authored-By: Claude trailer in commits
  • Comments follow CONTRIBUTING.md (no module-essay headers, no incident history)
  • No edits to CHANGELOG.md — release notes are maintainer-written at release time

@GTC2080 GTC2080 mentioned this pull request May 23, 2026
Closed
@esengine

esengine commented May 23, 2026

Copy link
Copy Markdown
Owner

Solid fix — advanceActivePlanSteps keeps settled steps untouched and preserves object identity when status doesn't change (so React doesn't re-render unchanged step rows). The test walks the right shape: initial [queued, queued, queued] becomes [running, queued, queued] on plan.show, then advances the cursor on each plan.step.complete. One blocker before merge: same drift pattern hitting today's PRs.

Drift

git diff origin/main..HEAD shows two extra files that aren't part of your fix:

src/cli/ui/PromptInput.tsx     |  6 +++---
src/cli/ui/cards/UserCard.tsx  |  2 +-

The change flips TONE.brand / SURFACE.bgInput back to hardcoded #0153e5 / #1e1e1e — that's #1623 (light-theme composer bg) which merged earlier today. GH says mergeStateStatus: CLEAN because git's 3-way merge sees absence-of-lines as deletion against main's additions; there are no textual conflicts to flag. Semantically merging this would undo the light-theme fix.

What to do

git fetch origin main && git rebase origin/main — your diff should narrow back to src/cli/ui/state/reducer.ts + tests/ui-reducer.test.ts. The PromptInput.tsx and UserCard.tsx lines should disappear from the diff entirely after rebase.

Same advice for #1624 and #1625 — once all three are rebased I'll merge them in order.

@GTC2080 GTC2080 force-pushed the GTC/fix-1441-plan-step-refresh branch from 0a1b3a9 to e2fa5ee Compare May 23, 2026 14:54
@esengine esengine merged commit 12a9a51 into esengine:main May 23, 2026
4 checks passed
esengine pushed a commit that referenced this pull request May 24, 2026
chore(release): 0.50.0 — CLI-hosted dashboard for desktop, presets re…
28d9505 
…moved, persisted usage stats, plan dispatch gate

Headline themes:
- Desktop: bundle the CLI-hosted React dashboard, retire Tauri+Preact duplicate (#1418)
- Config: drop preset abstraction; flash/pro are direct model selections (#1657, #1630)
- Stats: persist cumulative usage to session meta + auto-restore on startup (#1667, #1680, #1643, #1628)
- Plans: editMode="plan" enforced at the ToolRegistry dispatch gate (#1681); step advance fix (#1629)
- Context: fold once at turn start, drop pre-flight + byte-ceiling (#1642, #1646); collapsible compacted card (#1649)
- Subagents: per-skill flash/pro override + Settings UI (#1632)
- Desktop polish: sidebar drag-resize (#1688), responsive collapse (#1585), copy/edit overlay + msg-history nav (#1645), Esc closes modal not turn (#1685), QQ tab isolation (#1672), DiffCard for edits (#1662), theme-aware highlighting (#1655), system events toggle (#1654/#1650), macOS TCC inheritance (#1614), dashboard.enabled (#1612)
- Dashboard polish: persistent session URL (#1586, #1589, #1599), theme-aware highlighting (#1664), IME confirm-enter guard (#1689), code-fence lang fix (#1677), vendor chunk split (#1587), markdown table h-scroll (#1562)
- TUI: Alt+S input stash/recall; static history isolated from input rerenders (#1635); legacy mouse drop (#1637, #1648); multi-edit gated in review (#1647)
- Diff: SplitDiff column border holds under CJK (#1686)
- MCP: workspace roots passed to servers (#1625); codeCommand honors mcpServers (#1603)
- Config plumbing: (baseUrl, apiKey) resolved as a tuple (#1658); stale model id self-heal (#1663)

See CHANGELOG for the full list.
@GTC2080 GTC2080 deleted the GTC/fix-1441-plan-step-refresh branch May 31, 2026 10:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

bug: submit_plan 的步骤状态在 UI 中不随 mark_step_complete 更新

2 participants

@GTC2080 @esengine