docs: adds information about the Envoy tracer from Instana #6371#6416
Merged
mattklein123 merged 2 commits intoenvoyproxy:masterfrom Mar 28, 2019
noctarius:instana-docs
Merged
docs: adds information about the Envoy tracer from Instana #6371#6416mattklein123 merged 2 commits intoenvoyproxy:masterfrom noctarius:instana-docs
mattklein123 merged 2 commits intoenvoyproxy:masterfrom
noctarius:instana-docs
Conversation
…lly hosted tracer plugins Signed-off-by: Christoph Engelbert <me@noctarius.com>
mattklein123
requested changes
Mar 28, 2019
Member
mattklein123
left a comment
There was a problem hiding this comment.
LGTM, with CI fix needed. Thanks!
/wait
| be used to join untrusted request IDs to the trusted internal | ||
| :ref:`config_http_conn_man_headers_x-request-id`. | ||
| * **External trace service integration**: Envoy supports pluggable external trace visualization | ||
| providers, that are devided into two subgroups: |
Member
There was a problem hiding this comment.
typo "devided" (not sure if this is format error, please check.)
Contributor
Author
There was a problem hiding this comment.
no format error, otherwise it didn't render correctly (at least not in Github)
Signed-off-by: Christoph Engelbert <me@noctarius.com>
spenceral
added a commit
to spenceral/envoy
that referenced
this pull request
Mar 29, 2019
* master: router: support prefix wildcards in virtual hosts domains (envoyproxy#6303) security: update distributor application example to include e-mail. (envoyproxy#6425) Examples: Update gen script of grpc example service (envoyproxy#6372) config: de-templatize source/common/config (envoyproxy#6391) docs: adds information about the Envoy tracer from Instana envoyproxy#6371 (envoyproxy#6416) test: convert ratelimit test configs to v2 YAML (envoyproxy#6411) include required python and go dependencies for grpc-bridge example (envoyproxy#6402) docs: more snapping fixes (envoyproxy#6404) runtime: switching from unordered_map to absl::flat_hash_map (envoyproxy#6389)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description: This PR adds the information for the Envoy tracer from Instana and also the HTTP headers being used to capture traces and spans. The information are written in the same way as for Zipkin, Datadog and others.
Risk Level: Low
Testing: n/a, doc change only
Docs Changes: See above, only doc change
Release Notes: no impact on users, no necessity to be mentioned in the release notes
PS: @mattklein123 I messed up the force push and deleted the old branch (which automatically closed the old pull request #6371) :(