docs: adds information about the Envoy tracer from Instana#6371
docs: adds information about the Envoy tracer from Instana#6371noctarius wants to merge 4 commits intoenvoyproxy:masterfrom noctarius:docs-instana
Conversation
Signed-off-by: noctarius <me@noctarius.com>
Signed-off-by: noctarius <me@noctarius.com>
Signed-off-by: noctarius <me@noctarius.com>
Signed-off-by: noctarius <me@noctarius.com>
|
@noctarius thanks for the contribution, but as this is an extension that isn't in the repo, I'm not sure these headers belong in the public docs. Can you potentially provide some more context on this PR? /wait-any |
|
@mattklein123 thank you for taking the time to look into it. I'm looking into to make sure, people understand what options they have when monitoring Envoy (and with that Istio too), and there's not only one commercial vendor to support it. I saw that all the other tracer extensions are part of the Envoy code base, but I wonder if that's a requirement. We provide the ready to use extension and otherwise work the same way as any bundled extension. A quick insight into how to use the Instana Envoy sensor is here: https://www.instana.com/blog/monitoring-envoy-proxy-microservices/ I hope this is a meaningful request and you understand our reasoning. If I can provide more insight oder add more content to make the request worthwhile, I'm happy to do this. |
|
@noctarius given that this filter is not in the repo, I'm not sure it makes sense to fully document the headers. What about something like the following:
WDYT? /wait |
|
Hey Matt, thank you very much for the help, I love the idea. I actually only added the headers since just a name and link didn't seem any meaningful to me, however reworking the page a bit makes sense. Is that about what you meant with changing the tracing page? https://github.com/noctarius/envoy/blob/instana-docs/docs/root/intro/arch_overview/tracing.rst On the other side, I couldn't find any way to change the website, therefore I think I'd offer a logo and you would add it into the community page you mentioned? |
|
@noctarius the website code is here: https://github.com/envoyproxy/envoyproxy.github.io. Feel free to do a direct PR to that repo for your proposed changes. cc @lucperkins @caniszczyk |
|
@noctarius that change to the tracing docs generally LGTM. If you want to update the PR we can discuss during code review. |
* master: router: support prefix wildcards in virtual hosts domains (envoyproxy#6303) security: update distributor application example to include e-mail. (envoyproxy#6425) Examples: Update gen script of grpc example service (envoyproxy#6372) config: de-templatize source/common/config (envoyproxy#6391) docs: adds information about the Envoy tracer from Instana envoyproxy#6371 (envoyproxy#6416) test: convert ratelimit test configs to v2 YAML (envoyproxy#6411) include required python and go dependencies for grpc-bridge example (envoyproxy#6402) docs: more snapping fixes (envoyproxy#6404) runtime: switching from unordered_map to absl::flat_hash_map (envoyproxy#6389)
Description: This PR adds the information for the Envoy tracer from Instana and also the HTTP headers being used to capture traces and spans. The information are written in the same way as for Zipkin, Datadog and others.
Risk Level: Low
Testing: n/a, doc change only
Docs Changes: See above, only doc change
Release Notes: no impact on users, no necessity to be mentioned in the release notes
PS: I hope this change is done according to the contributions best practices. If I missed anything, just let me know, happy to fix it.