runtime: switching from unordered_map to absl::flat_hash_map#6389
Merged
lizan merged 3 commits intoenvoyproxy:masterfrom Mar 28, 2019
Merged
runtime: switching from unordered_map to absl::flat_hash_map#6389lizan merged 3 commits intoenvoyproxy:masterfrom
lizan merged 3 commits intoenvoyproxy:masterfrom
Conversation
Signed-off-by: Alyssa Wilk <alyssar@chromium.org>
include/envoy/runtime/runtime.h
Outdated
|
|
||
| /** | ||
| * @return const std::unordered_map<std::string, Entry>& the values in this layer. | ||
| * @return const absl::flat_hash_ma<std::string, Entry>& the values in this layer. |
Member
There was a problem hiding this comment.
s/flat_hash_ma/flat_hash_map
venilnoronha
previously approved these changes
Mar 26, 2019
lizan
reviewed
Mar 26, 2019
test/mocks/runtime/mocks.h
Outdated
|
|
||
| MOCK_CONST_METHOD1(deprecatedFeatureEnabled, bool(const std::string& key)); | ||
| MOCK_CONST_METHOD1(runtimeFeatureEnabled, bool(const std::string& key)); | ||
| MOCK_CONST_METHOD1(runtimeFeatureEnabled, bool(const absl::string_view key)); |
Member
There was a problem hiding this comment.
no top-level const parameter (which has no effect on signature so compiler doesn't complain)
lizan
approved these changes
Mar 28, 2019
spenceral
added a commit
to spenceral/envoy
that referenced
this pull request
Mar 29, 2019
* master: router: support prefix wildcards in virtual hosts domains (envoyproxy#6303) security: update distributor application example to include e-mail. (envoyproxy#6425) Examples: Update gen script of grpc example service (envoyproxy#6372) config: de-templatize source/common/config (envoyproxy#6391) docs: adds information about the Envoy tracer from Instana envoyproxy#6371 (envoyproxy#6416) test: convert ratelimit test configs to v2 YAML (envoyproxy#6411) include required python and go dependencies for grpc-bridge example (envoyproxy#6402) docs: more snapping fixes (envoyproxy#6404) runtime: switching from unordered_map to absl::flat_hash_map (envoyproxy#6389)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This allows us to move the new runtime APIs over to string_view without taking a string-serialization performance hit.
see https://abseil.io/docs/cpp/guides/container for flat_hash_map being a unordered_map replacement with heterogeneous lookup for string_view.
Risk Level: Medium (swapping the underlying internals of runtime)
Testing: existing tests pass
Docs Changes: no
Release Notes: no