Skip to content

Examples: Update gen script of grpc example service#6372

Merged
mattklein123 merged 5 commits intoenvoyproxy:masterfrom
a0p00d:example-grpc
Mar 29, 2019
Merged

Examples: Update gen script of grpc example service#6372
mattklein123 merged 5 commits intoenvoyproxy:masterfrom
a0p00d:example-grpc

Conversation

@a0p00d
Copy link
Copy Markdown
Contributor

@a0p00d a0p00d commented Mar 25, 2019

Signed-off-by: neilhong neilhong1206@gmail.com

Description: fix the outdate gen script of grpc-bridge example
Risk Level: Low
Testing: n/a
Docs Changes: n/a
Release Notes: n/a

a0p00d added 3 commits March 25, 2019 20:51
Signed-off-by: neilhong <neilhong1206@gmail.com>
Signed-off-by: neilhong <neilhong1206@gmail.com>
Signed-off-by: neilhong <neilhong1206@gmail.com>
@lizan lizan self-assigned this Mar 25, 2019
@lizan
Copy link
Copy Markdown
Member

lizan commented Mar 27, 2019

Can you fix the CI?

/wait

Signed-off-by: neilhong <neilhong1206@gmail.com>
Signed-off-by: neilhong <neilhong1206@gmail.com>
@a0p00d
Copy link
Copy Markdown
Contributor Author

a0p00d commented Mar 29, 2019

Can you fix the CI?

/wait

Hi, the CI fail fixed now.
the PR is about a typo in grpc bridge example scripts, has nothing to do with the CI flow, seems that the CI workflow will fail frequently.

Copy link
Copy Markdown
Member

@mattklein123 mattklein123 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@mattklein123 mattklein123 merged commit f822a77 into envoyproxy:master Mar 29, 2019
spenceral added a commit to spenceral/envoy that referenced this pull request Mar 29, 2019
* master:
  router: support prefix wildcards in virtual hosts domains (envoyproxy#6303)
  security: update distributor application example to include e-mail. (envoyproxy#6425)
  Examples: Update gen script of grpc example service (envoyproxy#6372)
  config: de-templatize source/common/config (envoyproxy#6391)
  docs: adds information about the Envoy tracer from Instana envoyproxy#6371 (envoyproxy#6416)
  test: convert ratelimit test configs to v2 YAML (envoyproxy#6411)
  include required python and go dependencies for grpc-bridge example (envoyproxy#6402)
  docs: more snapping fixes (envoyproxy#6404)
  runtime: switching from unordered_map to absl::flat_hash_map (envoyproxy#6389)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants