include required python and go dependencies for grpc-bridge example#6402
Merged
mattklein123 merged 2 commits intoenvoyproxy:masterfrom Mar 28, 2019
alaiacano:alaiacano/grpc-bridge-setup
Merged
include required python and go dependencies for grpc-bridge example#6402mattklein123 merged 2 commits intoenvoyproxy:masterfrom alaiacano:alaiacano/grpc-bridge-setup
mattklein123 merged 2 commits intoenvoyproxy:masterfrom
alaiacano:alaiacano/grpc-bridge-setup
Conversation
Signed-off-by: Adam Laiacano <adam.laiacano@gmail.com> Signed-off-by: Adam Laiacano <adam.laiacano@gmail.com>
mattklein123
previously approved these changes
Mar 27, 2019
Member
mattklein123
left a comment
There was a problem hiding this comment.
Thank you! @moderation does this look OK to you?
Signed-off-by: Adam Laiacano <adam.laiacano@gmail.com>
Contributor
Author
|
I noticed the reason this probably worked within the docker container but not when I was fiddling around with the client code locally - it wasn't actually installing from |
Contributor
|
LGTM |
spenceral
added a commit
to spenceral/envoy
that referenced
this pull request
Mar 29, 2019
* master: router: support prefix wildcards in virtual hosts domains (envoyproxy#6303) security: update distributor application example to include e-mail. (envoyproxy#6425) Examples: Update gen script of grpc example service (envoyproxy#6372) config: de-templatize source/common/config (envoyproxy#6391) docs: adds information about the Envoy tracer from Instana envoyproxy#6371 (envoyproxy#6416) test: convert ratelimit test configs to v2 YAML (envoyproxy#6411) include required python and go dependencies for grpc-bridge example (envoyproxy#6402) docs: more snapping fixes (envoyproxy#6404) runtime: switching from unordered_map to absl::flat_hash_map (envoyproxy#6389)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I followed the guide for the
grpc-bridgeexample at https://www.envoyproxy.io/docs/envoy/latest/start/sandboxes/grpc_bridge and came into some problems with missing dependencies. The tweaks to the example are:protobufpython package so thatkv_pb2.pyworksgolang.org/x/sys/unixgo package so thatscript/buildworks/usr/bin/env pythoninstead of system default (so that virtual environments work)Risk Level: Low
Testing: n/a
Docs Changes: n/a
Release Notes: n/a