test: convert ratelimit test configs to v2 YAML#6411
Merged
mattklein123 merged 1 commit intoenvoyproxy:masterfrom Mar 28, 2019
Merged
test: convert ratelimit test configs to v2 YAML#6411mattklein123 merged 1 commit intoenvoyproxy:masterfrom
mattklein123 merged 1 commit intoenvoyproxy:masterfrom
Conversation
Signed-off-by: Derek Argueta <dereka@pinterest.com>
mattklein123
approved these changes
Mar 28, 2019
| envoy::api::v2::route::RateLimit rate_limit; | ||
| auto json_object_ptr = Json::Factory::loadFromString(json_string); | ||
| Envoy::Config::RdsJson::translateRateLimit(*json_object_ptr, rate_limit); | ||
| MessageUtil::loadFromYaml(yaml_string, rate_limit); |
Member
There was a problem hiding this comment.
not an issue for this PR, but there is a combined function that does both load and validate. Maybe use that in the future?
Member
Author
There was a problem hiding this comment.
ah, loadFromYamlAndValidate. Noted.
spenceral
added a commit
to spenceral/envoy
that referenced
this pull request
Mar 29, 2019
* master: router: support prefix wildcards in virtual hosts domains (envoyproxy#6303) security: update distributor application example to include e-mail. (envoyproxy#6425) Examples: Update gen script of grpc example service (envoyproxy#6372) config: de-templatize source/common/config (envoyproxy#6391) docs: adds information about the Envoy tracer from Instana envoyproxy#6371 (envoyproxy#6416) test: convert ratelimit test configs to v2 YAML (envoyproxy#6411) include required python and go dependencies for grpc-bridge example (envoyproxy#6402) docs: more snapping fixes (envoyproxy#6404) runtime: switching from unordered_map to absl::flat_hash_map (envoyproxy#6389)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description: Another PR towards #6362
Risk Level: Low - no functional change
Docs Changes: N/A
Release Notes: N/A
Signed-off-by: Derek Argueta dereka@pinterest.com