opentelemetrytracer: Allow sampler to set variant type span attribute…#32681
Merged
wbpcode merged 5 commits intoenvoyproxy:mainfrom Mar 7, 2024
Merged
Conversation
#20) Allow sampler to set variant type span attributes. Signed-off-by: thomas.ebner <thomas.ebner@dynatrace.com>
6d3bf53 to
5426b12
Compare
Signed-off-by: thomas.ebner <thomas.ebner@dynatrace.com>
Contributor
|
CC @wbpcode some quality of life improvement :) |
wbpcode
reviewed
Mar 6, 2024
Member
wbpcode
left a comment
There was a problem hiding this comment.
LGTM overall with some minor comments. Thanks for your contributions.
Signed-off-by: thomas.ebner <thomas.ebner@dynatrace.com>
…argument-type - move Otel types to otlp_utils.h to solve dependency problem Signed-off-by: thomas.ebner <thomas.ebner@dynatrace.com>
Signed-off-by: thomas.ebner <thomas.ebner@dynatrace.com>
Contributor
Author
|
I have addressed the review comments and resolved the merge conflicts. PR should be ready for another review. |
wbpcode
approved these changes
Mar 7, 2024
mattjo
added a commit
to mattjo/envoy
that referenced
this pull request
Mar 7, 2024
* origin: mobile: Clean up Java and Kotlin code (envoyproxy#32773) [mobile] Increase stream response buffer watermark size to 2MB (envoyproxy#32754) oauth2: support disabling redirects for AJAX requests (envoyproxy#32655) http2: Switch the value of envoy.reloadable_features.http2_use_oghttp2 to false (envoyproxy#32751) envoy: reverting unnecessary exception E-M macros (envoyproxy#32745) dfp: reverting 31433 (envoyproxy#32743) opentelemetrytracer: Allow sampler to set variant type span attribute… (envoyproxy#32681) mobile: Java code cleanup (envoyproxy#32747) mobile: fix quic_test_server_test (envoyproxy#32755) Common TunnelResponseHeadersOrTrailers for UDP & TCP tunneling (envoyproxy#32619)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Commit Message: Allow sampler to set variant type span attributes
Additional Description: The opentelemetry sampler interface allows a sampler to add span attributes. The current Envoy implementation has the limitation that only string attributes are allowed.
In #32333 a dependency to Otel C++ API was added. This enables us to use the same type for attributes as Otel C++ SDK does.
Risk Level:
Testing: Unit, Integration, Manual
Docs Changes: N/A
Release Notes: Allow sampler to set variant type span attributes
Platform Specific Features: N/A
[Optional Runtime guard:] N/A
[Optional Fixes #Issue]
[Optional Fixes commit #PR or SHA]
[Optional Deprecated:]
[Optional API Considerations:]