Skip to content

Common TunnelResponseHeadersOrTrailers for UDP & TCP tunneling#32619

Merged
kyessenov merged 2 commits intoenvoyproxy:mainfrom
IssaAbuKalbein:common_tunnel_response_headers_or_trailers
Mar 6, 2024
Merged

Common TunnelResponseHeadersOrTrailers for UDP & TCP tunneling#32619
kyessenov merged 2 commits intoenvoyproxy:mainfrom
IssaAbuKalbein:common_tunnel_response_headers_or_trailers

Conversation

@IssaAbuKalbein
Copy link
Copy Markdown
Contributor

Commit Message: Common TunnelResponseHeadersOrTrailers for UDP & TCP tunneling
Additional Description:
Risk Level: low
Testing:
Docs Changes: N/A
Release Notes: N/A
Platform Specific Features: None

Signed-off-by: IssaAbuKalbein <isaqalbein@gmail.com>
@repokitteh-read-only
Copy link
Copy Markdown

As a reminder, PRs marked as draft will not be automatically assigned reviewers,
or be handled by maintainer-oncall triage.

Please mark your PR as ready when you want it to be reviewed!

🐱

Caused by: #32619 was opened by IssaAbuKalbein.

see: more, trace.

@IssaAbuKalbein IssaAbuKalbein marked this pull request as ready for review February 28, 2024 16:04
@IssaAbuKalbein
Copy link
Copy Markdown
Contributor Author

/retest

@IssaAbuKalbein
Copy link
Copy Markdown
Contributor Author

@kyessenov Could you, please, take a look as you've created this object in tcp tunneling: optionally move response header to downstream info

@KBaichoo
Copy link
Copy Markdown
Contributor

KBaichoo commented Mar 5, 2024

friendly ping @kyessenov

Signed-off-by: IssaAbuKalbein <isaqalbein@gmail.com>
@IssaAbuKalbein
Copy link
Copy Markdown
Contributor Author

/retest

@IssaAbuKalbein IssaAbuKalbein requested a review from kyessenov March 6, 2024 14:47
Copy link
Copy Markdown
Contributor

@kyessenov kyessenov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@kyessenov kyessenov merged commit a19dce3 into envoyproxy:main Mar 6, 2024
@IssaAbuKalbein IssaAbuKalbein deleted the common_tunnel_response_headers_or_trailers branch March 6, 2024 22:28
mattjo added a commit to mattjo/envoy that referenced this pull request Mar 7, 2024
* origin:
  mobile: Clean up Java and Kotlin code (envoyproxy#32773)
  [mobile] Increase stream response buffer watermark size to 2MB (envoyproxy#32754)
  oauth2: support disabling redirects for AJAX requests (envoyproxy#32655)
  http2: Switch the value of envoy.reloadable_features.http2_use_oghttp2 to false (envoyproxy#32751)
  envoy: reverting unnecessary exception E-M macros (envoyproxy#32745)
  dfp: reverting 31433 (envoyproxy#32743)
  opentelemetrytracer: Allow sampler to set variant type span attribute… (envoyproxy#32681)
  mobile: Java code cleanup (envoyproxy#32747)
  mobile: fix quic_test_server_test (envoyproxy#32755)
  Common TunnelResponseHeadersOrTrailers for UDP & TCP tunneling (envoyproxy#32619)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants