Skip to content

envoy: reverting unnecessary E-M macro#32745

Merged
alyssawilk merged 2 commits intoenvoyproxy:mainfrom
alyssawilk:rest
Mar 7, 2024
Merged

envoy: reverting unnecessary E-M macro#32745
alyssawilk merged 2 commits intoenvoyproxy:mainfrom
alyssawilk:rest

Conversation

@alyssawilk
Copy link
Copy Markdown
Contributor

@alyssawilk alyssawilk commented Mar 6, 2024

removing a few throwEnvoyExceptionOrPanic not needed by E-M

Commit Message:
Additional Description:
Risk Level:
Testing:
Docs Changes:
Release Notes:
Platform Specific Features:
[Optional Runtime guard:]
[Optional Fixes #Issue]
[Optional Fixes commit #PR or SHA]
[Optional Deprecated:]
[Optional API Considerations:]

Signed-off-by: Alyssa Wilk <alyssar@google.com>
@repokitteh-read-only
Copy link
Copy Markdown

As a reminder, PRs marked as draft will not be automatically assigned reviewers,
or be handled by maintainer-oncall triage.

Please mark your PR as ready when you want it to be reviewed!

🐱

Caused by: #32745 was opened by alyssawilk.

see: more, trace.

Signed-off-by: Alyssa Wilk <alyssar@google.com>
@alyssawilk alyssawilk marked this pull request as ready for review March 6, 2024 20:21
@alyssawilk alyssawilk changed the title rest: reverting E-M macro envoy: reverting unnecessary E-M macro Mar 6, 2024
@alyssawilk alyssawilk enabled auto-merge (squash) March 6, 2024 20:23
@alyssawilk alyssawilk merged commit 3258b4b into envoyproxy:main Mar 7, 2024
mattjo added a commit to mattjo/envoy that referenced this pull request Mar 7, 2024
* origin:
  mobile: Clean up Java and Kotlin code (envoyproxy#32773)
  [mobile] Increase stream response buffer watermark size to 2MB (envoyproxy#32754)
  oauth2: support disabling redirects for AJAX requests (envoyproxy#32655)
  http2: Switch the value of envoy.reloadable_features.http2_use_oghttp2 to false (envoyproxy#32751)
  envoy: reverting unnecessary exception E-M macros (envoyproxy#32745)
  dfp: reverting 31433 (envoyproxy#32743)
  opentelemetrytracer: Allow sampler to set variant type span attribute… (envoyproxy#32681)
  mobile: Java code cleanup (envoyproxy#32747)
  mobile: fix quic_test_server_test (envoyproxy#32755)
  Common TunnelResponseHeadersOrTrailers for UDP & TCP tunneling (envoyproxy#32619)
@alyssawilk alyssawilk deleted the rest branch June 25, 2024 14:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants