http2: Switch the value of envoy.reloadable_features.http2_use_oghttp2 to false#32751
Merged
RyanTheOptimist merged 3 commits intoenvoyproxy:mainfrom Mar 7, 2024
Merged
Conversation
A number of users have reported issues with oghttp2 including seems wise. Signed-off-by: Ryan Hamilton <rch@google.com>
Contributor
Author
|
/assign @alyssawilk |
alyssawilk
reviewed
Mar 6, 2024
Contributor
alyssawilk
left a comment
There was a problem hiding this comment.
arguably we should have a TODO to flip it true and move it to the FALSE section. Mind doing that quickly?
mattklein123
previously approved these changes
Mar 6, 2024
Member
mattklein123
left a comment
There was a problem hiding this comment.
LGTM modulo Alyssa comment. Thank you!
Contributor
Author
Thanks! Done. |
agrawroh
approved these changes
Mar 7, 2024
Member
agrawroh
left a comment
There was a problem hiding this comment.
I think it's good to revert to nghttp2 until we do more testing. Thanks!
phlax
pushed a commit
to phlax/envoy
that referenced
this pull request
Mar 7, 2024
…2 to false (envoyproxy#32751) http2: Switch the value of envoy.reloadable_features.http2_use_oghttp2 to false A number of users have reported issues with oghttp2 including envoyproxy#32611 and envoyproxy#32401 so reverting this flag seems wise. Signed-off-by: Ryan Hamilton <rch@google.com>
mattjo
added a commit
to mattjo/envoy
that referenced
this pull request
Mar 7, 2024
* origin: mobile: Clean up Java and Kotlin code (envoyproxy#32773) [mobile] Increase stream response buffer watermark size to 2MB (envoyproxy#32754) oauth2: support disabling redirects for AJAX requests (envoyproxy#32655) http2: Switch the value of envoy.reloadable_features.http2_use_oghttp2 to false (envoyproxy#32751) envoy: reverting unnecessary exception E-M macros (envoyproxy#32745) dfp: reverting 31433 (envoyproxy#32743) opentelemetrytracer: Allow sampler to set variant type span attribute… (envoyproxy#32681) mobile: Java code cleanup (envoyproxy#32747) mobile: fix quic_test_server_test (envoyproxy#32755) Common TunnelResponseHeadersOrTrailers for UDP & TCP tunneling (envoyproxy#32619)
jbohanon
added a commit
to solo-io/envoy-fork
that referenced
this pull request
Mar 8, 2024
* build(deps): bump distroless/base-nossl-debian12 from `51ab103` to `49edf70` in /ci (envoyproxy#32348) build(deps): bump distroless/base-nossl-debian12 in /ci Bumps distroless/base-nossl-debian12 from `51ab103` to `49edf70`. --- updated-dependencies: - dependency-name: distroless/base-nossl-debian12 dependency-type: direct:production ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Signed-off-by: Ryan Northey <ryan@synca.io> * build(deps): bump distroless/base-nossl-debian12 from `49edf70` to `0e777c6` in /ci (envoyproxy#32576) build(deps): bump distroless/base-nossl-debian12 in /ci Bumps distroless/base-nossl-debian12 from `49edf70` to `0e777c6`. --- updated-dependencies: - dependency-name: distroless/base-nossl-debian12 dependency-type: direct:production ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Signed-off-by: Ryan Northey <ryan@synca.io> * populate histogram summary sample sum Signed-off-by: Sebastian Schepens <sebastian.schepens@mercadolibre.com> * http2: Switch the value of envoy.reloadable_features.http2_use_oghttp2 to false (envoyproxy#32751) http2: Switch the value of envoy.reloadable_features.http2_use_oghttp2 to false A number of users have reported issues with oghttp2 including envoyproxy#32611 and envoyproxy#32401 so reverting this flag seems wise. Signed-off-by: Ryan Hamilton <rch@google.com> * repo: Release v1.29.2 **Summary of changes**: - Revert default codec to nghttp2 as a number of users have reported issues with oghttp2 including envoyproxy#32611 and envoyproxy#32401 - Assorted minor fixes **Docker images**: https://hub.docker.com/r/envoyproxy/envoy/tags?page=1&name=v1.29.2 **Docs**: https://www.envoyproxy.io/docs/envoy/v1.29.2/ **Release notes**: https://www.envoyproxy.io/docs/envoy/v1.29.2/version_history/v1.29/v1.29.2 **Full changelog**: envoyproxy/envoy@v1.29.1...v1.29.2 Signed-off-by: Ryan Northey <ryan@synca.io> --------- Signed-off-by: dependabot[bot] <support@github.com> Signed-off-by: Ryan Northey <ryan@synca.io> Signed-off-by: Sebastian Schepens <sebastian.schepens@mercadolibre.com> Signed-off-by: Ryan Hamilton <rch@google.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Sebastian Schepens <sebastian.schepens@mercadolibre.com> Co-authored-by: Ryan Hamilton <rch@google.com> Co-authored-by: Ryan Northey <ryan@synca.io>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
http2: Switch the value of envoy.reloadable_features.http2_use_oghttp2 to false
A number of users have reported issues with oghttp2 including #32611 and #32401
so reverting this flag seems wise.
Commit Message:
Additional Description:
Risk Level:
Testing:
Docs Changes:
Release Notes:
Platform Specific Features:
[Optional Runtime guard:]
[Optional Fixes #Issue]
[Optional Fixes commit #PR or SHA]
[Optional Deprecated:]
[Optional API Considerations:]