Skip to content

mobile: Java code cleanup#32747

Merged
abeyad merged 1 commit intoenvoyproxy:mainfrom
fredyw:mobile_java_cleanup
Mar 7, 2024
Merged

mobile: Java code cleanup#32747
abeyad merged 1 commit intoenvoyproxy:mainfrom
fredyw:mobile_java_cleanup

Conversation

@fredyw
Copy link
Copy Markdown
Member

@fredyw fredyw commented Mar 6, 2024

This PR does the following cleanup:

  • Fixed typos.
  • Used generic types instead of raw types.
  • Used lambda expression instead of anonymous class.
  • Removed unused imports.

Risk Level: low (cosmetic changes only)
Testing: CI
Docs Changes: n/a
Release Notes: n/a
Platform Specific Features: n/a

@repokitteh-read-only
Copy link
Copy Markdown

As a reminder, PRs marked as draft will not be automatically assigned reviewers,
or be handled by maintainer-oncall triage.

Please mark your PR as ready when you want it to be reviewed!

🐱

Caused by: #32747 was opened by fredyw.

see: more, trace.

@fredyw fredyw force-pushed the mobile_java_cleanup branch from ebb8272 to 83961d2 Compare March 6, 2024 18:30
Signed-off-by: Fredy Wijaya <fredyw@google.com>
@fredyw fredyw force-pushed the mobile_java_cleanup branch from 83961d2 to 46e7a97 Compare March 7, 2024 00:17
@fredyw fredyw marked this pull request as ready for review March 7, 2024 00:17
@fredyw
Copy link
Copy Markdown
Member Author

fredyw commented Mar 7, 2024

/assign @abeyad

@fredyw
Copy link
Copy Markdown
Member Author

fredyw commented Mar 7, 2024

/retest

1 similar comment
@fredyw
Copy link
Copy Markdown
Member Author

fredyw commented Mar 7, 2024

/retest

@abeyad abeyad merged commit 4165adc into envoyproxy:main Mar 7, 2024
@fredyw fredyw deleted the mobile_java_cleanup branch March 7, 2024 13:50
mattjo added a commit to mattjo/envoy that referenced this pull request Mar 7, 2024
* origin:
  mobile: Clean up Java and Kotlin code (envoyproxy#32773)
  [mobile] Increase stream response buffer watermark size to 2MB (envoyproxy#32754)
  oauth2: support disabling redirects for AJAX requests (envoyproxy#32655)
  http2: Switch the value of envoy.reloadable_features.http2_use_oghttp2 to false (envoyproxy#32751)
  envoy: reverting unnecessary exception E-M macros (envoyproxy#32745)
  dfp: reverting 31433 (envoyproxy#32743)
  opentelemetrytracer: Allow sampler to set variant type span attribute… (envoyproxy#32681)
  mobile: Java code cleanup (envoyproxy#32747)
  mobile: fix quic_test_server_test (envoyproxy#32755)
  Common TunnelResponseHeadersOrTrailers for UDP & TCP tunneling (envoyproxy#32619)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants