opentelemetry tracer: Add TraceState types from OTel C++ SDK#32333
Merged
phlax merged 10 commits intoenvoyproxy:mainfrom Feb 22, 2024
Merged
opentelemetry tracer: Add TraceState types from OTel C++ SDK#32333phlax merged 10 commits intoenvoyproxy:mainfrom
phlax merged 10 commits intoenvoyproxy:mainfrom
Conversation
Signed-off-by: Joao Grassi <joao.grassi@dynatrace.com>
Signed-off-by: Joao Grassi <joao.grassi@dynatrace.com>
Signed-off-by: Joao Grassi <joao.grassi@dynatrace.com>
Contributor
Author
|
I have a failing spelling check in one of the tests, but I feel it doesn't make sense to add that to the dictionary. Is there a way to ignore it, in code? (e.g., annotation or so) |
Signed-off-by: Joao Grassi <5938087+joaopgrassi@users.noreply.github.com>
Contributor
Author
|
/retest |
htuch
reviewed
Feb 19, 2024
Signed-off-by: Joao Grassi <5938087+joaopgrassi@users.noreply.github.com>
|
CC @envoyproxy/dependency-shepherds: Your approval is needed for changes made to |
Signed-off-by: Joao Grassi <5938087+joaopgrassi@users.noreply.github.com>
Signed-off-by: Joao Grassi <5938087+joaopgrassi@users.noreply.github.com>
Signed-off-by: Joao Grassi <5938087+joaopgrassi@users.noreply.github.com>
Signed-off-by: Joao Grassi <5938087+joaopgrassi@users.noreply.github.com>
Contributor
Signed-off-by: Joao Grassi <5938087+joaopgrassi@users.noreply.github.com>
Member
|
/retest |
Contributor
Author
|
Seems iOS tests are failing.. not sure if it's related. Let's try again /retest |
ohadvano
pushed a commit
to ohadvano/envoy
that referenced
this pull request
Feb 25, 2024
…oxy#32333) Signed-off-by: Joao Grassi <joao.grassi@dynatrace.com> Signed-off-by: Joao Grassi <5938087+joaopgrassi@users.noreply.github.com>
This was referenced Mar 1, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Commit Message: Add TraceState type following the OTel/W3C specs
Additional Description: TraceState is a type that is used to manipulate the trace state of a traced request. One of the many uses for TraceState is propagation of sampling information, such as sampling probability and randomness.
Risk Level: Low
Testing: Unit tests
Docs Changes: N/A
Release Notes: N/A
Platform Specific Features: N/A
[Optional Runtime guard:]
[Optional Fixes #Issue]
[Optional Fixes commit #PR or SHA]
[Optional Deprecated:]
[Optional API Considerations:]
This is a continuation of the initial Sampling PR #30259. We will be sending another follow up PR for a Dynatrace sampler, and we will need to manipulate the
TraceStatethere. Note that the types here can be used by any other sampler, which may be added in the future, such as the Probability Sampler. This sets the base for it.Note: I did not want to re-invent the wheel, and simply "port" the code from the OTel C++ API/SDK repository that already does all of the
TraceStatehandling. The reason is that is compliant with the OTel/W3C specs and have extensive tests. I'm not sure how such things are handled in Envoy, but that is Apache 2.0 license, and I kept the license heading and added links to the original source files.It is mostly the same, I just adapted it to use
absltypes instead of the ones they use in the OTel C++ SDK repo.CC @wbpcode