Merged
Conversation
Augustyniak
commented
Dec 14, 2022
| encoding:NSUTF8StringEncoding]; | ||
| NSString *value = [[NSString alloc] initWithBytes:native_key.bytes | ||
| length:native_key.length | ||
| NSString *value = [[NSString alloc] initWithBytes:native_value.bytes |
Contributor
Author
There was a problem hiding this comment.
this is the actual bug fix.
Contributor
There was a problem hiding this comment.
good catch! looks like it was a copy-paste bug.
abeyad
previously approved these changes
Dec 14, 2022
Contributor
abeyad
left a comment
There was a problem hiding this comment.
Thanks for adding the test Rafal! I don't know Objective-C, but the fix and the contents of the test LGTM.
| encoding:NSUTF8StringEncoding]; | ||
| NSString *value = [[NSString alloc] initWithBytes:native_key.bytes | ||
| length:native_key.length | ||
| NSString *value = [[NSString alloc] initWithBytes:native_value.bytes |
Contributor
There was a problem hiding this comment.
good catch! looks like it was a copy-paste bug.
jpsim
reviewed
Dec 14, 2022
mobile/library/objective-c/BUILD
Outdated
| }), | ||
| visibility = ["//visibility:public"], | ||
| deps = [ | ||
| ":envoy_aliases_lib", |
Contributor
There was a problem hiding this comment.
Doesn't this dep need to go in envoy_objc_bridge_lib so that the header is available when building it?
Contributor
Author
There was a problem hiding this comment.
it's a part of envoy_objc_bridge_lib already - but you are right, it's redundant here I think. Removing
jpsim
approved these changes
Dec 14, 2022
jpsim
added a commit
that referenced
this pull request
Dec 14, 2022
…-tools * origin/main: (59 commits) Make IsOkAndHolds matcher work with submatchers (#24498) ios: fix platform key value store (#24532) make ClusterInfo::traffic_stats_ a unique_ptr, so that later we can lazy-init it later. (#24406) quic: splitting into client and server (#24513) fixing coverage (#24529) ci: Add `examplesOnly` condition (#24465) ci: sonatype_nexus_upload.py: remove unused format argument (#24471) deps: Bump `build_bazel_rules_apple` -> 1.1.3 (#24527) deps: Bump `com_github_nghttp2_nghttp2` -> 1.51.0 (#24525) deps: Bump `rules_license` -> 0.0.4 (#24523) build(deps): bump sphinxcontrib-httpdomain from 1.8.0 to 1.8.1 in /mobile/docs (#24126) build(deps): bump github/codeql-action from 2.1.35 to 2.1.36 (#24473) build(deps): bump openpolicyagent/opa from 0.47.2-istio to 0.47.3-istio in /examples/ext_authz (#24514) build(deps): bump node from `80844b6` to `2770c78` in /examples/ext_authz/auth/http-service (#24515) build(deps): bump abseil-cpp to latest version (#24386) xDS: add xDS config tracker extension point (#23485) kafka: add shared consumer manager (#24494) coverage: Improve test coverage (#24355) deps: Bump `rules_python` -> 0.16.1 (#24344) ci: revert disable running the Objective-C integration app (#24478)" (#24496) ... Signed-off-by: JP Simard <jp@jpsim.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Commit Message:
Additional Description: Fixes a typo kind of bug in the implementation of the iOS platform key value store and adds a test coverage for iOS platform key value store to test other parts of the implementation and avoid regressions.
Risk Level: Low
Testing: Unit tests
Docs Changes:
Release Notes:
Platform Specific Features:
[Optional Runtime guard:]
[Optional Fixes #Issue]
[Optional Fixes commit #PR or SHA]
[Optional Deprecated:]
[Optional API Considerations:]