As a reminder, PRs marked as draft will not be automatically assigned reviewers,
or be handled by maintainer-oncall triage.

Please mark your PR as ready when you want it to be reviewed!

we could also revert the permissions on the file - so it can be run directly from its shebang

yeah I could do that as well but I wanted to make sure we didn't inadvertantly break it again.

in this case the shebang is bash so i think reverting the permissions is less likely to break anything

i just checked it makes no difference - it will still run bash with sh ...

actually it does matter - i just checked properly (by using bash only syntax) and it errors - at very least this needs to do bash ...

we probably also want to change:

to make it $? -ne 0

I did that, and it didn't make a difference locally. Which makes no sense to me because if I did echo $? it returned 126, but then skipped the -ne 0 block and said coverage passed.

if I did echo $? it returned 126

if im not wrong - its the old chestnut of echo succeeding 8/

does it fail if you do ...

RESPONSE=$?
echo $RESPONSE

if [ $RESPONSE -ne 0 ]; then ...

I don't think I tested that. I think I did run without the echo. no strong feelings here though, I largely just wanted to avoid a second push on something that was working becasue I want to see if the coverage numbers need to be tweaked.

v annoying shellcheck - not sure why the change is triggering this - fix can be:

diff --git a/test/run_envoy_bazel_coverage.sh b/test/run_envoy_bazel_coverage.sh
index 0fe90448b0..6ba361cb3b 100755
--- a/test/run_envoy_bazel_coverage.sh
+++ b/test/run_envoy_bazel_coverage.sh
@@ -119,8 +119,9 @@ set +e
 if [[ "$VALIDATE_COVERAGE" == "true" ]] && [[ "${FUZZ_COVERAGE}" == "false" ]]; then
   echo "Checking per-extension coverage"
   output=$(./test/per_file_coverage.sh)
+  response=$?
 
-  if [ $? -eq 1 ]; then
+  if [ $response -ne 0 ]; then
     echo Per-extension coverage failed:
     echo "$output"
     COVERAGE_FAILED=1