Skip to content

ci: sonatype_nexus_upload.py: remove unused format argument#24471

Merged
jpsim merged 4 commits intoenvoyproxy:mainfrom
rmstoi:rm-unused-arg
Dec 14, 2022
Merged

ci: sonatype_nexus_upload.py: remove unused format argument#24471
jpsim merged 4 commits intoenvoyproxy:mainfrom
rmstoi:rm-unused-arg

Conversation

@rmstoi
Copy link
Copy Markdown

@rmstoi rmstoi commented Dec 9, 2022

artifact_id format argument is unused, thus it can be removed

Signed-off-by: Ruslan Mstoi ruslan.mstoi@intel.com

Commit Message:
Additional Description:
Risk Level:
Testing:
Docs Changes:
Release Notes:
Platform Specific Features:
[Optional Runtime guard:]
[Optional Fixes #Issue]
[Optional Fixes commit #PR or SHA]
[Optional Deprecated:]
[Optional API Considerations:]

artifact_id format argument is unused, thus it can be removed

Signed-off-by: Ruslan Mstoi <ruslan.mstoi@intel.com>
@repokitteh-read-only
Copy link
Copy Markdown

CC @envoyproxy/mobile-maintainers: FYI only for changes made to (mobile/).
envoyproxy/mobile-maintainers assignee is @abeyad

🐱

Caused by: #24471 was opened by rmstoi.

see: more, trace.

jpsim
jpsim previously approved these changes Dec 9, 2022
abeyad
abeyad previously approved these changes Dec 12, 2022
@jpsim
Copy link
Copy Markdown
Contributor

jpsim commented Dec 12, 2022

/retest

@repokitteh-read-only
Copy link
Copy Markdown

Retrying Azure Pipelines:
Retried failed jobs in: envoy-presubmit

🐱

Caused by: a #24471 (comment) was created by @jpsim.

see: more, trace.

@jpsim
Copy link
Copy Markdown
Contributor

jpsim commented Dec 12, 2022

@rmstoi thanks for the PR! Could you please merge main back into your branch to get some CI fixes?

@rmstoi
Copy link
Copy Markdown
Author

rmstoi commented Dec 13, 2022

@rmstoi thanks for the PR! Could you please merge main back into your branch to get some CI fixes?

I just merged main

@abeyad
Copy link
Copy Markdown
Contributor

abeyad commented Dec 13, 2022

Signed-off-by: Ruslan Mstoi <ruslan.mstoi@intel.com>
@rmstoi rmstoi dismissed stale reviews from abeyad and jpsim via 225cf3a December 14, 2022 15:55
@jpsim jpsim enabled auto-merge (squash) December 14, 2022 15:58
@rmstoi
Copy link
Copy Markdown
Author

rmstoi commented Dec 14, 2022

FYI, there as a presubmit formatting error that needs fixing: https://dev.azure.com/cncf/envoy/_build/results?buildId=123363&view=logs&j=55bc2ab9-36c1-5ab8-58a6-8c258728eeff&t=33b57bf9-ef13-58c8-bc2b-f804aeb16d39&l=594

I fixed format error and merged main once again.

@jpsim jpsim merged commit 86f79dc into envoyproxy:main Dec 14, 2022
jpsim added a commit that referenced this pull request Dec 14, 2022
…-tools

* origin/main: (59 commits)
  Make IsOkAndHolds matcher work with submatchers (#24498)
  ios: fix platform key value store (#24532)
  make ClusterInfo::traffic_stats_ a unique_ptr, so that later we can lazy-init it later. (#24406)
  quic: splitting into client and server (#24513)
  fixing coverage (#24529)
  ci: Add `examplesOnly` condition (#24465)
  ci: sonatype_nexus_upload.py: remove unused format argument (#24471)
  deps: Bump `build_bazel_rules_apple` -> 1.1.3 (#24527)
  deps: Bump `com_github_nghttp2_nghttp2` -> 1.51.0 (#24525)
  deps: Bump `rules_license` -> 0.0.4 (#24523)
  build(deps): bump sphinxcontrib-httpdomain from 1.8.0 to 1.8.1 in /mobile/docs (#24126)
  build(deps): bump github/codeql-action from 2.1.35 to 2.1.36 (#24473)
  build(deps): bump openpolicyagent/opa from 0.47.2-istio to 0.47.3-istio in /examples/ext_authz (#24514)
  build(deps): bump node from `80844b6` to `2770c78` in /examples/ext_authz/auth/http-service (#24515)
  build(deps): bump abseil-cpp to latest version (#24386)
  xDS: add xDS config tracker extension point (#23485)
  kafka: add shared consumer manager (#24494)
  coverage: Improve test coverage (#24355)
  deps: Bump `rules_python` -> 0.16.1 (#24344)
  ci: revert disable running the Objective-C integration app (#24478)" (#24496)
  ...

Signed-off-by: JP Simard <jp@jpsim.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants