Skip to content

ci: revert disable running the Objective-C integration app (#24478)"#24496

Merged
Augustyniak merged 8 commits intomainfrom
re-enable-objc-ci-job
Dec 13, 2022
Merged

ci: revert disable running the Objective-C integration app (#24478)"#24496
Augustyniak merged 8 commits intomainfrom
re-enable-objc-ci-job

Conversation

@Augustyniak
Copy link
Copy Markdown
Contributor

@Augustyniak Augustyniak commented Dec 12, 2022

Commit Message:
Additional Description: Re-enables CI job as it should be green again as #24490 was merged and quic socket registration calls are made.
Risk Level: Low
Testing:
Docs Changes:
Release Notes:
Platform Specific Features:
[Optional Runtime guard:]
[Optional Fixes #Issue]
[Optional Fixes commit #PR or SHA]
[Optional Deprecated:]
[Optional API Considerations:]

This reverts commit 0a8043c.

Signed-off-by: Rafal Augustyniak <raugustyniak@lyft.com>
@Augustyniak Augustyniak force-pushed the re-enable-objc-ci-job branch from bcdb32b to 74834de Compare December 12, 2022 19:42
@Augustyniak Augustyniak requested a review from jpsim December 12, 2022 19:42
jpsim
jpsim previously approved these changes Dec 12, 2022
@repokitteh-read-only
Copy link
Copy Markdown

CC @envoyproxy/mobile-maintainers: FYI only for changes made to (mobile/).
envoyproxy/mobile-maintainers assignee is @abeyad

🐱

Caused by: #24496 was synchronize by Augustyniak.

see: more, trace.

deps = [
"extension_registry_platform_additions",
"@envoy//source/common/network:socket_lib",
"@envoy//source/common/quic:quic_transport_socket_factory_lib",
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Needs a envoy_select_enable_http3

@Augustyniak
Copy link
Copy Markdown
Contributor Author

/retest

@repokitteh-read-only
Copy link
Copy Markdown

Retrying Azure Pipelines:
Check envoy-presubmit didn't fail.

🐱

Caused by: a #24496 (comment) was created by @Augustyniak.

see: more, trace.

@Augustyniak Augustyniak merged commit 5438479 into main Dec 13, 2022
@Augustyniak Augustyniak deleted the re-enable-objc-ci-job branch December 13, 2022 14:22
jpsim added a commit that referenced this pull request Dec 14, 2022
…-tools

* origin/main: (59 commits)
  Make IsOkAndHolds matcher work with submatchers (#24498)
  ios: fix platform key value store (#24532)
  make ClusterInfo::traffic_stats_ a unique_ptr, so that later we can lazy-init it later. (#24406)
  quic: splitting into client and server (#24513)
  fixing coverage (#24529)
  ci: Add `examplesOnly` condition (#24465)
  ci: sonatype_nexus_upload.py: remove unused format argument (#24471)
  deps: Bump `build_bazel_rules_apple` -> 1.1.3 (#24527)
  deps: Bump `com_github_nghttp2_nghttp2` -> 1.51.0 (#24525)
  deps: Bump `rules_license` -> 0.0.4 (#24523)
  build(deps): bump sphinxcontrib-httpdomain from 1.8.0 to 1.8.1 in /mobile/docs (#24126)
  build(deps): bump github/codeql-action from 2.1.35 to 2.1.36 (#24473)
  build(deps): bump openpolicyagent/opa from 0.47.2-istio to 0.47.3-istio in /examples/ext_authz (#24514)
  build(deps): bump node from `80844b6` to `2770c78` in /examples/ext_authz/auth/http-service (#24515)
  build(deps): bump abseil-cpp to latest version (#24386)
  xDS: add xDS config tracker extension point (#23485)
  kafka: add shared consumer manager (#24494)
  coverage: Improve test coverage (#24355)
  deps: Bump `rules_python` -> 0.16.1 (#24344)
  ci: revert disable running the Objective-C integration app (#24478)" (#24496)
  ...

Signed-off-by: JP Simard <jp@jpsim.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants