Make IsOkAndHolds matcher work with submatchers#24498
Merged
lizan merged 1 commit intoenvoyproxy:mainfrom Dec 14, 2022
Merged
Conversation
Signed-off-by: Raven Black <ravenblack@dropbox.com>
lizan
approved these changes
Dec 14, 2022
jpsim
added a commit
that referenced
this pull request
Dec 14, 2022
…-tools * origin/main: (59 commits) Make IsOkAndHolds matcher work with submatchers (#24498) ios: fix platform key value store (#24532) make ClusterInfo::traffic_stats_ a unique_ptr, so that later we can lazy-init it later. (#24406) quic: splitting into client and server (#24513) fixing coverage (#24529) ci: Add `examplesOnly` condition (#24465) ci: sonatype_nexus_upload.py: remove unused format argument (#24471) deps: Bump `build_bazel_rules_apple` -> 1.1.3 (#24527) deps: Bump `com_github_nghttp2_nghttp2` -> 1.51.0 (#24525) deps: Bump `rules_license` -> 0.0.4 (#24523) build(deps): bump sphinxcontrib-httpdomain from 1.8.0 to 1.8.1 in /mobile/docs (#24126) build(deps): bump github/codeql-action from 2.1.35 to 2.1.36 (#24473) build(deps): bump openpolicyagent/opa from 0.47.2-istio to 0.47.3-istio in /examples/ext_authz (#24514) build(deps): bump node from `80844b6` to `2770c78` in /examples/ext_authz/auth/http-service (#24515) build(deps): bump abseil-cpp to latest version (#24386) xDS: add xDS config tracker extension point (#23485) kafka: add shared consumer manager (#24494) coverage: Improve test coverage (#24355) deps: Bump `rules_python` -> 0.16.1 (#24344) ci: revert disable running the Objective-C integration app (#24478)" (#24496) ... Signed-off-by: JP Simard <jp@jpsim.com>
ravenblackx
added a commit
to ravenblackx/envoy
that referenced
this pull request
Dec 15, 2022
(past dependency envoyproxy#24498) Signed-off-by: Raven Black <ravenblack@dropbox.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Commit Message: Make IsOkAndHolds matcher work with submatchers
Additional Description: Before this change you can do
IsOkAndHolds(5)but notIsOkAndHolds(Eq(5)). Also,IsOkAndHolds(unprintable_but_equality_comparable_value)wouldn't build before this change, and will after.Risk Level: None, test-only.
Testing: Test-only.
Docs Changes: n/a
Release Notes: n/a
Platform Specific Features: n/a