xDS: add xDS config tracker extension point#23485
xDS: add xDS config tracker extension point#23485mattklein123 merged 43 commits intoenvoyproxy:mainfrom
Conversation
Signed-off-by: Boteng Yao <boteng@google.com>
|
CC @envoyproxy/api-shepherds: Your approval is needed for changes made to |
Signed-off-by: Boteng Yao <boteng@google.com>
…ion-point Signed-off-by: Boteng Yao <boteng@google.com>
Signed-off-by: Boteng Yao <boteng@google.com>
…ion-point Signed-off-by: Boteng Yao <boteng@google.com>
|
Hi @htuch, @adisuissa, sorry for the delay, can we kick off the discussion & review process for this PR? I am mainly adding this as a log point for some external library (e.g., internal crumbs usage). Thank you! |
Signed-off-by: Boteng Yao <boteng@google.com>
adisuissa
left a comment
There was a problem hiding this comment.
Thanks for working on this, very useful!
Left a few high-level design comments.
…ion-point Signed-off-by: Boteng Yao <boteng@google.com>
Signed-off-by: Boteng Yao <boteng@google.com>
…ion-point Signed-off-by: Boteng Yao <boteng@google.com>
…ion-point Signed-off-by: Boteng Yao <boteng@google.com>
|
/assign @envoyproxy/senior-maintainers Can I get another pass for this PR? thanks! |
|
@envoyproxy/senior-maintainers cannot be assigned to this issue. |
|
/assign @mattklein123 |
adisuissa
left a comment
There was a problem hiding this comment.
Thanks, left a few minor comments.
/wait
Signed-off-by: Boteng Yao <boteng@google.com>
…ion-point Signed-off-by: Boteng Yao <boteng@google.com>
|
Hi @mattklein123, @lizan, PTAL and can we get this merged? Thanks! |
| // e.g., external tracer or monitor. It provides the process point when receive, ingest, or fail to | ||
| // process xDS resources and messages. | ||
| // If a value is not specified, no XdsConfigTracker will be used. | ||
| // [#not-implemented-hide:] |
There was a problem hiding this comment.
Why is this not-implemented-hide? Isn't it implemented? Also, can you please add a release note? Thank you.
/wait
There was a problem hiding this comment.
Thanks! This PR only adds an api extension interface right now, and there is no actual extension implementation. This enables the ability to extend this interface for different use cases. Should I add a release note only for this interface?
There was a problem hiding this comment.
The fact that it can be implemented means it's implemented, so I would remove the not-implemented-hide and still add a release note for it. It would be also good to :repo: link to the test extension so people can look at an example of the API, and I would also mention there are no in-repo extensions currently, etc.
There was a problem hiding this comment.
Thanks! Done, and waiting CI.
Signed-off-by: Boteng Yao <boteng@google.com>
…ion-point Signed-off-by: Boteng Yao <boteng@google.com>
|
/retest |
|
Retrying Azure Pipelines: |
…-tools * origin/main: (59 commits) Make IsOkAndHolds matcher work with submatchers (#24498) ios: fix platform key value store (#24532) make ClusterInfo::traffic_stats_ a unique_ptr, so that later we can lazy-init it later. (#24406) quic: splitting into client and server (#24513) fixing coverage (#24529) ci: Add `examplesOnly` condition (#24465) ci: sonatype_nexus_upload.py: remove unused format argument (#24471) deps: Bump `build_bazel_rules_apple` -> 1.1.3 (#24527) deps: Bump `com_github_nghttp2_nghttp2` -> 1.51.0 (#24525) deps: Bump `rules_license` -> 0.0.4 (#24523) build(deps): bump sphinxcontrib-httpdomain from 1.8.0 to 1.8.1 in /mobile/docs (#24126) build(deps): bump github/codeql-action from 2.1.35 to 2.1.36 (#24473) build(deps): bump openpolicyagent/opa from 0.47.2-istio to 0.47.3-istio in /examples/ext_authz (#24514) build(deps): bump node from `80844b6` to `2770c78` in /examples/ext_authz/auth/http-service (#24515) build(deps): bump abseil-cpp to latest version (#24386) xDS: add xDS config tracker extension point (#23485) kafka: add shared consumer manager (#24494) coverage: Improve test coverage (#24355) deps: Bump `rules_python` -> 0.16.1 (#24344) ci: revert disable running the Objective-C integration app (#24478)" (#24496) ... Signed-off-by: JP Simard <jp@jpsim.com>
Signed-off-by: Boteng Yao boteng@google.com
This extension added hooks to allow tracking xDS responses or resources in external components,
e.g., external tracer or monitor. It provides the process point when receive, ingest, or fail to process xDS resources and messages.
Commit Message:
Additional Description:
Risk Level: L
Testing:
Docs Changes:
Release Notes:
Platform Specific Features:
[Optional Runtime guard:]
[Optional Fixes #Issue]
[Optional Fixes commit #PR or SHA]
[Optional Deprecated:]
[Optional API Considerations:]