admin: extract more handlers to separate classes #11258
Merged
mattklein123 merged 6 commits intoenvoyproxy:masterfrom May 20, 2020
Merged
admin: extract more handlers to separate classes #11258mattklein123 merged 6 commits intoenvoyproxy:masterfrom
mattklein123 merged 6 commits intoenvoyproxy:masterfrom
Conversation
Signed-off-by: Erica Manno <erica.manno@gmail.com>
Signed-off-by: Erica Manno <erica.manno@gmail.com>
Signed-off-by: Erica Manno <erica.manno@gmail.com>
Signed-off-by: Erica Manno <erica.manno@gmail.com>
rulex123
commented
May 19, 2020
Comment on lines
-289
to
-294
| Http::Code handlerCpuProfiler(absl::string_view path_and_query, | ||
| Http::ResponseHeaderMap& response_headers, | ||
| Buffer::Instance& response, AdminStream&); | ||
| Http::Code handlerHeapProfiler(absl::string_view path_and_query, | ||
| Http::ResponseHeaderMap& response_headers, | ||
| Buffer::Instance& response, AdminStream&); |
Contributor
Author
There was a problem hiding this comment.
These were accidentally left behind when I worked on #11087; cleaning up now.
rulex123
commented
May 19, 2020
| Http::Code handlerMemory(absl::string_view path_and_query, | ||
| Http::ResponseHeaderMap& response_headers, Buffer::Instance& response, | ||
| AdminStream&); | ||
| Http::Code handlerMain(const std::string& path, Buffer::Instance& response, AdminStream&); |
Contributor
Author
There was a problem hiding this comment.
This code (i.e. handlerMain) is dead I think, so I am cleaning up.
Signed-off-by: Erica Manno <erica.manno@gmail.com>
Signed-off-by: Erica Manno <erica.manno@gmail.com>
Contributor
|
@mattklein123 do you want to have a look at this one? |
spenceral
added a commit
to spenceral/envoy
that referenced
this pull request
May 20, 2020
Signed-off-by: Spencer Lewis <slewis@squareup.com> * master: (33 commits) docs: break release notes into categories (envoyproxy#11217) admin: extract more handlers to separate classes (envoyproxy#11258) Load reporting service documentation (envoyproxy#10962) http: testing 304-with-body behavior (envoyproxy#11261) fixing typos and breaking link issues (envoyproxy#11270) devex: initial commit of devcontainer setup (envoyproxy#11207) security: update policy for fix/disclosure SLOs. (envoyproxy#11243) http: fixing CONNECT to not advertise chunk encoding. (envoyproxy#11245) docs: update upstream network filters description (envoyproxy#11231) deps: update datadog tracer to v1.1.5 (envoyproxy#11253) test: Fix missing instantiation of parameterized tests. (envoyproxy#11247) fix go mirror when no changes (envoyproxy#11249) docs: host_rewrite -> host_rewrite_literal (envoyproxy#11229) wasm: update V8 to v8.3.110.9. (envoyproxy#11233) tls: update BoringSSL to 107c03cf (4103). (envoyproxy#11232) bazelci: always exclude nocoverage tag in coverage config (envoyproxy#11226) ci: save api revision in go-control-plane (envoyproxy#11220) build: fix cares build (envoyproxy#11225) stats: Pre-allocate codec stats for http1 and http2 (envoyproxy#11135) api: manifest based edge default documentation. (envoyproxy#11151) ...
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description: more refactoring for #5505. In this specific PR:
ServerCmdHandlerclassServerInfoHandlerclassStatsHandlerclassRisk Level: low
Testing: pre-existing tests
Docs Changes: n/a
Release Notes: n/a