Skip to content

ci: save api revision in go-control-plane#11220

Merged
htuch merged 2 commits intoenvoyproxy:masterfrom
danielhochman:write-sha-file-gcp
May 18, 2020
Merged

ci: save api revision in go-control-plane#11220
htuch merged 2 commits intoenvoyproxy:masterfrom
danielhochman:write-sha-file-gcp

Conversation

@danielhochman
Copy link
Copy Markdown
Contributor

@danielhochman danielhochman commented May 15, 2020

Commit Message:

When committing generated code from protos into envoyproxy/go-control-plane, also save a file 'COMMIT' with the commit SHA in the root of the generated code directory.

Additional Description:

I have a use case where I want to know the commit used for go-control-plane generated code and I don't also have git history available. This will allow me to read it from a file instead of relying on git history.

Risk Level: Low
Testing: N/A
Docs Changes: N/A
Release Notes: N/A

Signed-off-by: Daniel Hochman danielhochman@users.noreply.github.com

Signed-off-by: Daniel Hochman <danielhochman@users.noreply.github.com>
Signed-off-by: Daniel Hochman <danielhochman@users.noreply.github.com>
@repokitteh-read-only
Copy link
Copy Markdown

CC @envoyproxy/api-shepherds: Your approval is needed for changes made to api/.
CC @envoyproxy/api-watchers: FYI only for changes made to api/.

🐱

Caused by: #11220 was opened by danielhochman.

see: more, trace.

Copy link
Copy Markdown
Member

@htuch htuch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@htuch htuch merged commit ec89d6e into envoyproxy:master May 18, 2020
@danielhochman danielhochman deleted the write-sha-file-gcp branch May 18, 2020 21:59
spenceral added a commit to spenceral/envoy that referenced this pull request May 20, 2020
Signed-off-by: Spencer Lewis <slewis@squareup.com>

* master: (33 commits)
  docs: break release notes into categories (envoyproxy#11217)
  admin: extract more handlers to separate classes  (envoyproxy#11258)
  Load reporting service documentation  (envoyproxy#10962)
  http: testing 304-with-body behavior (envoyproxy#11261)
  fixing typos and breaking link issues (envoyproxy#11270)
  devex: initial commit of devcontainer setup (envoyproxy#11207)
  security: update policy for fix/disclosure SLOs. (envoyproxy#11243)
  http: fixing CONNECT to not advertise chunk encoding. (envoyproxy#11245)
  docs: update upstream network filters description (envoyproxy#11231)
  deps: update datadog tracer to v1.1.5 (envoyproxy#11253)
  test: Fix missing instantiation of parameterized tests. (envoyproxy#11247)
  fix go mirror when no changes (envoyproxy#11249)
  docs: host_rewrite -> host_rewrite_literal (envoyproxy#11229)
  wasm: update V8 to v8.3.110.9. (envoyproxy#11233)
  tls: update BoringSSL to 107c03cf (4103). (envoyproxy#11232)
  bazelci: always exclude nocoverage tag in coverage config (envoyproxy#11226)
  ci: save api revision in go-control-plane (envoyproxy#11220)
  build: fix cares build (envoyproxy#11225)
  stats: Pre-allocate codec stats for http1 and http2 (envoyproxy#11135)
  api: manifest based edge default documentation. (envoyproxy#11151)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants