Skip to content

ci: fix go api mirror script when no changes#11249

Merged
mattklein123 merged 1 commit intoenvoyproxy:masterfrom
danielhochman:fix-generate-go-proto
May 18, 2020
Merged

ci: fix go api mirror script when no changes#11249
mattklein123 merged 1 commit intoenvoyproxy:masterfrom
danielhochman:fix-generate-go-proto

Conversation

@danielhochman
Copy link
Copy Markdown
Contributor

@danielhochman danielhochman commented May 18, 2020

Signed-off-by: Daniel Hochman danielhochman@users.noreply.github.com

Commit Message: fix go api mirror script when no changes
Additional Description:
CI fails when there are no API changes with:

Traceback (most recent call last):
  File "tools/api/generate_go_protobuf.py", line 119, in <module>
    new_sha = changes[0]
IndexError: list index out of range

(broke in #11220)

Risk Level: Low
Testing: N/A
Docs Changes: N/A
Release Notes: N/A

Signed-off-by: Daniel Hochman <danielhochman@users.noreply.github.com>
@repokitteh-read-only
Copy link
Copy Markdown

CC @envoyproxy/api-shepherds: Your approval is needed for changes made to api/.
CC @envoyproxy/api-watchers: FYI only for changes made to api/.

🐱

Caused by: #11249 was opened by danielhochman.

see: more, trace.

Copy link
Copy Markdown
Member

@mattklein123 mattklein123 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@mattklein123 mattklein123 self-assigned this May 18, 2020
@mattklein123 mattklein123 merged commit 32b8445 into envoyproxy:master May 18, 2020
spenceral added a commit to spenceral/envoy that referenced this pull request May 20, 2020
Signed-off-by: Spencer Lewis <slewis@squareup.com>

* master: (33 commits)
  docs: break release notes into categories (envoyproxy#11217)
  admin: extract more handlers to separate classes  (envoyproxy#11258)
  Load reporting service documentation  (envoyproxy#10962)
  http: testing 304-with-body behavior (envoyproxy#11261)
  fixing typos and breaking link issues (envoyproxy#11270)
  devex: initial commit of devcontainer setup (envoyproxy#11207)
  security: update policy for fix/disclosure SLOs. (envoyproxy#11243)
  http: fixing CONNECT to not advertise chunk encoding. (envoyproxy#11245)
  docs: update upstream network filters description (envoyproxy#11231)
  deps: update datadog tracer to v1.1.5 (envoyproxy#11253)
  test: Fix missing instantiation of parameterized tests. (envoyproxy#11247)
  fix go mirror when no changes (envoyproxy#11249)
  docs: host_rewrite -> host_rewrite_literal (envoyproxy#11229)
  wasm: update V8 to v8.3.110.9. (envoyproxy#11233)
  tls: update BoringSSL to 107c03cf (4103). (envoyproxy#11232)
  bazelci: always exclude nocoverage tag in coverage config (envoyproxy#11226)
  ci: save api revision in go-control-plane (envoyproxy#11220)
  build: fix cares build (envoyproxy#11225)
  stats: Pre-allocate codec stats for http1 and http2 (envoyproxy#11135)
  api: manifest based edge default documentation. (envoyproxy#11151)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants