Skip to content

docs: host_rewrite -> host_rewrite_literal in quickstart#11229

Merged
mattklein123 merged 1 commit intoenvoyproxy:masterfrom
jchorl:fixdocs
May 18, 2020
Merged

docs: host_rewrite -> host_rewrite_literal in quickstart#11229
mattklein123 merged 1 commit intoenvoyproxy:masterfrom
jchorl:fixdocs

Conversation

@jchorl
Copy link
Copy Markdown
Contributor

@jchorl jchorl commented May 16, 2020

Commit Message:
Quick docs fix to match v3 protos in

string host_rewrite_literal = 6

Risk Level: low
Testing: look ma no tests
Docs Changes: docs/root/start/start.rst

Signed-off-by: Josh Chorlton <jchorlton@gmail.com>
@jmarantz jmarantz self-assigned this May 18, 2020
Copy link
Copy Markdown
Contributor

@jmarantz jmarantz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@envoyproxy/senior-maintainers

@mattklein123
Copy link
Copy Markdown
Member

@jmarantz feel free to just merge PRs like this in the future.

@mattklein123 mattklein123 merged commit 5347c66 into envoyproxy:master May 18, 2020
spenceral added a commit to spenceral/envoy that referenced this pull request May 20, 2020
Signed-off-by: Spencer Lewis <slewis@squareup.com>

* master: (33 commits)
  docs: break release notes into categories (envoyproxy#11217)
  admin: extract more handlers to separate classes  (envoyproxy#11258)
  Load reporting service documentation  (envoyproxy#10962)
  http: testing 304-with-body behavior (envoyproxy#11261)
  fixing typos and breaking link issues (envoyproxy#11270)
  devex: initial commit of devcontainer setup (envoyproxy#11207)
  security: update policy for fix/disclosure SLOs. (envoyproxy#11243)
  http: fixing CONNECT to not advertise chunk encoding. (envoyproxy#11245)
  docs: update upstream network filters description (envoyproxy#11231)
  deps: update datadog tracer to v1.1.5 (envoyproxy#11253)
  test: Fix missing instantiation of parameterized tests. (envoyproxy#11247)
  fix go mirror when no changes (envoyproxy#11249)
  docs: host_rewrite -> host_rewrite_literal (envoyproxy#11229)
  wasm: update V8 to v8.3.110.9. (envoyproxy#11233)
  tls: update BoringSSL to 107c03cf (4103). (envoyproxy#11232)
  bazelci: always exclude nocoverage tag in coverage config (envoyproxy#11226)
  ci: save api revision in go-control-plane (envoyproxy#11220)
  build: fix cares build (envoyproxy#11225)
  stats: Pre-allocate codec stats for http1 and http2 (envoyproxy#11135)
  api: manifest based edge default documentation. (envoyproxy#11151)
  ...
@masaeedu
Copy link
Copy Markdown

Do mentions of host_rewrite in various places in the examples also need to be updated? E.g.

host_rewrite: www.google.com
(which seems to be the same as the config file I get when I pull down the envoy-dev:latest docker image).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants