Load reporting service documentation #10962
Merged
mattklein123 merged 7 commits intoenvoyproxy:masterfrom May 20, 2020
Merged
Conversation
Signed-off-by: kathan24 <kshah@lyft.com>
Signed-off-by: kathan24 <kshah@lyft.com>
wgallagher
reviewed
Apr 27, 2020
wgallagher
reviewed
Apr 27, 2020
wgallagher
previously approved these changes
Apr 27, 2020
wgallagher
left a comment
There was a problem hiding this comment.
2 very minor comments but looks good
Signed-off-by: kathan24 <kshah@lyft.com>
htuch
reviewed
Apr 28, 2020
Member
htuch
left a comment
There was a problem hiding this comment.
Thanks, the existing docs/comment are quite stale, appreciate the cleanup.
mattklein123
requested changes
Apr 28, 2020
Member
mattklein123
left a comment
There was a problem hiding this comment.
Thanks for doing this. Can you also add some small blurb about this feature to the arch overview with links into the detailed config as well as a link to your example? Perhaps here? https://www.envoyproxy.io/docs/envoy/latest/intro/arch_overview/upstream/upstream
Thank you!
/wait
|
This pull request has been automatically marked as stale because it has not had activity in the last 7 days. It will be closed in 7 days if no further activity occurs. Please feel free to give a status update now, ping for review, or re-open when it's ready. Thank you for your contributions! |
Signed-off-by: kathan24 <kshah@lyft.com>
mattklein123
requested changes
May 12, 2020
Member
mattklein123
left a comment
There was a problem hiding this comment.
Thank you! Looks good with a few small comments. Please also update the PR description to actually properly fill out the template. Thanks!
/wait
| // :ref:`LoadStatsRequest <envoy_api_msg_service.load_stats.v3.LoadStatsRequest>`. This is done periodically | ||
| // based on the :ref:`load reporting interval <envoy_api_field_service.load_stats.v3.LoadStatsResponse.load_reporting_interval>` | ||
| // For details, take a look at the `sandbox example | ||
| // <https://www.envoyproxy.io/docs/envoy/latest/start/sandboxes/load_reporting_service.html>`_. |
Member
There was a problem hiding this comment.
please ref link directly to the RST page vs. use a hard coded link.
docs/root/intro/arch_overview/upstream/load_reporting_service.rst
Outdated
Show resolved
Hide resolved
docs/root/intro/arch_overview/upstream/load_reporting_service.rst
Outdated
Show resolved
Hide resolved
docs/root/intro/arch_overview/upstream/load_reporting_service.rst
Outdated
Show resolved
Hide resolved
…nting-service-doc � Conflicts: � docs/root/api-v3/config/config.rst � generated_api_shadow/envoy/service/load_stats/v3/lrs.proto Signed-off-by: kathan24 <kshah@lyft.com>
Signed-off-by: kathan24 <kshah@lyft.com>
Member
|
Please fix format. /wait |
Signed-off-by: kathan24 <kshah@lyft.com>
spenceral
added a commit
to spenceral/envoy
that referenced
this pull request
May 20, 2020
Signed-off-by: Spencer Lewis <slewis@squareup.com> * master: (33 commits) docs: break release notes into categories (envoyproxy#11217) admin: extract more handlers to separate classes (envoyproxy#11258) Load reporting service documentation (envoyproxy#10962) http: testing 304-with-body behavior (envoyproxy#11261) fixing typos and breaking link issues (envoyproxy#11270) devex: initial commit of devcontainer setup (envoyproxy#11207) security: update policy for fix/disclosure SLOs. (envoyproxy#11243) http: fixing CONNECT to not advertise chunk encoding. (envoyproxy#11245) docs: update upstream network filters description (envoyproxy#11231) deps: update datadog tracer to v1.1.5 (envoyproxy#11253) test: Fix missing instantiation of parameterized tests. (envoyproxy#11247) fix go mirror when no changes (envoyproxy#11249) docs: host_rewrite -> host_rewrite_literal (envoyproxy#11229) wasm: update V8 to v8.3.110.9. (envoyproxy#11233) tls: update BoringSSL to 107c03cf (4103). (envoyproxy#11232) bazelci: always exclude nocoverage tag in coverage config (envoyproxy#11226) ci: save api revision in go-control-plane (envoyproxy#11220) build: fix cares build (envoyproxy#11225) stats: Pre-allocate codec stats for http1 and http2 (envoyproxy#11135) api: manifest based edge default documentation. (envoyproxy#11151) ...
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For an explanation of how to fill out the fields, please see the relevant section
in PULL_REQUESTS.md
Commit Message: Load Reporting Service documentation
Additional Description:
Risk Level: Low
Testing:
Docs Changes: Yes, for Load Reporting Service
Release Notes:
[Optional Fixes #Issue]: 9651
[Optional Deprecated:]