[admin] extract logs and profiler handlers to separate classes#11087
[admin] extract logs and profiler handlers to separate classes#11087jmarantz merged 7 commits intoenvoyproxy:masterfrom
Conversation
Signed-off-by: Erica Manno <erica.manno@gmail.com>
Signed-off-by: Erica Manno <erica.manno@gmail.com>
Signed-off-by: Erica Manno <erica.manno@gmail.com>
Signed-off-by: Erica Manno <erica.manno@gmail.com>
Signed-off-by: Erica Manno <erica.manno@gmail.com>
Signed-off-by: Erica Manno <erica.manno@gmail.com>
There was a problem hiding this comment.
This looks great. Thank you!
@mattklein123 I'm wondering, is there anything under source/server/http that is not for the admin endpoint? I wonder if we should rename that directory sourcer/server/admin. Also note that in the future the admin handling may occur via some gRPC mechanism in addition to via http, and in fact it's already available via direct call from outside the server, bypassing HTTP. WDYT?
That could be a follow-up to this PR of course.
|
/wait |
You read my mind, I was going to suggest renaming the directory when this was complete. Sounds great. Agreed we can do as a follow up so should we just merge this? |
|
yup, follow-up would be great. |
|
Cool, will do a follow-up PR to rename the directory. |
Description: extract logging and profiling-related handlers from
admin.h|ccand into separate classes (part of #5505 )Risk Level: low
Testing: pre-existing tests
Docs Changes: n/a
Release Notes: n/a